[PATCH] ALSA: ymfpci: Use u16 consistently for old_legacy_ctrl

[PATCH] ALSA: ymfpci: Use u16 consistently for old_legacy_ctrl

[Tasos Sahanidis via Alsa-devel]

[-- Attachment #0: Type: message/rfc822, Size: 5023 bytes --]

From: Tasos Sahanidis <tasos@tasossah.com>
To: alsa-devel@alsa-project.org
Cc: tiwai@suse.com, tasos@tasossah.com
Subject: [PATCH] ALSA: ymfpci: Use u16 consistently for old_legacy_ctrl
Date: Wed, 29 Mar 2023 07:36:27 +0300
Message-ID: <20230329043627.178899-1-tasos@tasossah.com>

There's no need to switch between unsigned short and u16, especially since
all the functions that end up using old_legacy_ctrl specify u16 anyway.

Signed-off-by: Tasos Sahanidis <tasos@tasossah.com>
---
 sound/pci/ymfpci/ymfpci.h      | 4 ++--
 sound/pci/ymfpci/ymfpci_main.c | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/sound/pci/ymfpci/ymfpci.h b/sound/pci/ymfpci/ymfpci.h
index 669687764..d11f9bf5a 100644
--- a/sound/pci/ymfpci/ymfpci.h
+++ b/sound/pci/ymfpci/ymfpci.h
@@ -276,7 +276,7 @@ struct snd_ymfpci {
 	unsigned long reg_area_phys;
 	void __iomem *reg_area_virt;
 
-	unsigned short old_legacy_ctrl;
+	u16 old_legacy_ctrl;
 #ifdef SUPPORT_JOYSTICK
 	struct gameport *gameport;
 #endif
@@ -355,7 +355,7 @@ struct snd_ymfpci {
 
 int snd_ymfpci_create(struct snd_card *card,
 		      struct pci_dev *pci,
-		      unsigned short old_legacy_ctrl);
+		      u16 old_legacy_ctrl);
 void snd_ymfpci_free_gameport(struct snd_ymfpci *chip);
 
 extern const struct dev_pm_ops snd_ymfpci_pm;
diff --git a/sound/pci/ymfpci/ymfpci_main.c b/sound/pci/ymfpci/ymfpci_main.c
index 2858736ed..d44ecd916 100644
--- a/sound/pci/ymfpci/ymfpci_main.c
+++ b/sound/pci/ymfpci/ymfpci_main.c
@@ -2309,7 +2309,7 @@ SIMPLE_DEV_PM_OPS(snd_ymfpci_pm, snd_ymfpci_suspend, snd_ymfpci_resume);
 
 int snd_ymfpci_create(struct snd_card *card,
 		      struct pci_dev *pci,
-		      unsigned short old_legacy_ctrl)
+		      u16 old_legacy_ctrl)
 {
 	struct snd_ymfpci *chip = card->private_data;
 	int err;
-- 
2.25.1

Re: [PATCH] ALSA: ymfpci: Use u16 consistently for old_legacy_ctrl

[Takashi Iwai]

On Wed, 29 Mar 2023 06:36:27 +0200,
Tasos Sahanidis wrote:
> 
> There's no need to switch between unsigned short and u16, especially since
> all the functions that end up using old_legacy_ctrl specify u16 anyway.
> 
> Signed-off-by: Tasos Sahanidis <tasos@tasossah.com>

Applied to for-next branch.


thanks,

Takashi