All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Jaroslav Kysela <perex@perex.cz>
Cc: ALSA development <alsa-devel@alsa-project.org>,
	Jimmy Cheng-Yi Chiang <cychiang@google.com>,
	Curtis Malainey <cujomalainey@google.com>,
	Brian Norris <briannorris@chromium.org>,
	Mark Brown <broonie@kernel.org>,
	Liam Girdwood <liam.r.girdwood@intel.com>,
	Jesse Barnes <jsbarnes@google.com>,
	Pierre-Louis Bossart <pierre-louis.bossart@intel.com>
Subject: Re: [PATCH v2] [RFC] selftests: alsa - add PCM test
Date: Wed, 16 Nov 2022 15:03:55 +0100	[thread overview]
Message-ID: <87pmdn3sj8.wl-tiwai@suse.de> (raw)
In-Reply-To: <20221108115914.3751090-1-perex@perex.cz>

On Tue, 08 Nov 2022 12:59:14 +0100,
Jaroslav Kysela wrote:
> 
> This initial code does a simple sample transfer tests. By default,
> all PCM devices are detected and tested with short and long
> buffering parameters for 4 seconds. If the sample transfer timing
> is not in a +-100ms boundary, the test fails. Only the interleaved
> buffering scheme is supported in this version.
> 
> The configuration may be modified with the configuration files.
> A specific hardware configuration is detected and activated
> using the sysfs regex matching. This allows to use the DMI string
> (/sys/class/dmi/id/* tree) or any other system parameters
> exposed in sysfs for the matching for the CI automation.
> 
> The configuration file may also specify the PCM device list to detect
> the missing PCM devices.
> 
> v1..v2:
>   - added missing alsa-local.h header file
> 
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Pierre-Louis Bossart <pierre-louis.bossart@intel.com>
> Cc: Liam Girdwood <liam.r.girdwood@intel.com>
> Cc: Jesse Barnes <jsbarnes@google.com>
> Cc: Jimmy Cheng-Yi Chiang <cychiang@google.com>
> Cc: Curtis Malainey <cujomalainey@google.com>
> Cc: Brian Norris <briannorris@chromium.org>
> Signed-off-by: Jaroslav Kysela <perex@perex.cz>

Sorry for the late reply.

The patch looks good and works fine on the smoke test, so I applied it
now.  There are a few issues Mark already commented on, and we can fix
or improve them in incremental manner later.


thanks,

Takashi

  parent reply	other threads:[~2022-11-16 14:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-08 11:59 [PATCH v2] [RFC] selftests: alsa - add PCM test Jaroslav Kysela
2022-11-08 14:46 ` Mark Brown
2022-11-08 14:46   ` Mark Brown
2022-11-16 14:03 ` Takashi Iwai [this message]
2022-11-16 14:17   ` Jaroslav Kysela
2022-11-28 19:55 ` Mark Brown
2022-11-29  8:58   ` Jaroslav Kysela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pmdn3sj8.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=briannorris@chromium.org \
    --cc=broonie@kernel.org \
    --cc=cujomalainey@google.com \
    --cc=cychiang@google.com \
    --cc=jsbarnes@google.com \
    --cc=liam.r.girdwood@intel.com \
    --cc=perex@perex.cz \
    --cc=pierre-louis.bossart@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.