From: Cornelia Huck <cohuck@redhat.com>
To: Eric Farman <farman@linux.ibm.com>,
Matthew Rosato <mjrosato@linux.ibm.com>,
Alex Williamson <alex.williamson@redhat.com>,
Jason Gunthorpe <jgg@nvidia.com>,
Kevin Tian <kevin.tian@intel.com>, Yi Liu <yi.l.liu@intel.com>
Cc: kvm@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org,
Kirti Wankhede <kwankhede@nvidia.com>,
Vineeth Vijayan <vneethv@linux.ibm.com>,
Diana Craciun <diana.craciun@oss.nxp.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
David Airlie <airlied@gmail.com>,
linux-s390@vger.kernel.org, Halil Pasic <pasic@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
intel-gfx@lists.freedesktop.org,
Jason Herne <jjherne@linux.ibm.com>,
Eric Farman <farman@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Heiko Carstens <hca@linux.ibm.com>,
Eric Auger <eric.auger@redhat.com>,
Harald Freudenberger <freude@linux.ibm.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
intel-gvt-dev@lists.freedesktop.org,
Tony Krowiak <akrowiak@linux.ibm.com>,
Yishai Hadas <yishaih@nvidia.com>,
Peter Oberparleiter <oberpar@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
Daniel Vetter <daniel@ffwll.ch>,
Abhishek Sahu <abhsahu@nvidia.com>
Subject: Re: [Intel-gfx] [PATCH v2 7/7] vfio: Remove vfio_free_device
Date: Wed, 02 Nov 2022 16:33:34 +0100 [thread overview]
Message-ID: <87pme5s75d.fsf@redhat.com> (raw)
In-Reply-To: <20221102150152.2521475-8-farman@linux.ibm.com>
On Wed, Nov 02 2022, Eric Farman <farman@linux.ibm.com> wrote:
> With the "mess" sorted out, we should be able to inline the
> vfio_free_device call introduced by commit cb9ff3f3b84c
> ("vfio: Add helpers for unifying vfio_device life cycle")
> and remove them from driver release callbacks.
>
> Signed-off-by: Eric Farman <farman@linux.ibm.com>
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
> Reviewed-by: Kevin Tian <kevin.tian@intel.com>
> ---
> drivers/gpu/drm/i915/gvt/kvmgt.c | 1 -
> drivers/s390/cio/vfio_ccw_ops.c | 2 --
> drivers/s390/crypto/vfio_ap_ops.c | 6 ------
> drivers/vfio/fsl-mc/vfio_fsl_mc.c | 1 -
> drivers/vfio/pci/vfio_pci_core.c | 1 -
> drivers/vfio/platform/vfio_amba.c | 1 -
> drivers/vfio/platform/vfio_platform.c | 1 -
> drivers/vfio/vfio_main.c | 22 ++++------------------
> include/linux/vfio.h | 1 -
> samples/vfio-mdev/mbochs.c | 1 -
> samples/vfio-mdev/mdpy.c | 1 -
> samples/vfio-mdev/mtty.c | 1 -
> 12 files changed, 4 insertions(+), 35 deletions(-)
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
WARNING: multiple messages have this Message-ID (diff)
From: Cornelia Huck <cohuck@redhat.com>
To: Eric Farman <farman@linux.ibm.com>,
Matthew Rosato <mjrosato@linux.ibm.com>,
Alex Williamson <alex.williamson@redhat.com>,
Jason Gunthorpe <jgg@nvidia.com>,
Kevin Tian <kevin.tian@intel.com>, Yi Liu <yi.l.liu@intel.com>
Cc: Zhenyu Wang <zhenyuw@linux.intel.com>,
Zhi Wang <zhi.a.wang@intel.com>,
Jani Nikula <jani.nikula@linux.intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Halil Pasic <pasic@linux.ibm.com>,
Vineeth Vijayan <vneethv@linux.ibm.com>,
Peter Oberparleiter <oberpar@linux.ibm.com>,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
Tony Krowiak <akrowiak@linux.ibm.com>,
Jason Herne <jjherne@linux.ibm.com>,
Harald Freudenberger <freude@linux.ibm.com>,
Diana Craciun <diana.craciun@oss.nxp.com>,
Eric Auger <eric.auger@redhat.com>,
Kirti Wankhede <kwankhede@nvidia.com>,
Abhishek Sahu <abhsahu@nvidia.com>,
Yishai Hadas <yishaih@nvidia.com>,
intel-gvt-dev@lists.freedesktop.org,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
kvm@vger.kernel.org, Eric Farman <farman@linux.ibm.com>
Subject: Re: [PATCH v2 7/7] vfio: Remove vfio_free_device
Date: Wed, 02 Nov 2022 16:33:34 +0100 [thread overview]
Message-ID: <87pme5s75d.fsf@redhat.com> (raw)
In-Reply-To: <20221102150152.2521475-8-farman@linux.ibm.com>
On Wed, Nov 02 2022, Eric Farman <farman@linux.ibm.com> wrote:
> With the "mess" sorted out, we should be able to inline the
> vfio_free_device call introduced by commit cb9ff3f3b84c
> ("vfio: Add helpers for unifying vfio_device life cycle")
> and remove them from driver release callbacks.
>
> Signed-off-by: Eric Farman <farman@linux.ibm.com>
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
> Reviewed-by: Kevin Tian <kevin.tian@intel.com>
> ---
> drivers/gpu/drm/i915/gvt/kvmgt.c | 1 -
> drivers/s390/cio/vfio_ccw_ops.c | 2 --
> drivers/s390/crypto/vfio_ap_ops.c | 6 ------
> drivers/vfio/fsl-mc/vfio_fsl_mc.c | 1 -
> drivers/vfio/pci/vfio_pci_core.c | 1 -
> drivers/vfio/platform/vfio_amba.c | 1 -
> drivers/vfio/platform/vfio_platform.c | 1 -
> drivers/vfio/vfio_main.c | 22 ++++------------------
> include/linux/vfio.h | 1 -
> samples/vfio-mdev/mbochs.c | 1 -
> samples/vfio-mdev/mdpy.c | 1 -
> samples/vfio-mdev/mtty.c | 1 -
> 12 files changed, 4 insertions(+), 35 deletions(-)
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
WARNING: multiple messages have this Message-ID (diff)
From: Cornelia Huck <cohuck@redhat.com>
To: Eric Farman <farman@linux.ibm.com>,
Matthew Rosato <mjrosato@linux.ibm.com>,
Alex Williamson <alex.williamson@redhat.com>,
Jason Gunthorpe <jgg@nvidia.com>,
Kevin Tian <kevin.tian@intel.com>, Yi Liu <yi.l.liu@intel.com>
Cc: kvm@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org,
Kirti Wankhede <kwankhede@nvidia.com>,
Vineeth Vijayan <vneethv@linux.ibm.com>,
Diana Craciun <diana.craciun@oss.nxp.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
linux-s390@vger.kernel.org, Halil Pasic <pasic@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
intel-gfx@lists.freedesktop.org, Zhi Wang <zhi.a.wang@intel.com>,
Jason Herne <jjherne@linux.ibm.com>,
Eric Farman <farman@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Heiko Carstens <hca@linux.ibm.com>,
Eric Auger <eric.auger@redhat.com>,
Harald Freudenberger <freude@linux.ibm.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
intel-gvt-dev@lists.freedesktop.org,
Tony Krowiak <akrowiak@linux.ibm.com>,
Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
Yishai Hadas <yishaih@nvidia.com>,
Peter Oberparleiter <oberpar@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
Abhishek Sahu <abhsahu@nvidia.com>
Subject: Re: [PATCH v2 7/7] vfio: Remove vfio_free_device
Date: Wed, 02 Nov 2022 16:33:34 +0100 [thread overview]
Message-ID: <87pme5s75d.fsf@redhat.com> (raw)
In-Reply-To: <20221102150152.2521475-8-farman@linux.ibm.com>
On Wed, Nov 02 2022, Eric Farman <farman@linux.ibm.com> wrote:
> With the "mess" sorted out, we should be able to inline the
> vfio_free_device call introduced by commit cb9ff3f3b84c
> ("vfio: Add helpers for unifying vfio_device life cycle")
> and remove them from driver release callbacks.
>
> Signed-off-by: Eric Farman <farman@linux.ibm.com>
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
> Reviewed-by: Kevin Tian <kevin.tian@intel.com>
> ---
> drivers/gpu/drm/i915/gvt/kvmgt.c | 1 -
> drivers/s390/cio/vfio_ccw_ops.c | 2 --
> drivers/s390/crypto/vfio_ap_ops.c | 6 ------
> drivers/vfio/fsl-mc/vfio_fsl_mc.c | 1 -
> drivers/vfio/pci/vfio_pci_core.c | 1 -
> drivers/vfio/platform/vfio_amba.c | 1 -
> drivers/vfio/platform/vfio_platform.c | 1 -
> drivers/vfio/vfio_main.c | 22 ++++------------------
> include/linux/vfio.h | 1 -
> samples/vfio-mdev/mbochs.c | 1 -
> samples/vfio-mdev/mdpy.c | 1 -
> samples/vfio-mdev/mtty.c | 1 -
> 12 files changed, 4 insertions(+), 35 deletions(-)
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
next prev parent reply other threads:[~2022-11-02 15:34 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-02 15:01 [Intel-gfx] [PATCH v2 0/7] vfio-ccw parent rework Eric Farman
2022-11-02 15:01 ` Eric Farman
2022-11-02 15:01 ` Eric Farman
2022-11-02 15:01 ` [Intel-gfx] [PATCH v2 1/7] vfio/ccw: create a parent struct Eric Farman
2022-11-02 15:01 ` Eric Farman
2022-11-02 15:01 ` Eric Farman
2022-11-02 19:29 ` [Intel-gfx] " Eric Farman
2022-11-02 19:29 ` Eric Farman
2022-11-02 19:29 ` Eric Farman
2022-11-02 20:00 ` [Intel-gfx] " Matthew Rosato
2022-11-02 20:00 ` Matthew Rosato
2022-11-02 20:00 ` Matthew Rosato
2022-11-03 23:10 ` [Intel-gfx] " Matthew Rosato
2022-11-03 23:10 ` Matthew Rosato
2022-11-03 23:10 ` Matthew Rosato
2022-11-02 15:01 ` [Intel-gfx] [PATCH v2 2/7] vfio/ccw: remove private->sch Eric Farman
2022-11-02 15:01 ` Eric Farman
2022-11-02 15:01 ` Eric Farman
2022-11-02 15:01 ` [Intel-gfx] [PATCH v2 3/7] vfio/ccw: move private initialization to callback Eric Farman
2022-11-02 15:01 ` Eric Farman
2022-11-02 15:01 ` Eric Farman
2022-11-02 15:01 ` [Intel-gfx] [PATCH v2 4/7] vfio/ccw: move private to mdev lifecycle Eric Farman
2022-11-02 15:01 ` Eric Farman
2022-11-02 15:01 ` Eric Farman
2022-11-03 23:22 ` [Intel-gfx] " Matthew Rosato
2022-11-03 23:22 ` Matthew Rosato
2022-11-03 23:22 ` Matthew Rosato
2022-11-04 12:27 ` [Intel-gfx] " Eric Farman
2022-11-04 12:27 ` Eric Farman
2022-11-04 12:27 ` Eric Farman
2022-11-02 15:01 ` [Intel-gfx] [PATCH v2 5/7] vfio/ccw: remove release completion Eric Farman
2022-11-02 15:01 ` Eric Farman
2022-11-02 15:01 ` Eric Farman
2022-11-03 23:24 ` [Intel-gfx] " Matthew Rosato
2022-11-03 23:24 ` Matthew Rosato
2022-11-03 23:24 ` Matthew Rosato
2022-11-02 15:01 ` [Intel-gfx] [PATCH v2 6/7] vfio/ccw: replace vfio_init_device with _alloc_ Eric Farman
2022-11-02 15:01 ` Eric Farman
2022-11-02 15:01 ` Eric Farman
2022-11-03 23:32 ` [Intel-gfx] " Matthew Rosato
2022-11-03 23:32 ` Matthew Rosato
2022-11-03 23:32 ` Matthew Rosato
2022-11-02 15:01 ` [Intel-gfx] [PATCH v2 7/7] vfio: Remove vfio_free_device Eric Farman
2022-11-02 15:01 ` Eric Farman
2022-11-02 15:01 ` Eric Farman
2022-11-02 15:33 ` Cornelia Huck [this message]
2022-11-02 15:33 ` Cornelia Huck
2022-11-02 15:33 ` Cornelia Huck
2022-11-02 17:36 ` [Intel-gfx] " Anthony Krowiak
2022-11-02 17:36 ` Anthony Krowiak
2022-11-02 17:36 ` Anthony Krowiak
2022-11-03 23:34 ` [Intel-gfx] " Matthew Rosato
2022-11-03 23:34 ` Matthew Rosato
2022-11-03 23:34 ` Matthew Rosato
2022-11-02 16:54 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for vfio-ccw parent rework (rev2) Patchwork
2022-11-02 16:54 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork
2022-11-02 17:13 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-11-02 22:15 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-11-03 21:56 ` [Intel-gfx] [PATCH v2 0/7] vfio-ccw parent rework Alex Williamson
2022-11-03 21:56 ` Alex Williamson
2022-11-03 21:56 ` Alex Williamson
2022-11-03 23:43 ` [Intel-gfx] " Matthew Rosato
2022-11-03 23:43 ` Matthew Rosato
2022-11-03 23:43 ` Matthew Rosato
2022-11-04 12:23 ` [Intel-gfx] " Eric Farman
2022-11-04 12:23 ` Eric Farman
2022-11-04 12:23 ` Eric Farman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pme5s75d.fsf@redhat.com \
--to=cohuck@redhat.com \
--cc=abhsahu@nvidia.com \
--cc=agordeev@linux.ibm.com \
--cc=airlied@gmail.com \
--cc=akrowiak@linux.ibm.com \
--cc=alex.williamson@redhat.com \
--cc=borntraeger@linux.ibm.com \
--cc=daniel@ffwll.ch \
--cc=diana.craciun@oss.nxp.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=eric.auger@redhat.com \
--cc=farman@linux.ibm.com \
--cc=freude@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=jgg@nvidia.com \
--cc=jjherne@linux.ibm.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mjrosato@linux.ibm.com \
--cc=oberpar@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=rodrigo.vivi@intel.com \
--cc=svens@linux.ibm.com \
--cc=vneethv@linux.ibm.com \
--cc=yi.l.liu@intel.com \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.