All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@kernel.org>
To: James Prestwood <prestwoj@gmail.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] net: mac80211: remove/avoid misleading prints
Date: Fri, 16 Sep 2022 08:44:17 +0300	[thread overview]
Message-ID: <87pmfvan66.fsf@kernel.org> (raw)
In-Reply-To: <20220915195553.1052931-1-prestwoj@gmail.com> (James Prestwood's message of "Thu, 15 Sep 2022 12:55:53 -0700")

James Prestwood <prestwoj@gmail.com> writes:

> At some point a few kernel debug prints started appearing which
> indicated something was sending invalid IEs:
>
> "bad VHT capabilities, disabling VHT"
> "Invalid HE elem, Disable HE"
>
> Turns out these were being printed because the local hardware
> supported HE/VHT but the peer/AP did not. Bad/invalid indicates,
> to me at least, that the IE is in some way malformed, not missing.
>
> For the HE print (ieee80211_verify_peer_he_mcs_support) it will
> now silently fail if the HE capability element is missing (still
> prints if the element size is wrong).
>
> For the VHT print, it has been removed completely and will silently
> set the DISABLE_VHT flag which is consistent with how DISABLE_HT
> is set.
>
> Signed-off-by: James Prestwood <prestwoj@gmail.com>

This has been cluttering my test logs as well, thanks for fixing this.
But the title should be:

wifi: mac80211: remove/avoid misleading prints

I assume Johannes can fix it during commit.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

      reply	other threads:[~2022-09-16  5:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-15 19:55 [PATCH] net: mac80211: remove/avoid misleading prints James Prestwood
2022-09-16  5:44 ` Kalle Valo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pmfvan66.fsf@kernel.org \
    --to=kvalo@kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=prestwoj@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.