All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Pattara Teerapong <pteerapong@chromium.org>
Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
	Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH] ALSA: aloop: Fix random zeros in capture data when using jiffies timer
Date: Fri, 02 Sep 2022 08:58:39 +0200	[thread overview]
Message-ID: <87pmgew9cw.wl-tiwai@suse.de> (raw)
In-Reply-To: <20220901144036.4049060-1-pteerapong@chromium.org>

On Thu, 01 Sep 2022 16:40:36 +0200,
Pattara Teerapong wrote:
> 
> In loopback_jiffies_timer_pos_update(), we are getting jiffies twice.
> First time for playback, second time for capture. Jiffies can be updated
> between these two calls and if the capture jiffies is larger, extra zeros
> will be filled in the capture buffer.
> 
> Change to get jiffies once and use it for both playback and capture.
> 
> Signed-off-by: Pattara Teerapong <pteerapong@chromium.org>

Thanks, applied.


Takashi

WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Pattara Teerapong <pteerapong@chromium.org>
Cc: alsa-devel@alsa-project.org, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: aloop: Fix random zeros in capture data when using jiffies timer
Date: Fri, 02 Sep 2022 08:58:39 +0200	[thread overview]
Message-ID: <87pmgew9cw.wl-tiwai@suse.de> (raw)
In-Reply-To: <20220901144036.4049060-1-pteerapong@chromium.org>

On Thu, 01 Sep 2022 16:40:36 +0200,
Pattara Teerapong wrote:
> 
> In loopback_jiffies_timer_pos_update(), we are getting jiffies twice.
> First time for playback, second time for capture. Jiffies can be updated
> between these two calls and if the capture jiffies is larger, extra zeros
> will be filled in the capture buffer.
> 
> Change to get jiffies once and use it for both playback and capture.
> 
> Signed-off-by: Pattara Teerapong <pteerapong@chromium.org>

Thanks, applied.


Takashi

  reply	other threads:[~2022-09-02  6:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-01 14:40 [PATCH] ALSA: aloop: Fix random zeros in capture data when using jiffies timer Pattara Teerapong
2022-09-01 14:40 ` Pattara Teerapong
2022-09-02  6:58 ` Takashi Iwai [this message]
2022-09-02  6:58   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pmgew9cw.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pteerapong@chromium.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.