From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] tests/api_intel_bb: Handle different alignments in delta-check
Date: Tue, 08 Feb 2022 04:38:17 -0800 [thread overview]
Message-ID: <87pmnxfs92.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <YgIhKUWdW8d0ZFb8@zkempczy-mobl2>
On Mon, 07 Feb 2022 23:52:09 -0800, Zbigniew Kempczyński wrote:
>
> > Patch is correct. However shouldn't we add gem_detect_safe_alignment() to
> > intel_bb_add_object() too? Thanks.
>
> If you mean we should fix intel_bb_add_object() and __intel_bb_create()
> I'm with you.
Correct!
> Currently it works because bb gem object is created within system memory
> and generally both offsets are page aligned. But I agree, we should change
> intel-bb alignment handling.
>
> I'm going to prepare such patch soon but I don't know should I mix this
> with delta-check. Please decide.
Sorry, I meant do this independently of delta-check. Delta-check is already
merged. Thanks.
prev parent reply other threads:[~2022-02-08 12:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-07 18:34 [igt-dev] [PATCH i-g-t] tests/api_intel_bb: Handle different alignments in delta-check Zbigniew Kempczyński
2022-02-07 19:32 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2022-02-07 21:46 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2022-02-07 23:14 ` [igt-dev] [PATCH i-g-t] " Dixit, Ashutosh
2022-02-08 7:52 ` Zbigniew Kempczyński
2022-02-08 12:38 ` Dixit, Ashutosh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmnxfs92.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=zbigniew.kempczynski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.