All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jim Turner <linuxkernel.foss@dmarc-none.turner.link>
To: "Lazar, Lijo" <lijo.lazar@amd.com>
Cc: "regressions@lists.linux.dev" <regressions@lists.linux.dev>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	Greg KH <gregkh@linuxfoundation.org>,
	"Pan, Xinhui" <Xinhui.Pan@amd.com>,
	LKML <linux-kernel@vger.kernel.org>,
	"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>,
	"Deucher, Alexander" <Alexander.Deucher@amd.com>,
	Alex Williamson <alex.williamson@redhat.com>,
	Thorsten Leemhuis <regressions@leemhuis.info>,
	Alex Deucher <alexdeucher@gmail.com>,
	"Koenig, Christian" <Christian.Koenig@amd.com>
Subject: Re: [REGRESSION] Too-low frequency limit for AMD GPU PCI-passed-through to Windows VM
Date: Sat, 29 Jan 2022 19:25:07 -0500	[thread overview]
Message-ID: <87pmo8r6ob.fsf@turner.link> (raw)
In-Reply-To: <4b3ed7f6-d2b6-443c-970e-d963066ebfe3@amd.com>

Hi Lijo,

> Specifically, I was looking for any events happening at these two
> places because of the patch-
>
> https://elixir.bootlin.com/linux/v5.16/source/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c#L411
>
> https://elixir.bootlin.com/linux/v5.16/source/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c#L653

I searched the logs generated with all drm debug messages enabled
(drm.debug=0x1ff) for "device_class", "ATCS", "atcs", "ATIF", and
"atif", for both f1688bd69ec4 and f9b7f3703ff9. Other than the few lines
mentioning ATIF from my previous email, there weren't any matches.

Since "device_class" didn't appear in the logs, we know that
`amdgpu_atif_handler` was not called for either version.

I also patched f9b7f3703ff9 to add the line

  DRM_DEBUG_DRIVER("Entered amdgpu_acpi_pcie_performance_request");

at the top (below the variable declarations) of
`amdgpu_acpi_pcie_performance_request`, and then tested again with all
drm debug messages enabled (0x1ff). That debug message didn't show up.

So, `amdgpu_acpi_pcie_performance_request` was not called either, at
least with f9b7f3703ff9. (I didn't try adding this patch to
f1688bd69ec4.)

Would anything else be helpful?

James

WARNING: multiple messages have this Message-ID (diff)
From: Jim Turner <linuxkernel.foss@dmarc-none.turner.link>
To: "Lazar, Lijo" <lijo.lazar@amd.com>
Cc: Alex Deucher <alexdeucher@gmail.com>,
	Thorsten Leemhuis <regressions@leemhuis.info>,
	"Deucher, Alexander" <Alexander.Deucher@amd.com>,
	"regressions@lists.linux.dev" <regressions@lists.linux.dev>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	Greg KH <gregkh@linuxfoundation.org>,
	"Pan, Xinhui" <Xinhui.Pan@amd.com>,
	LKML <linux-kernel@vger.kernel.org>,
	"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	"Koenig, Christian" <Christian.Koenig@amd.com>
Subject: Re: [REGRESSION] Too-low frequency limit for AMD GPU PCI-passed-through to Windows VM
Date: Sat, 29 Jan 2022 19:25:07 -0500	[thread overview]
Message-ID: <87pmo8r6ob.fsf@turner.link> (raw)
In-Reply-To: <4b3ed7f6-d2b6-443c-970e-d963066ebfe3@amd.com>

Hi Lijo,

> Specifically, I was looking for any events happening at these two
> places because of the patch-
>
> https://elixir.bootlin.com/linux/v5.16/source/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c#L411
>
> https://elixir.bootlin.com/linux/v5.16/source/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c#L653

I searched the logs generated with all drm debug messages enabled
(drm.debug=0x1ff) for "device_class", "ATCS", "atcs", "ATIF", and
"atif", for both f1688bd69ec4 and f9b7f3703ff9. Other than the few lines
mentioning ATIF from my previous email, there weren't any matches.

Since "device_class" didn't appear in the logs, we know that
`amdgpu_atif_handler` was not called for either version.

I also patched f9b7f3703ff9 to add the line

  DRM_DEBUG_DRIVER("Entered amdgpu_acpi_pcie_performance_request");

at the top (below the variable declarations) of
`amdgpu_acpi_pcie_performance_request`, and then tested again with all
drm debug messages enabled (0x1ff). That debug message didn't show up.

So, `amdgpu_acpi_pcie_performance_request` was not called either, at
least with f9b7f3703ff9. (I didn't try adding this patch to
f1688bd69ec4.)

Would anything else be helpful?

James

  reply	other threads:[~2022-01-31  8:43 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-17  2:12 [REGRESSION] Too-low frequency limit for AMD GPU PCI-passed-through to Windows VM James D. Turner
2022-01-17  8:09 ` Greg KH
2022-01-17  9:03 ` Thorsten Leemhuis
2022-01-18  3:14   ` James Turner
2022-01-21  2:13     ` James Turner
2022-01-21  6:22       ` Thorsten Leemhuis
2022-01-21  6:22         ` Thorsten Leemhuis
2022-01-21 16:45         ` Alex Deucher
2022-01-21 16:45           ` Alex Deucher
2022-01-22  0:51           ` James Turner
2022-01-22  0:51             ` James Turner
2022-01-22  5:52             ` Lazar, Lijo
2022-01-22  5:52               ` Lazar, Lijo
2022-01-22 21:11               ` James Turner
2022-01-22 21:11                 ` James Turner
2022-01-24 14:21                 ` Lazar, Lijo
2022-01-24 14:21                   ` Lazar, Lijo
2022-01-24 23:58                   ` James Turner
2022-01-24 23:58                     ` James Turner
2022-01-25 13:33                     ` Lazar, Lijo
2022-01-25 13:33                       ` Lazar, Lijo
2022-01-30  0:25                       ` Jim Turner [this message]
2022-01-30  0:25                         ` Jim Turner
2022-02-15 14:56                         ` Thorsten Leemhuis
2022-02-15 14:56                           ` Thorsten Leemhuis
2022-02-15 15:11                           ` Alex Deucher
2022-02-15 15:11                             ` Alex Deucher
2022-02-16  0:25                             ` James D. Turner
2022-02-16  0:25                               ` James D. Turner
2022-02-16 16:37                               ` Alex Deucher
2022-02-16 16:37                                 ` Alex Deucher
2022-03-06 15:48                                 ` Thorsten Leemhuis
2022-03-06 15:48                                   ` Thorsten Leemhuis
2022-03-07  2:12                                   ` James Turner
2022-03-07  2:12                                     ` James Turner
2022-03-13 18:33                                     ` James Turner
2022-03-13 18:33                                       ` James Turner
2022-03-17 12:54                                       ` Thorsten Leemhuis
2022-03-17 12:54                                         ` Thorsten Leemhuis
2022-03-18  5:43                                         ` Paul Menzel
2022-03-18  5:43                                           ` Paul Menzel
2022-03-18  7:01                                           ` Thorsten Leemhuis
2022-03-18  7:01                                             ` Thorsten Leemhuis
2022-03-18 14:46                                             ` Alex Williamson
2022-03-18 14:46                                               ` Alex Williamson
2022-03-18 15:06                                               ` Alex Deucher
2022-03-18 15:06                                                 ` Alex Deucher
2022-03-18 15:25                                                 ` Alex Williamson
2022-03-18 15:25                                                   ` Alex Williamson
2022-03-21  1:26                                                   ` James Turner
2022-03-21  1:26                                                     ` James Turner
2022-01-24 17:04                 ` Alex Deucher
2022-01-24 17:04                   ` Alex Deucher
2022-01-24 17:30                   ` Alex Williamson
2022-01-24 17:30                     ` Alex Williamson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pmo8r6ob.fsf@turner.link \
    --to=linuxkernel.foss@dmarc-none.turner.link \
    --cc=Alexander.Deucher@amd.com \
    --cc=Christian.Koenig@amd.com \
    --cc=Xinhui.Pan@amd.com \
    --cc=alex.williamson@redhat.com \
    --cc=alexdeucher@gmail.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kvm@vger.kernel.org \
    --cc=lijo.lazar@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=regressions@leemhuis.info \
    --cc=regressions@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.