From: Felipe Balbi <balbi@kernel.org>
To: Chunfeng Yun <chunfeng.yun@mediatek.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Pawel Laszczak <pawell@cadence.com>,
Al Cooper <alcooperx@gmail.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Yang Yingliang <yangyingliang@huawei.com>,
Rikard Falkeborn <rikard.falkeborn@gmail.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com,
linux-tegra@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
Eddie Hung <eddie.hung@mediatek.com>,
stable <stable@vger.kernel.org>
Subject: Re: [PATCH 2/6] usb: mtu3: fix the wrong HS mult value
Date: Thu, 12 Aug 2021 09:49:36 +0300 [thread overview]
Message-ID: <87pmujyx5f.fsf@kernel.org> (raw)
In-Reply-To: <1628739182-30089-2-git-send-email-chunfeng.yun@mediatek.com>
Chunfeng Yun <chunfeng.yun@mediatek.com> writes:
> Use usb_endpoint_maxp() and usb_endpoint_maxp_mult() seperately
> to get maxpacket and mult.
> Meanwhile fix the bug that should use @mult but not @burst
> to save mult value.
I really think you should split this into two patches. One which *only*
fixes the bug and another (patch 2) which *only* corrects the use
usb_endpoint_maxp()
--
balbi
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Felipe Balbi <balbi@kernel.org>
To: Chunfeng Yun <chunfeng.yun@mediatek.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Pawel Laszczak <pawell@cadence.com>,
Al Cooper <alcooperx@gmail.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Yang Yingliang <yangyingliang@huawei.com>,
Rikard Falkeborn <rikard.falkeborn@gmail.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com,
linux-tegra@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
Eddie Hung <eddie.hung@mediatek.com>,
stable <stable@vger.kernel.org>
Subject: Re: [PATCH 2/6] usb: mtu3: fix the wrong HS mult value
Date: Thu, 12 Aug 2021 09:49:36 +0300 [thread overview]
Message-ID: <87pmujyx5f.fsf@kernel.org> (raw)
In-Reply-To: <1628739182-30089-2-git-send-email-chunfeng.yun@mediatek.com>
Chunfeng Yun <chunfeng.yun@mediatek.com> writes:
> Use usb_endpoint_maxp() and usb_endpoint_maxp_mult() seperately
> to get maxpacket and mult.
> Meanwhile fix the bug that should use @mult but not @burst
> to save mult value.
I really think you should split this into two patches. One which *only*
fixes the bug and another (patch 2) which *only* corrects the use
usb_endpoint_maxp()
--
balbi
WARNING: multiple messages have this Message-ID (diff)
From: Felipe Balbi <balbi@kernel.org>
To: Chunfeng Yun <chunfeng.yun@mediatek.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Pawel Laszczak <pawell@cadence.com>,
Al Cooper <alcooperx@gmail.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Yang Yingliang <yangyingliang@huawei.com>,
Rikard Falkeborn <rikard.falkeborn@gmail.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com,
linux-tegra@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
Eddie Hung <eddie.hung@mediatek.com>,
stable <stable@vger.kernel.org>
Subject: Re: [PATCH 2/6] usb: mtu3: fix the wrong HS mult value
Date: Thu, 12 Aug 2021 09:49:36 +0300 [thread overview]
Message-ID: <87pmujyx5f.fsf@kernel.org> (raw)
In-Reply-To: <1628739182-30089-2-git-send-email-chunfeng.yun@mediatek.com>
Chunfeng Yun <chunfeng.yun@mediatek.com> writes:
> Use usb_endpoint_maxp() and usb_endpoint_maxp_mult() seperately
> to get maxpacket and mult.
> Meanwhile fix the bug that should use @mult but not @burst
> to save mult value.
I really think you should split this into two patches. One which *only*
fixes the bug and another (patch 2) which *only* corrects the use
usb_endpoint_maxp()
--
balbi
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-08-12 6:50 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-12 3:32 [PATCH 1/6] usb: mtu3: restore HS function when set SS/SSP Chunfeng Yun
2021-08-12 3:32 ` Chunfeng Yun
2021-08-12 3:32 ` Chunfeng Yun
2021-08-12 3:32 ` [PATCH 2/6] usb: mtu3: fix the wrong HS mult value Chunfeng Yun
2021-08-12 3:32 ` Chunfeng Yun
2021-08-12 3:32 ` Chunfeng Yun
2021-08-12 6:49 ` Felipe Balbi [this message]
2021-08-12 6:49 ` Felipe Balbi
2021-08-12 6:49 ` Felipe Balbi
2021-08-12 11:51 ` Chunfeng Yun (云春峰)
2021-08-12 3:32 ` [PATCH 3/6] usb: cdnsp: fix the wrong mult value for HS isoc or intr Chunfeng Yun
2021-08-12 3:32 ` Chunfeng Yun
2021-08-12 3:32 ` Chunfeng Yun
2021-08-12 6:51 ` Felipe Balbi
2021-08-12 6:51 ` Felipe Balbi
2021-08-12 6:51 ` Felipe Balbi
2021-08-12 11:53 ` Chunfeng Yun (云春峰)
2021-08-17 5:05 ` Pawel Laszczak
2021-08-17 5:05 ` Pawel Laszczak
2021-08-17 5:05 ` Pawel Laszczak
2021-08-17 7:10 ` Chunfeng Yun (云春峰)
2021-08-12 3:33 ` [PATCH 4/6] usb: gadget: tegra-xudc: " Chunfeng Yun
2021-08-12 3:33 ` Chunfeng Yun
2021-08-12 3:33 ` Chunfeng Yun
2021-08-12 6:51 ` Felipe Balbi
2021-08-12 6:51 ` Felipe Balbi
2021-08-12 6:51 ` Felipe Balbi
2021-08-12 11:54 ` Chunfeng Yun (云春峰)
2021-08-12 3:33 ` [PATCH 5/6] usb: gadget: bdc: remove unnecessary AND operation when get ep maxp Chunfeng Yun
2021-08-12 3:33 ` Chunfeng Yun
2021-08-12 3:33 ` Chunfeng Yun
2021-08-12 6:52 ` Felipe Balbi
2021-08-12 6:52 ` Felipe Balbi
2021-08-12 6:52 ` Felipe Balbi
2021-08-12 3:33 ` [PATCH 6/6] usb: gadget: " Chunfeng Yun
2021-08-12 3:33 ` Chunfeng Yun
2021-08-12 3:33 ` Chunfeng Yun
2021-08-12 6:52 ` Felipe Balbi
2021-08-12 6:52 ` Felipe Balbi
2021-08-12 6:52 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmujyx5f.fsf@kernel.org \
--to=balbi@kernel.org \
--cc=alcooperx@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=chunfeng.yun@mediatek.com \
--cc=eddie.hung@mediatek.com \
--cc=gregkh@linuxfoundation.org \
--cc=jonathanh@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=pawell@cadence.com \
--cc=rikard.falkeborn@gmail.com \
--cc=stable@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.