From: Michael Ellerman <mpe@ellerman.id.au>
To: Paolo Bonzini <pbonzini@redhat.com>,
Nicholas Piggin <npiggin@gmail.com>,
kvm-ppc@vger.kernel.org
Cc: Sean Christopherson <seanjc@google.com>,
Bharata B Rao <bharata@linux.ibm.com>,
linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org,
"Aneesh Kumar K . V" <aneesh.kumar@linux.ibm.com>
Subject: Re: [PATCH] KVM: PPC: Book3S HV: Fix conversion to gfn-based MMU notifier callbacks
Date: Thu, 06 May 2021 13:43:10 +0000 [thread overview]
Message-ID: <87pmy47zbl.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <9e0a256b-fb5a-4468-ed21-68d524d6ea56@redhat.com>
Paolo Bonzini <pbonzini@redhat.com> writes:
> On 05/05/21 14:15, Nicholas Piggin wrote:
>> Commit b1c5356e873c ("KVM: PPC: Convert to the gfn-based MMU notifier
>> callbacks") causes unmap_gfn_range and age_gfn callbacks to only work
>> on the first gfn in the range. It also makes the aging callbacks call
>> into both radix and hash aging functions for radix guests. Fix this.
>>
>> Add warnings for the single-gfn calls that have been converted to range
>> callbacks, in case they ever receieve ranges greater than 1.
>>
>> Fixes: b1c5356e873c ("KVM: PPC: Convert to the gfn-based MMU notifier callbacks")
>> Reported-by: Bharata B Rao <bharata@linux.ibm.com>
>> Tested-by: Bharata B Rao <bharata@linux.ibm.com>
>> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
>
> Sorry for the breakage. I queued this patch.
Thanks. Are you planning to send it to Linus before rc1?
If not I can pick it up as I already have some things in my next and am
intending to send a pull request anyway.
cheers
WARNING: multiple messages have this Message-ID (diff)
From: Michael Ellerman <mpe@ellerman.id.au>
To: Paolo Bonzini <pbonzini@redhat.com>,
Nicholas Piggin <npiggin@gmail.com>,
kvm-ppc@vger.kernel.org
Cc: Sean Christopherson <seanjc@google.com>,
linuxppc-dev@lists.ozlabs.org,
"Aneesh Kumar K . V" <aneesh.kumar@linux.ibm.com>,
kvm@vger.kernel.org, Bharata B Rao <bharata@linux.ibm.com>
Subject: Re: [PATCH] KVM: PPC: Book3S HV: Fix conversion to gfn-based MMU notifier callbacks
Date: Thu, 06 May 2021 23:43:10 +1000 [thread overview]
Message-ID: <87pmy47zbl.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <9e0a256b-fb5a-4468-ed21-68d524d6ea56@redhat.com>
Paolo Bonzini <pbonzini@redhat.com> writes:
> On 05/05/21 14:15, Nicholas Piggin wrote:
>> Commit b1c5356e873c ("KVM: PPC: Convert to the gfn-based MMU notifier
>> callbacks") causes unmap_gfn_range and age_gfn callbacks to only work
>> on the first gfn in the range. It also makes the aging callbacks call
>> into both radix and hash aging functions for radix guests. Fix this.
>>
>> Add warnings for the single-gfn calls that have been converted to range
>> callbacks, in case they ever receieve ranges greater than 1.
>>
>> Fixes: b1c5356e873c ("KVM: PPC: Convert to the gfn-based MMU notifier callbacks")
>> Reported-by: Bharata B Rao <bharata@linux.ibm.com>
>> Tested-by: Bharata B Rao <bharata@linux.ibm.com>
>> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
>
> Sorry for the breakage. I queued this patch.
Thanks. Are you planning to send it to Linus before rc1?
If not I can pick it up as I already have some things in my next and am
intending to send a pull request anyway.
cheers
WARNING: multiple messages have this Message-ID (diff)
From: Michael Ellerman <mpe@ellerman.id.au>
To: Paolo Bonzini <pbonzini@redhat.com>,
Nicholas Piggin <npiggin@gmail.com>,
kvm-ppc@vger.kernel.org
Cc: Sean Christopherson <seanjc@google.com>,
Bharata B Rao <bharata@linux.ibm.com>,
linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org,
"Aneesh Kumar K . V" <aneesh.kumar@linux.ibm.com>
Subject: Re: [PATCH] KVM: PPC: Book3S HV: Fix conversion to gfn-based MMU notifier callbacks
Date: Thu, 06 May 2021 23:43:10 +1000 [thread overview]
Message-ID: <87pmy47zbl.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <9e0a256b-fb5a-4468-ed21-68d524d6ea56@redhat.com>
Paolo Bonzini <pbonzini@redhat.com> writes:
> On 05/05/21 14:15, Nicholas Piggin wrote:
>> Commit b1c5356e873c ("KVM: PPC: Convert to the gfn-based MMU notifier
>> callbacks") causes unmap_gfn_range and age_gfn callbacks to only work
>> on the first gfn in the range. It also makes the aging callbacks call
>> into both radix and hash aging functions for radix guests. Fix this.
>>
>> Add warnings for the single-gfn calls that have been converted to range
>> callbacks, in case they ever receieve ranges greater than 1.
>>
>> Fixes: b1c5356e873c ("KVM: PPC: Convert to the gfn-based MMU notifier callbacks")
>> Reported-by: Bharata B Rao <bharata@linux.ibm.com>
>> Tested-by: Bharata B Rao <bharata@linux.ibm.com>
>> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
>
> Sorry for the breakage. I queued this patch.
Thanks. Are you planning to send it to Linus before rc1?
If not I can pick it up as I already have some things in my next and am
intending to send a pull request anyway.
cheers
next prev parent reply other threads:[~2021-05-06 13:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-05 12:15 [PATCH] KVM: PPC: Book3S HV: Fix conversion to gfn-based MMU notifier callbacks Nicholas Piggin
2021-05-05 12:15 ` Nicholas Piggin
2021-05-05 12:15 ` Nicholas Piggin
2021-05-05 15:52 ` Sean Christopherson
2021-05-05 15:52 ` Sean Christopherson
2021-05-05 15:52 ` Sean Christopherson
2021-05-06 4:57 ` Nicholas Piggin
2021-05-06 4:57 ` Nicholas Piggin
2021-05-06 4:57 ` Nicholas Piggin
2021-05-05 16:02 ` Paolo Bonzini
2021-05-05 16:02 ` Paolo Bonzini
2021-05-05 16:02 ` Paolo Bonzini
2021-05-06 13:43 ` Michael Ellerman [this message]
2021-05-06 13:43 ` Michael Ellerman
2021-05-06 13:43 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmy47zbl.fsf@mpe.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=aneesh.kumar@linux.ibm.com \
--cc=bharata@linux.ibm.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=npiggin@gmail.com \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.