All of lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: miguelborgesdefreitas@gmail.com
Cc: a.zummo@towertech.it, alexandre.belloni@bootlin.com,
	devicetree@vger.kernel.org, shawnguo@kernel.org,
	s.hauer@pengutronix.de, linux@armlinux.org.uk,
	linux-kernel@vger.kernel.org, robh+dt@kernel.org,
	linux-imx@nxp.com, kernel@pengutronix.de, festevam@gmail.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] ARM: dts: imx6qdl-cubox-i: enable DSM for the RTC
Date: Sun, 19 Jul 2020 18:00:32 +0300	[thread overview]
Message-ID: <87pn8reei7.fsf@tarshish> (raw)
In-Reply-To: <20200719145028.3370-3-miguelborgesdefreitas@gmail.com>

Hi Miguel,

On Sun, Jul 19 2020, miguelborgesdefreitas@gmail.com wrote:
> From: Miguel Borges de Freitas <miguelborgesdefreitas@gmail.com>
>
> Signed-off-by: Miguel Borges de Freitas <miguelborgesdefreitas@gmail.com>
> ---

The commit log should explain why you enable this for Cubox-i. The
information is in your cover letter. But the cover letter is not
preserved in the git commit log history.

Thanks,
baruch

>  arch/arm/boot/dts/imx6qdl-cubox-i.dtsi | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-cubox-i.dtsi b/arch/arm/boot/dts/imx6qdl-cubox-i.dtsi
> index e3be453..a226c4e 100644
> --- a/arch/arm/boot/dts/imx6qdl-cubox-i.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-cubox-i.dtsi
> @@ -144,6 +144,7 @@
>  	rtc@68 {
>  		compatible = "nxp,pcf8523";
>  		reg = <0x68>;
> +		pm-enable-dsm;
>  	};
>  };


-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Baruch Siach <baruch@tkos.co.il>
To: miguelborgesdefreitas@gmail.com
Cc: a.zummo@towertech.it, devicetree@vger.kernel.org,
	alexandre.belloni@bootlin.com, festevam@gmail.com,
	s.hauer@pengutronix.de, linux@armlinux.org.uk,
	linux-kernel@vger.kernel.org, robh+dt@kernel.org,
	linux-imx@nxp.com, kernel@pengutronix.de, shawnguo@kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] ARM: dts: imx6qdl-cubox-i: enable DSM for the RTC
Date: Sun, 19 Jul 2020 18:00:32 +0300	[thread overview]
Message-ID: <87pn8reei7.fsf@tarshish> (raw)
In-Reply-To: <20200719145028.3370-3-miguelborgesdefreitas@gmail.com>

Hi Miguel,

On Sun, Jul 19 2020, miguelborgesdefreitas@gmail.com wrote:
> From: Miguel Borges de Freitas <miguelborgesdefreitas@gmail.com>
>
> Signed-off-by: Miguel Borges de Freitas <miguelborgesdefreitas@gmail.com>
> ---

The commit log should explain why you enable this for Cubox-i. The
information is in your cover letter. But the cover letter is not
preserved in the git commit log history.

Thanks,
baruch

>  arch/arm/boot/dts/imx6qdl-cubox-i.dtsi | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-cubox-i.dtsi b/arch/arm/boot/dts/imx6qdl-cubox-i.dtsi
> index e3be453..a226c4e 100644
> --- a/arch/arm/boot/dts/imx6qdl-cubox-i.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-cubox-i.dtsi
> @@ -144,6 +144,7 @@
>  	rtc@68 {
>  		compatible = "nxp,pcf8523";
>  		reg = <0x68>;
> +		pm-enable-dsm;
>  	};
>  };


-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

  reply	other threads:[~2020-07-19 15:02 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-19 14:50 [PATCH 0/2] rtc: pcf8523: Make DSM for battery switch-over configurable from DT and enable it for the cubox-i miguelborgesdefreitas
2020-07-19 14:50 ` miguelborgesdefreitas
2020-07-19 14:50 ` [PATCH 1/2] rtc: pcf8523: Make DSM for battery switch-over configurable from DT miguelborgesdefreitas
2020-07-19 14:50   ` miguelborgesdefreitas
2020-07-19 14:50 ` [PATCH 2/2] ARM: dts: imx6qdl-cubox-i: enable DSM for the RTC miguelborgesdefreitas
2020-07-19 14:50   ` miguelborgesdefreitas
2020-07-19 15:00   ` Baruch Siach [this message]
2020-07-19 15:00     ` Baruch Siach
2020-07-20 11:23   ` [PATCH v2 0/3] rtc: pcf8523: imx6qdl-cubox-i: Make DSM for battery switch-over configurable from DT and enable it for the cubox-i miguelborgesdefreitas
2020-07-20 11:23     ` miguelborgesdefreitas
2020-07-20 11:23     ` [PATCH v2 1/3] dt-bindings: rtc: pcf8523: add DSM pm option for battery switch-over miguelborgesdefreitas
2020-07-20 11:23       ` miguelborgesdefreitas
2020-07-23 17:49       ` Rob Herring
2020-07-23 17:49         ` Rob Herring
2020-07-23 19:57         ` Alexandre Belloni
2020-07-23 19:57           ` Alexandre Belloni
2020-07-23 20:41           ` Miguel Borges de Freitas
2020-07-23 20:41             ` Miguel Borges de Freitas
2020-07-27  9:19             ` Jon Nettleton
2020-07-27  9:19               ` Jon Nettleton
2020-07-27  9:45           ` Russell King - ARM Linux admin
2020-07-27  9:45             ` Russell King - ARM Linux admin
2020-07-27 13:33             ` Jon Nettleton
2020-07-27 13:33               ` Jon Nettleton
2020-07-27 14:17               ` Russell King - ARM Linux admin
2020-07-27 14:17                 ` Russell King - ARM Linux admin
2020-07-27 14:52                 ` Jon Nettleton
2020-07-27 14:52                   ` Jon Nettleton
2020-07-27 14:49             ` Alexandre Belloni
2020-07-27 14:49               ` Alexandre Belloni
2020-07-27 15:24               ` Russell King - ARM Linux admin
2020-07-27 15:24                 ` Russell King - ARM Linux admin
2020-07-27 15:41                 ` Alexandre Belloni
2020-07-27 15:41                   ` Alexandre Belloni
2020-07-27 15:43                   ` Russell King - ARM Linux admin
2020-07-27 15:43                     ` Russell King - ARM Linux admin
2020-07-27 15:55                     ` Jon Nettleton
2020-07-27 15:55                       ` Jon Nettleton
2020-07-27 16:16                       ` Alexandre Belloni
2020-07-27 16:16                         ` Alexandre Belloni
2020-07-27 17:04                         ` Jon Nettleton
2020-07-27 17:04                           ` Jon Nettleton
2020-07-27 17:30                         ` Russell King - ARM Linux admin
2020-07-27 17:30                           ` Russell King - ARM Linux admin
2020-07-27 21:13                           ` Miguel Borges de Freitas
2020-07-27 21:13                             ` Miguel Borges de Freitas
2020-08-25 20:08                             ` Alexandre Belloni
2020-08-25 20:08                               ` Alexandre Belloni
2020-07-20 11:24     ` [PATCH v2 2/3] rtc: pcf8523: Make DSM for battery switch-over configurable from DT miguelborgesdefreitas
2020-07-20 11:24       ` miguelborgesdefreitas
2020-07-20 11:24     ` [PATCH v2 3/3] ARM: dts: imx6qdl-cubox-i: enable DSM for the RTC miguelborgesdefreitas
2020-07-20 11:24       ` miguelborgesdefreitas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pn8reei7.fsf@tarshish \
    --to=baruch@tkos.co.il \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@bootlin.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=miguelborgesdefreitas@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.