* [PATCH] ARM: dts: dlink-dns327l: fix reg-init PHY
@ 2020-06-26 18:39 ` Daniel González Cabanelas
0 siblings, 0 replies; 6+ messages in thread
From: Daniel González Cabanelas @ 2020-06-26 18:39 UTC (permalink / raw)
To: jason
Cc: andrew, gregory.clement, sebastian.hesselbarth, robh+dt,
linux-arm-kernel, devicetree
The marvell PHY reg-init registers for the D-Link DNS-327L are wrong.
Currently the first field is used to set the page 2, but this is
pointless. The usage is not correct, and we are setting the wrong
registers.
Fix it.
Signed-off-by: Daniel González Cabanelas <dgcbueu@gmail.com>
---
arch/arm/boot/dts/armada-370-dlink-dns327l.dts | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/armada-370-dlink-dns327l.dts b/arch/arm/boot/dts/armada-370-dlink-dns327l.dts
index baa459dd5..2008c6eaa 100644
--- a/arch/arm/boot/dts/armada-370-dlink-dns327l.dts
+++ b/arch/arm/boot/dts/armada-370-dlink-dns327l.dts
@@ -247,9 +247,8 @@ &uart1 {
&mdio {
phy0: ethernet-phy@0 { /* Marvell 88E1318 */
reg = <0>;
- marvell,reg-init = <0x0 0x16 0x0 0x0002>,
- <0x0 0x19 0x0 0x0077>,
- <0x0 0x18 0x0 0x5747>;
+ marvell,reg-init = <0x2 0x19 0x0 0x0077>,
+ <0x2 0x18 0x0 0x5747>;
};
};
--
2.27.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] ARM: dts: dlink-dns327l: fix reg-init PHY
2020-06-26 18:39 ` Daniel González Cabanelas
@ 2020-06-26 20:33 ` Andrew Lunn
-1 siblings, 0 replies; 6+ messages in thread
From: Andrew Lunn @ 2020-06-26 20:33 UTC (permalink / raw)
To: Daniel González Cabanelas
Cc: devicetree, jason, gregory.clement, robh+dt, linux-arm-kernel,
sebastian.hesselbarth
On Fri, Jun 26, 2020 at 08:39:05PM +0200, Daniel González Cabanelas wrote:
> The marvell PHY reg-init registers for the D-Link DNS-327L are wrong.
> Currently the first field is used to set the page 2, but this is
> pointless. The usage is not correct, and we are setting the wrong
> registers.
>
> Fix it.
>
> Signed-off-by: Daniel González Cabanelas <dgcbueu@gmail.com>
> ---
> arch/arm/boot/dts/armada-370-dlink-dns327l.dts | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/armada-370-dlink-dns327l.dts b/arch/arm/boot/dts/armada-370-dlink-dns327l.dts
> index baa459dd5..2008c6eaa 100644
> --- a/arch/arm/boot/dts/armada-370-dlink-dns327l.dts
> +++ b/arch/arm/boot/dts/armada-370-dlink-dns327l.dts
> @@ -247,9 +247,8 @@ &uart1 {
> &mdio {
> phy0: ethernet-phy@0 { /* Marvell 88E1318 */
> reg = <0>;
> - marvell,reg-init = <0x0 0x16 0x0 0x0002>,
Interesting. That is writing to the page register, to change to page
2! So this might of worked with an earlier implementation. But not
now.
> - <0x0 0x19 0x0 0x0077>,
> - <0x0 0x18 0x0 0x5747>;
> + marvell,reg-init = <0x2 0x19 0x0 0x0077>,
> + <0x2 0x18 0x0 0x5747>;
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ARM: dts: dlink-dns327l: fix reg-init PHY
@ 2020-06-26 20:33 ` Andrew Lunn
0 siblings, 0 replies; 6+ messages in thread
From: Andrew Lunn @ 2020-06-26 20:33 UTC (permalink / raw)
To: Daniel González Cabanelas
Cc: jason, gregory.clement, sebastian.hesselbarth, robh+dt,
linux-arm-kernel, devicetree
On Fri, Jun 26, 2020 at 08:39:05PM +0200, Daniel González Cabanelas wrote:
> The marvell PHY reg-init registers for the D-Link DNS-327L are wrong.
> Currently the first field is used to set the page 2, but this is
> pointless. The usage is not correct, and we are setting the wrong
> registers.
>
> Fix it.
>
> Signed-off-by: Daniel González Cabanelas <dgcbueu@gmail.com>
> ---
> arch/arm/boot/dts/armada-370-dlink-dns327l.dts | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/armada-370-dlink-dns327l.dts b/arch/arm/boot/dts/armada-370-dlink-dns327l.dts
> index baa459dd5..2008c6eaa 100644
> --- a/arch/arm/boot/dts/armada-370-dlink-dns327l.dts
> +++ b/arch/arm/boot/dts/armada-370-dlink-dns327l.dts
> @@ -247,9 +247,8 @@ &uart1 {
> &mdio {
> phy0: ethernet-phy@0 { /* Marvell 88E1318 */
> reg = <0>;
> - marvell,reg-init = <0x0 0x16 0x0 0x0002>,
Interesting. That is writing to the page register, to change to page
2! So this might of worked with an earlier implementation. But not
now.
> - <0x0 0x19 0x0 0x0077>,
> - <0x0 0x18 0x0 0x5747>;
> + marvell,reg-init = <0x2 0x19 0x0 0x0077>,
> + <0x2 0x18 0x0 0x5747>;
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: dlink-dns327l: fix reg-init PHY
2020-06-26 18:39 ` Daniel González Cabanelas
@ 2020-07-18 20:57 ` Gregory CLEMENT
-1 siblings, 0 replies; 6+ messages in thread
From: Gregory CLEMENT @ 2020-07-18 20:57 UTC (permalink / raw)
To: Daniel González Cabanelas, jason
Cc: andrew, devicetree, robh+dt, linux-arm-kernel,
sebastian.hesselbarth
Daniel González Cabanelas <dgcbueu@gmail.com> writes:
> The marvell PHY reg-init registers for the D-Link DNS-327L are wrong.
> Currently the first field is used to set the page 2, but this is
> pointless. The usage is not correct, and we are setting the wrong
> registers.
>
> Fix it.
>
> Signed-off-by: Daniel González Cabanelas <dgcbueu@gmail.com>
Applied on mvebu/dt
Thanks,
Gregory
> ---
> arch/arm/boot/dts/armada-370-dlink-dns327l.dts | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/armada-370-dlink-dns327l.dts b/arch/arm/boot/dts/armada-370-dlink-dns327l.dts
> index baa459dd5..2008c6eaa 100644
> --- a/arch/arm/boot/dts/armada-370-dlink-dns327l.dts
> +++ b/arch/arm/boot/dts/armada-370-dlink-dns327l.dts
> @@ -247,9 +247,8 @@ &uart1 {
> &mdio {
> phy0: ethernet-phy@0 { /* Marvell 88E1318 */
> reg = <0>;
> - marvell,reg-init = <0x0 0x16 0x0 0x0002>,
> - <0x0 0x19 0x0 0x0077>,
> - <0x0 0x18 0x0 0x5747>;
> + marvell,reg-init = <0x2 0x19 0x0 0x0077>,
> + <0x2 0x18 0x0 0x5747>;
> };
> };
>
> --
> 2.27.0
>
>
>
>
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ARM: dts: dlink-dns327l: fix reg-init PHY
@ 2020-07-18 20:57 ` Gregory CLEMENT
0 siblings, 0 replies; 6+ messages in thread
From: Gregory CLEMENT @ 2020-07-18 20:57 UTC (permalink / raw)
To: Daniel González Cabanelas, jason
Cc: andrew, sebastian.hesselbarth, robh+dt, linux-arm-kernel,
devicetree
Daniel González Cabanelas <dgcbueu@gmail.com> writes:
> The marvell PHY reg-init registers for the D-Link DNS-327L are wrong.
> Currently the first field is used to set the page 2, but this is
> pointless. The usage is not correct, and we are setting the wrong
> registers.
>
> Fix it.
>
> Signed-off-by: Daniel González Cabanelas <dgcbueu@gmail.com>
Applied on mvebu/dt
Thanks,
Gregory
> ---
> arch/arm/boot/dts/armada-370-dlink-dns327l.dts | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/armada-370-dlink-dns327l.dts b/arch/arm/boot/dts/armada-370-dlink-dns327l.dts
> index baa459dd5..2008c6eaa 100644
> --- a/arch/arm/boot/dts/armada-370-dlink-dns327l.dts
> +++ b/arch/arm/boot/dts/armada-370-dlink-dns327l.dts
> @@ -247,9 +247,8 @@ &uart1 {
> &mdio {
> phy0: ethernet-phy@0 { /* Marvell 88E1318 */
> reg = <0>;
> - marvell,reg-init = <0x0 0x16 0x0 0x0002>,
> - <0x0 0x19 0x0 0x0077>,
> - <0x0 0x18 0x0 0x5747>;
> + marvell,reg-init = <0x2 0x19 0x0 0x0077>,
> + <0x2 0x18 0x0 0x5747>;
> };
> };
>
> --
> 2.27.0
>
>
>
>
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
^ permalink raw reply [flat|nested] 6+ messages in thread