From: Kalle Valo <kvalo@codeaurora.org>
To: John Crispin <john@phrozen.org>
Cc: linux-wireless@vger.kernel.org, ath11k@lists.infradead.org
Subject: Re: [RESEND 1/2] ath11k: add WMI calls to manually add/del/pause/resume
Date: Thu, 16 Jul 2020 10:50:41 +0300 [thread overview]
Message-ID: <87pn8vx5im.fsf@codeaurora.org> (raw)
In-Reply-To: <20200624080321.2271943-1-john@phrozen.org> (John Crispin's message of "Wed, 24 Jun 2020 10:03:20 +0200")
+ linux-wireless
John Crispin <john@phrozen.org> writes:
> These calls are used for debugging and will be required for WFA
> certification tests.
>
> Signed-off-by: John Crispin <john@phrozen.org>
[...]
> +static void ath11k_wmi_twt_add_dialog_event(struct ath11k_base *ab, struct sk_buff *skb)
> +{
> + static const char * const status[] = {
> + "OK", "TWT_NOT_ENABLED", "USED_DIALOG_ID", "INVALID_PARAM",
> + "NOT_READY", "NO_RESOURCE", "NO_ACK", "NO_RESPONSE",
> + "DENIED", "UNKNOWN_ERROR"
> + };
> + const void **tb;
> + const struct wmi_twt_add_dialog_event *ev;
> + int ret;
> +
> + tb = ath11k_wmi_tlv_parse_alloc(ab, skb->data, skb->len, GFP_ATOMIC);
> + if (IS_ERR(tb)) {
> + ret = PTR_ERR(tb);
> + ath11k_warn(ab, "failed to parse tlv: %d\n", ret);
> + return;
> + }
> +
> + ev = tb[WMI_TAG_TWT_ADD_DIALOG_COMPLETE_EVENT];
> + if (!ev) {
> + ath11k_warn(ab, "failed to fetch twt add dialog ev");
> + goto exit;
> + }
> +
> + ath11k_info(ab, "TWT Add Dialog Event - Status: %s, DialogId: %d, VdevId: %d\n",
> + status[ev->status], ev->vdev_id, ev->dialog_id);
Shouldn't this be a debug message? The info level should be used very
sparingly.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: John Crispin <john@phrozen.org>
Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [RESEND 1/2] ath11k: add WMI calls to manually add/del/pause/resume
Date: Thu, 16 Jul 2020 10:50:41 +0300 [thread overview]
Message-ID: <87pn8vx5im.fsf@codeaurora.org> (raw)
In-Reply-To: <20200624080321.2271943-1-john@phrozen.org> (John Crispin's message of "Wed, 24 Jun 2020 10:03:20 +0200")
+ linux-wireless
John Crispin <john@phrozen.org> writes:
> These calls are used for debugging and will be required for WFA
> certification tests.
>
> Signed-off-by: John Crispin <john@phrozen.org>
[...]
> +static void ath11k_wmi_twt_add_dialog_event(struct ath11k_base *ab, struct sk_buff *skb)
> +{
> + static const char * const status[] = {
> + "OK", "TWT_NOT_ENABLED", "USED_DIALOG_ID", "INVALID_PARAM",
> + "NOT_READY", "NO_RESOURCE", "NO_ACK", "NO_RESPONSE",
> + "DENIED", "UNKNOWN_ERROR"
> + };
> + const void **tb;
> + const struct wmi_twt_add_dialog_event *ev;
> + int ret;
> +
> + tb = ath11k_wmi_tlv_parse_alloc(ab, skb->data, skb->len, GFP_ATOMIC);
> + if (IS_ERR(tb)) {
> + ret = PTR_ERR(tb);
> + ath11k_warn(ab, "failed to parse tlv: %d\n", ret);
> + return;
> + }
> +
> + ev = tb[WMI_TAG_TWT_ADD_DIALOG_COMPLETE_EVENT];
> + if (!ev) {
> + ath11k_warn(ab, "failed to fetch twt add dialog ev");
> + goto exit;
> + }
> +
> + ath11k_info(ab, "TWT Add Dialog Event - Status: %s, DialogId: %d, VdevId: %d\n",
> + status[ev->status], ev->vdev_id, ev->dialog_id);
Shouldn't this be a debug message? The info level should be used very
sparingly.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2020-07-16 7:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-24 8:03 [RESEND 1/2] ath11k: add WMI calls to manually add/del/pause/resume John Crispin
2020-06-24 8:03 ` [RESEND 2/2] ath11k: add debugfs for TWT debug calls John Crispin
2020-07-16 7:47 ` Kalle Valo
2020-07-16 7:47 ` Kalle Valo
2020-07-16 7:50 ` Kalle Valo [this message]
2020-07-16 7:50 ` [RESEND 1/2] ath11k: add WMI calls to manually add/del/pause/resume Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pn8vx5im.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ath11k@lists.infradead.org \
--cc=john@phrozen.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.