From: Andi Kleen <ak@linux.intel.com>
To: lqqq341 <liuqi115@hisilicon.com>
Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
jolsa@redhat.com, namhyung@kernel.org,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
linuxarm@huawei.com, john.garry@huawei.com,
zhangshaokun@hisilicon.com, huangdaode@hisilicon.com,
linyunsheng@huawei.com
Subject: Re: [PATCH] Perf stat: Fix the ratio comments of miss-events
Date: Sat, 16 Nov 2019 06:45:19 -0800 [thread overview]
Message-ID: <87pnhrg9s0.fsf@linux.intel.com> (raw)
In-Reply-To: <1573890521-56450-1-git-send-email-liuqi115@hisilicon.com> (lqqq's message of "Sat, 16 Nov 2019 15:48:41 +0800")
lqqq341 <liuqi115@hisilicon.com> writes:
> From: Qi Liu <liuqi115@hisilicon.com>
>
> Perf stat displays miss ratio of L1-dcache, L1-icache, dTLB cache,
> iTLB cache and LL-cache. Take L1-dcache for example, its miss ratio
> is caculated as "L1-dcache-load-misses/L1-dcache-loads". So "of all
> L1-dcache hits" is unsuitable to describe it, and "of all L1-dcache
> accesses" seems better. The comments of L1-icache, dTLB cache, iTLB
> cache and LL-cache are fixed in the same way.
Reviewed-by: Andi Kleen <ak@linux.intel.com>
-Andi
WARNING: multiple messages have this Message-ID (diff)
From: Andi Kleen <ak@linux.intel.com>
To: lqqq341 <liuqi115@hisilicon.com>
Cc: <peterz@infradead.org>, <mingo@redhat.com>, <acme@kernel.org>,
<mark.rutland@arm.com>, <alexander.shishkin@linux.intel.com>,
<jolsa@redhat.com>, <namhyung@kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-perf-users@vger.kernel.org>, <linuxarm@huawei.com>,
<john.garry@huawei.com>, <zhangshaokun@hisilicon.com>,
<huangdaode@hisilicon.com>, <linyunsheng@huawei.com>
Subject: Re: [PATCH] Perf stat: Fix the ratio comments of miss-events
Date: Sat, 16 Nov 2019 06:45:19 -0800 [thread overview]
Message-ID: <87pnhrg9s0.fsf@linux.intel.com> (raw)
In-Reply-To: <1573890521-56450-1-git-send-email-liuqi115@hisilicon.com> (lqqq's message of "Sat, 16 Nov 2019 15:48:41 +0800")
lqqq341 <liuqi115@hisilicon.com> writes:
> From: Qi Liu <liuqi115@hisilicon.com>
>
> Perf stat displays miss ratio of L1-dcache, L1-icache, dTLB cache,
> iTLB cache and LL-cache. Take L1-dcache for example, its miss ratio
> is caculated as "L1-dcache-load-misses/L1-dcache-loads". So "of all
> L1-dcache hits" is unsuitable to describe it, and "of all L1-dcache
> accesses" seems better. The comments of L1-icache, dTLB cache, iTLB
> cache and LL-cache are fixed in the same way.
Reviewed-by: Andi Kleen <ak@linux.intel.com>
-Andi
next prev parent reply other threads:[~2019-11-16 14:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-16 7:48 [PATCH] Perf stat: Fix the ratio comments of miss-events lqqq341
2019-11-16 7:48 ` lqqq341
2019-11-16 14:45 ` Andi Kleen [this message]
2019-11-16 14:45 ` Andi Kleen
2019-11-19 15:59 ` Arnaldo Carvalho de Melo
2019-12-12 6:37 ` Qi Liu
2019-12-12 6:37 ` Qi Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pnhrg9s0.fsf@linux.intel.com \
--to=ak@linux.intel.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=huangdaode@hisilicon.com \
--cc=john.garry@huawei.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=linyunsheng@huawei.com \
--cc=liuqi115@hisilicon.com \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=zhangshaokun@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.