From: Kalle Valo <kvalo@codeaurora.org>
To: Dundi Raviteja <dundi@codeaurora.org>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH v2] ath10k: Enable support for beacon interval per VAP
Date: Wed, 25 Sep 2019 08:13:47 +0300 [thread overview]
Message-ID: <87pnjp3qlw.fsf@codeaurora.org> (raw)
In-Reply-To: <1550579046-22649-1-git-send-email-dundi@codeaurora.org> (Dundi Raviteja's message of "Tue, 19 Feb 2019 17:54:06 +0530")
Dundi Raviteja <dundi@codeaurora.org> writes:
> Enable support to configure different beacon interval per VAP.
>
> To support this feature, map different beacon interval service bit
> to wmi tlv service.
>
> Tested HW: WCN3990
> Tested FW: WLAN.HL.2.0-01188-QCAHLSWMTPLZ-1
>
> Signed-off-by: Dundi Raviteja <dundi@codeaurora.org>
[...]
> --- a/drivers/net/wireless/ath/ath10k/mac.c
> +++ b/drivers/net/wireless/ath/ath10k/mac.c
> @@ -8232,6 +8232,30 @@ void ath10k_mac_destroy(struct ath10k *ar)
> },
> };
>
> +static struct
> +ieee80211_iface_combination ath10k_tlv_qcs_bcn_int_if_comb[] = {
> + {
> + .limits = ath10k_tlv_if_limit,
> + .num_different_channels = 1,
> + .max_interfaces = 4,
> + .beacon_int_infra_match = true,
> + .beacon_int_min_gcd = 1,
> + .n_limits = ARRAY_SIZE(ath10k_tlv_if_limit),
> + },
> + {
> + .limits = ath10k_tlv_qcs_if_limit,
> + .num_different_channels = 2,
> + .max_interfaces = 4,
> + .n_limits = ARRAY_SIZE(ath10k_tlv_qcs_if_limit),
> + },
> + {
> + .limits = ath10k_tlv_if_limit_ibss,
> + .num_different_channels = 1,
> + .max_interfaces = 2,
> + .n_limits = ARRAY_SIZE(ath10k_tlv_if_limit_ibss),
> + },
> +};
> +
> static const struct ieee80211_iface_limit ath10k_10_4_if_limits[] = {
> {
> .max = 1,
> @@ -8642,6 +8666,15 @@ int ath10k_mac_register(struct ath10k *ar)
> ath10k_tlv_qcs_if_comb;
> ar->hw->wiphy->n_iface_combinations =
> ARRAY_SIZE(ath10k_tlv_qcs_if_comb);
> +
> + if (test_bit
> + (WMI_SERVICE_VDEV_DIFFERENT_BEACON_INTERVAL_SUPPORT,
> + ar->wmi.svc_map)) {
> + ar->hw->wiphy->iface_combinations =
> + ath10k_tlv_qcs_bcn_int_if_comb;
> + ar->hw->wiphy->n_iface_combinations =
> + ARRAY_SIZE(ath10k_tlv_qcs_bcn_int_if_comb);
> + }
I don't like using WMI service flags to advertise different interface
combinations, it makes ath10k code convoluted. A much better approach is
to use WMI_SERVICE_IFACE_COMBINATION_SUPPORT:
ath10k:New interface to get interface combinations from FW
https://patchwork.kernel.org/patch/11027361/
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Dundi Raviteja <dundi@codeaurora.org>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2] ath10k: Enable support for beacon interval per VAP
Date: Wed, 25 Sep 2019 08:13:47 +0300 [thread overview]
Message-ID: <87pnjp3qlw.fsf@codeaurora.org> (raw)
In-Reply-To: <1550579046-22649-1-git-send-email-dundi@codeaurora.org> (Dundi Raviteja's message of "Tue, 19 Feb 2019 17:54:06 +0530")
Dundi Raviteja <dundi@codeaurora.org> writes:
> Enable support to configure different beacon interval per VAP.
>
> To support this feature, map different beacon interval service bit
> to wmi tlv service.
>
> Tested HW: WCN3990
> Tested FW: WLAN.HL.2.0-01188-QCAHLSWMTPLZ-1
>
> Signed-off-by: Dundi Raviteja <dundi@codeaurora.org>
[...]
> --- a/drivers/net/wireless/ath/ath10k/mac.c
> +++ b/drivers/net/wireless/ath/ath10k/mac.c
> @@ -8232,6 +8232,30 @@ void ath10k_mac_destroy(struct ath10k *ar)
> },
> };
>
> +static struct
> +ieee80211_iface_combination ath10k_tlv_qcs_bcn_int_if_comb[] = {
> + {
> + .limits = ath10k_tlv_if_limit,
> + .num_different_channels = 1,
> + .max_interfaces = 4,
> + .beacon_int_infra_match = true,
> + .beacon_int_min_gcd = 1,
> + .n_limits = ARRAY_SIZE(ath10k_tlv_if_limit),
> + },
> + {
> + .limits = ath10k_tlv_qcs_if_limit,
> + .num_different_channels = 2,
> + .max_interfaces = 4,
> + .n_limits = ARRAY_SIZE(ath10k_tlv_qcs_if_limit),
> + },
> + {
> + .limits = ath10k_tlv_if_limit_ibss,
> + .num_different_channels = 1,
> + .max_interfaces = 2,
> + .n_limits = ARRAY_SIZE(ath10k_tlv_if_limit_ibss),
> + },
> +};
> +
> static const struct ieee80211_iface_limit ath10k_10_4_if_limits[] = {
> {
> .max = 1,
> @@ -8642,6 +8666,15 @@ int ath10k_mac_register(struct ath10k *ar)
> ath10k_tlv_qcs_if_comb;
> ar->hw->wiphy->n_iface_combinations =
> ARRAY_SIZE(ath10k_tlv_qcs_if_comb);
> +
> + if (test_bit
> + (WMI_SERVICE_VDEV_DIFFERENT_BEACON_INTERVAL_SUPPORT,
> + ar->wmi.svc_map)) {
> + ar->hw->wiphy->iface_combinations =
> + ath10k_tlv_qcs_bcn_int_if_comb;
> + ar->hw->wiphy->n_iface_combinations =
> + ARRAY_SIZE(ath10k_tlv_qcs_bcn_int_if_comb);
> + }
I don't like using WMI service flags to advertise different interface
combinations, it makes ath10k code convoluted. A much better approach is
to use WMI_SERVICE_IFACE_COMBINATION_SUPPORT:
ath10k:New interface to get interface combinations from FW
https://patchwork.kernel.org/patch/11027361/
--
Kalle Valo
next prev parent reply other threads:[~2019-09-25 5:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-19 12:24 [PATCH v2] ath10k: Enable support for beacon interval per VAP Dundi Raviteja
2019-02-19 12:24 ` Dundi Raviteja
2019-09-25 5:13 ` Kalle Valo [this message]
2019-09-25 5:13 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pnjp3qlw.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=dundi@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.