From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: Russell King <rmk+kernel@armlinux.org.uk>
Cc: Mark Rutland <mark.rutland@arm.com>, Andrew Lunn <andrew@lunn.ch>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Jason Cooper <jason@lakedaemon.net>,
devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH] arm64: dts: marvell: add missing #interrupt-cells property
Date: Tue, 18 Jun 2019 10:20:39 +0200 [thread overview]
Message-ID: <87pnnbnw2w.fsf@FE-laptop> (raw)
In-Reply-To: <20190618081706.GD23549@piout.net>
Hi Russell,
> On 17/06/2019 15:49:55+0100, Russell King wrote:
>> The GPIO interrupt controllers are missing their required
>> #interrupt-cells property, which prevents GPIO interrupts being
>> specified in DT.
>>
>> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
> Reviewed-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Applied on mvebu/dt64
Thanks,
Gregory
>
>> ---
>> arch/arm64/boot/dts/marvell/armada-cp110.dtsi | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/marvell/armada-cp110.dtsi b/arch/arm64/boot/dts/marvell/armada-cp110.dtsi
>> index 4d6e4a097f72..f71afb1de18f 100644
>> --- a/arch/arm64/boot/dts/marvell/armada-cp110.dtsi
>> +++ b/arch/arm64/boot/dts/marvell/armada-cp110.dtsi
>> @@ -238,6 +238,7 @@
>> <85 IRQ_TYPE_LEVEL_HIGH>,
>> <84 IRQ_TYPE_LEVEL_HIGH>,
>> <83 IRQ_TYPE_LEVEL_HIGH>;
>> + #interrupt-cells = <2>;
>> status = "disabled";
>> };
>>
>> @@ -253,6 +254,7 @@
>> <81 IRQ_TYPE_LEVEL_HIGH>,
>> <80 IRQ_TYPE_LEVEL_HIGH>,
>> <79 IRQ_TYPE_LEVEL_HIGH>;
>> + #interrupt-cells = <2>;
>> status = "disabled";
>> };
>> };
>> --
>> 2.7.4
>>
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
> --
> Alexandre Belloni, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: Russell King <rmk+kernel@armlinux.org.uk>
Cc: Mark Rutland <mark.rutland@arm.com>, Andrew Lunn <andrew@lunn.ch>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Jason Cooper <jason@lakedaemon.net>,
devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH] arm64: dts: marvell: add missing #interrupt-cells property
Date: Tue, 18 Jun 2019 10:20:39 +0200 [thread overview]
Message-ID: <87pnnbnw2w.fsf@FE-laptop> (raw)
In-Reply-To: <20190618081706.GD23549@piout.net>
Hi Russell,
> On 17/06/2019 15:49:55+0100, Russell King wrote:
>> The GPIO interrupt controllers are missing their required
>> #interrupt-cells property, which prevents GPIO interrupts being
>> specified in DT.
>>
>> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
> Reviewed-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Applied on mvebu/dt64
Thanks,
Gregory
>
>> ---
>> arch/arm64/boot/dts/marvell/armada-cp110.dtsi | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/marvell/armada-cp110.dtsi b/arch/arm64/boot/dts/marvell/armada-cp110.dtsi
>> index 4d6e4a097f72..f71afb1de18f 100644
>> --- a/arch/arm64/boot/dts/marvell/armada-cp110.dtsi
>> +++ b/arch/arm64/boot/dts/marvell/armada-cp110.dtsi
>> @@ -238,6 +238,7 @@
>> <85 IRQ_TYPE_LEVEL_HIGH>,
>> <84 IRQ_TYPE_LEVEL_HIGH>,
>> <83 IRQ_TYPE_LEVEL_HIGH>;
>> + #interrupt-cells = <2>;
>> status = "disabled";
>> };
>>
>> @@ -253,6 +254,7 @@
>> <81 IRQ_TYPE_LEVEL_HIGH>,
>> <80 IRQ_TYPE_LEVEL_HIGH>,
>> <79 IRQ_TYPE_LEVEL_HIGH>;
>> + #interrupt-cells = <2>;
>> status = "disabled";
>> };
>> };
>> --
>> 2.7.4
>>
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
> --
> Alexandre Belloni, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
next prev parent reply other threads:[~2019-06-18 8:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-17 14:49 [PATCH] arm64: dts: marvell: add missing #interrupt-cells property Russell King
2019-06-17 14:49 ` Russell King
2019-06-18 8:17 ` Alexandre Belloni
2019-06-18 8:17 ` Alexandre Belloni
2019-06-18 8:20 ` Gregory CLEMENT [this message]
2019-06-18 8:20 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pnnbnw2w.fsf@FE-laptop \
--to=gregory.clement@bootlin.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.