From: Markus Armbruster <armbru@redhat.com>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org,
Suraj Jitindar Singh <sjitindarsingh@gmail.com>,
david@gibson.dropbear.id.au
Subject: Re: [Qemu-devel] [PATCH 1/2] monitor: Add dump-stack command
Date: Wed, 08 May 2019 15:10:45 +0200 [thread overview]
Message-ID: <87pnot148a.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20190508102621.GD2718@work-vm> (David Alan Gilbert's message of "Wed, 8 May 2019 11:26:21 +0100")
"Dr. David Alan Gilbert" <dgilbert@redhat.com> writes:
> * Markus Armbruster (armbru@redhat.com) wrote:
>> Suraj Jitindar Singh <sjitindarsingh@gmail.com> writes:
>>
>> > Add a monitor command "dump-stack" to be used to dump the stack for the
>> > current cpu.
>>
>> I guess this is just for debugging. Correct?
>>
>> Shouldn't this be "info stack", to match "info registers" and "info
>> cpustats"?
>
> Since this is primarily about walking the guests stack frames and not
> walking qemu internal data structures, I think it's probably OK to be
> a dump-stack rather than an info subcommand.
Well, "info registers" is also about the guest's state and not QEMU
internal state. Arguably, so are "info pic", "info tlb", ...
We have a long-standing tradition of using "info" for "pure"
information-retrieving commands. I rather like that pattern.
Ultimately your choice as the HMP maintainer, of course.
next prev parent reply other threads:[~2019-05-08 13:11 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-01 5:35 [Qemu-devel] [PATCH 1/2] monitor: Add dump-stack command Suraj Jitindar Singh
2019-05-01 5:35 ` Suraj Jitindar Singh
2019-05-01 5:35 ` [Qemu-devel] [PATCH 2/2] ppc: Add dump-stack implementation Suraj Jitindar Singh
2019-05-01 5:35 ` Suraj Jitindar Singh
2019-05-01 9:48 ` Alexey Kardashevskiy
2019-05-01 9:48 ` Alexey Kardashevskiy
2019-05-02 0:43 ` David Gibson
2019-05-02 0:43 ` David Gibson
2019-05-02 3:47 ` Alexey Kardashevskiy
2019-05-02 3:47 ` Alexey Kardashevskiy
2019-05-06 3:39 ` David Gibson
2019-05-02 13:59 ` [Qemu-devel] [Qemu-ppc] " Greg Kurz
2019-05-02 13:59 ` Greg Kurz
2019-05-07 11:24 ` [Qemu-devel] " Markus Armbruster
2019-05-01 10:44 ` [Qemu-devel] [PATCH 1/2] monitor: Add dump-stack command Dr. David Alan Gilbert
2019-05-01 10:44 ` Dr. David Alan Gilbert
2019-05-02 0:44 ` David Gibson
2019-05-02 0:44 ` David Gibson
2019-05-02 2:15 ` [Qemu-devel] [Qemu-ppc] " Alexey Kardashevskiy
2019-05-02 2:15 ` Alexey Kardashevskiy
2019-05-07 11:21 ` Markus Armbruster
2019-05-07 11:09 ` [Qemu-devel] " Markus Armbruster
2019-05-08 10:26 ` Dr. David Alan Gilbert
2019-05-08 13:10 ` Markus Armbruster [this message]
2019-05-08 13:15 ` Dr. David Alan Gilbert
2019-06-21 0:51 ` Suraj Jitindar Singh
2019-06-24 8:57 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pnot148a.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=sjitindarsingh@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.