Re: [Qemu-devel] [PATCH 1/2] monitor: Add dump-stack command

[Markus Armbruster <armbru@redhat.com>]

Suraj Jitindar Singh <sjitindarsingh@gmail.com> writes:

> On Wed, 2019-05-01 at 15:35 +1000, Suraj Jitindar Singh wrote:
>> Add a monitor command "dump-stack" to be used to dump the stack for
>> the
>> current cpu.
>
> To summarise the discussion which occured on this patch,
>
> - It looks like it's ok to duplicate this functionality as it provides
> an easier method to achieve this in the field and also for development.

By "duplicate", do you mean "one copy in gdb, one copy in QEMU"?

The question "why can't we simply hot-add a gdb server and use gdb?" has
not been answered as far as I can tell.

If the answer is "we can, but we find duplicating the functionality in
QEMU more convenient", then the next question is "okay, but is the
convenience worth the additional code?".  For PPC, the additional code
is fairly small.  What about more ornery targets like x86_64?  This
hasn't been answered, either.

> - It's ok for this to remain as a separate command and to not place it
> as a subcommand under info.

I strongly prefer "info FOO" for "pure" information-retrieving
commands.  But I'm not the maintainer anymore.

> I'll rework based on the comments on 2/2 of the series and resend.