From: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
To: dan.j.williams@intel.com
Cc: linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org,
linux-nvdimm@lists.01.org
Subject: Re: [PATCH v2] drivers/dax: Allow to include DEV_DAX_PMEM as builtin
Date: Tue, 07 May 2019 06:49:55 -0500 [thread overview]
Message-ID: <87pnoumql8.fsf@linux.ibm.com> (raw)
In-Reply-To: <20190401051421.17878-1-aneesh.kumar@linux.ibm.com>
Hi Dan,
"Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com> writes:
> This move the dependency to DEV_DAX_PMEM_COMPAT such that only
> if DEV_DAX_PMEM is built as module we can allow the compat support.
>
> This allows to test the new code easily in a emulation setup where we
> often build things without module support.
>
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
Any update on this. Can we merge this?
> ---
> Changes from V1:
> * Make sure we only build compat code as module
>
> drivers/dax/Kconfig | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/dax/Kconfig b/drivers/dax/Kconfig
> index 5ef624fe3934..a59f338f520f 100644
> --- a/drivers/dax/Kconfig
> +++ b/drivers/dax/Kconfig
> @@ -23,7 +23,6 @@ config DEV_DAX
> config DEV_DAX_PMEM
> tristate "PMEM DAX: direct access to persistent memory"
> depends on LIBNVDIMM && NVDIMM_DAX && DEV_DAX
> - depends on m # until we can kill DEV_DAX_PMEM_COMPAT
> default DEV_DAX
> help
> Support raw access to persistent memory. Note that this
> @@ -50,7 +49,7 @@ config DEV_DAX_KMEM
>
> config DEV_DAX_PMEM_COMPAT
> tristate "PMEM DAX: support the deprecated /sys/class/dax interface"
> - depends on DEV_DAX_PMEM
> + depends on m && DEV_DAX_PMEM=m
> default DEV_DAX_PMEM
> help
> Older versions of the libdaxctl library expect to find all
> --
> 2.20.1
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
To: dan.j.williams@intel.com
Cc: linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org,
linux-nvdimm@lists.01.org
Subject: Re: [PATCH v2] drivers/dax: Allow to include DEV_DAX_PMEM as builtin
Date: Tue, 07 May 2019 06:49:55 -0500 [thread overview]
Message-ID: <87pnoumql8.fsf@linux.ibm.com> (raw)
In-Reply-To: <20190401051421.17878-1-aneesh.kumar@linux.ibm.com>
Hi Dan,
"Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com> writes:
> This move the dependency to DEV_DAX_PMEM_COMPAT such that only
> if DEV_DAX_PMEM is built as module we can allow the compat support.
>
> This allows to test the new code easily in a emulation setup where we
> often build things without module support.
>
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
Any update on this. Can we merge this?
> ---
> Changes from V1:
> * Make sure we only build compat code as module
>
> drivers/dax/Kconfig | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/dax/Kconfig b/drivers/dax/Kconfig
> index 5ef624fe3934..a59f338f520f 100644
> --- a/drivers/dax/Kconfig
> +++ b/drivers/dax/Kconfig
> @@ -23,7 +23,6 @@ config DEV_DAX
> config DEV_DAX_PMEM
> tristate "PMEM DAX: direct access to persistent memory"
> depends on LIBNVDIMM && NVDIMM_DAX && DEV_DAX
> - depends on m # until we can kill DEV_DAX_PMEM_COMPAT
> default DEV_DAX
> help
> Support raw access to persistent memory. Note that this
> @@ -50,7 +49,7 @@ config DEV_DAX_KMEM
>
> config DEV_DAX_PMEM_COMPAT
> tristate "PMEM DAX: support the deprecated /sys/class/dax interface"
> - depends on DEV_DAX_PMEM
> + depends on m && DEV_DAX_PMEM=m
> default DEV_DAX_PMEM
> help
> Older versions of the libdaxctl library expect to find all
> --
> 2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
To: dan.j.williams@intel.com
Cc: linux-nvdimm@lists.01.org, linux-mm@kvack.org,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2] drivers/dax: Allow to include DEV_DAX_PMEM as builtin
Date: Tue, 07 May 2019 06:49:55 -0500 [thread overview]
Message-ID: <87pnoumql8.fsf@linux.ibm.com> (raw)
In-Reply-To: <20190401051421.17878-1-aneesh.kumar@linux.ibm.com>
Hi Dan,
"Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com> writes:
> This move the dependency to DEV_DAX_PMEM_COMPAT such that only
> if DEV_DAX_PMEM is built as module we can allow the compat support.
>
> This allows to test the new code easily in a emulation setup where we
> often build things without module support.
>
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
Any update on this. Can we merge this?
> ---
> Changes from V1:
> * Make sure we only build compat code as module
>
> drivers/dax/Kconfig | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/dax/Kconfig b/drivers/dax/Kconfig
> index 5ef624fe3934..a59f338f520f 100644
> --- a/drivers/dax/Kconfig
> +++ b/drivers/dax/Kconfig
> @@ -23,7 +23,6 @@ config DEV_DAX
> config DEV_DAX_PMEM
> tristate "PMEM DAX: direct access to persistent memory"
> depends on LIBNVDIMM && NVDIMM_DAX && DEV_DAX
> - depends on m # until we can kill DEV_DAX_PMEM_COMPAT
> default DEV_DAX
> help
> Support raw access to persistent memory. Note that this
> @@ -50,7 +49,7 @@ config DEV_DAX_KMEM
>
> config DEV_DAX_PMEM_COMPAT
> tristate "PMEM DAX: support the deprecated /sys/class/dax interface"
> - depends on DEV_DAX_PMEM
> + depends on m && DEV_DAX_PMEM=m
> default DEV_DAX_PMEM
> help
> Older versions of the libdaxctl library expect to find all
> --
> 2.20.1
next prev parent reply other threads:[~2019-05-07 11:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-01 5:14 [PATCH v2] drivers/dax: Allow to include DEV_DAX_PMEM as builtin Aneesh Kumar K.V
2019-04-01 5:14 ` Aneesh Kumar K.V
2019-04-01 5:14 ` Aneesh Kumar K.V
2019-05-07 11:49 ` Aneesh Kumar K.V [this message]
2019-05-07 11:49 ` Aneesh Kumar K.V
2019-05-07 11:49 ` Aneesh Kumar K.V
2019-05-07 15:09 ` Dan Williams
2019-05-07 15:09 ` Dan Williams
2019-05-07 15:09 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pnoumql8.fsf@linux.ibm.com \
--to=aneesh.kumar@linux.ibm.com \
--cc=dan.j.williams@intel.com \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.