All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: Rajkumar Manoharan <rmanohar@codeaurora.org>,
	linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Cc: make-wifi-fast@lists.bufferbloat.net
Subject: Re: [PATCH v5 4/6] ath9k: Switch to mac80211 TXQ scheduling and airtime APIs
Date: Mon, 21 Jan 2019 17:51:44 +0100	[thread overview]
Message-ID: <87pnsqkl7j.fsf@toke.dk> (raw)
In-Reply-To: <1545181331-5288-5-git-send-email-rmanohar@codeaurora.org>

Just discovered this while working on my follow-up:

>  void ath_tx_queue_tid(struct ath_softc *sc, struct ath_atx_tid *tid)
>  {
> -	struct ath_vif *avp = (struct ath_vif *) tid->an->vif->drv_priv;
> -	struct ath_chanctx *ctx = avp->chanctx;
> -	struct ath_acq *acq;
> +	struct ieee80211_txq *queue =
> +		container_of((void *)tid, struct ieee80211_txq, drv_priv);
>  
> -	if (!ctx || !list_empty(&tid->list))
> -		return;
> -
> -	acq = &ctx->acq[TID_TO_WME_AC(tid->tidno)];
> -	spin_lock_bh(&acq->lock);
> -	__ath_tx_queue_tid(sc, tid);
> -	spin_unlock_bh(&acq->lock);
> +	ieee80211_return_txq(sc->hw, queue);
>  }

After we evolved the API, this is now wrong, as ieee80211_return_txq()
should only be called while holding the right lock. I'll post a fixed
version tomorrow.

-Toke

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: Rajkumar Manoharan <rmanohar@codeaurora.org>,
	linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Cc: make-wifi-fast@lists.bufferbloat.net,
	Rajkumar Manoharan <rmanohar@codeaurora.org>
Subject: Re: [PATCH v5 4/6] ath9k: Switch to mac80211 TXQ scheduling and airtime APIs
Date: Mon, 21 Jan 2019 17:51:44 +0100	[thread overview]
Message-ID: <87pnsqkl7j.fsf@toke.dk> (raw)
In-Reply-To: <1545181331-5288-5-git-send-email-rmanohar@codeaurora.org>

Just discovered this while working on my follow-up:

>  void ath_tx_queue_tid(struct ath_softc *sc, struct ath_atx_tid *tid)
>  {
> -	struct ath_vif *avp = (struct ath_vif *) tid->an->vif->drv_priv;
> -	struct ath_chanctx *ctx = avp->chanctx;
> -	struct ath_acq *acq;
> +	struct ieee80211_txq *queue =
> +		container_of((void *)tid, struct ieee80211_txq, drv_priv);
>  
> -	if (!ctx || !list_empty(&tid->list))
> -		return;
> -
> -	acq = &ctx->acq[TID_TO_WME_AC(tid->tidno)];
> -	spin_lock_bh(&acq->lock);
> -	__ath_tx_queue_tid(sc, tid);
> -	spin_unlock_bh(&acq->lock);
> +	ieee80211_return_txq(sc->hw, queue);
>  }

After we evolved the API, this is now wrong, as ieee80211_return_txq()
should only be called while holding the right lock. I'll post a fixed
version tomorrow.

-Toke

  reply	other threads:[~2019-01-21 16:51 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-19  1:02 [PATCH v5 0/6] Move TXQ scheduling and airtime fairness into mac80211 Rajkumar Manoharan
2018-12-19  1:02 ` Rajkumar Manoharan
2018-12-19  1:02 ` [PATCH v5 1/6] mac80211: Add TXQ scheduling API Rajkumar Manoharan
2018-12-19  1:02   ` Rajkumar Manoharan
2018-12-19  1:02 ` [PATCH v5 2/6] cfg80211: Add airtime statistics and settings Rajkumar Manoharan
2018-12-19  1:02   ` Rajkumar Manoharan
2018-12-19  1:02 ` [PATCH v5 3/6] mac80211: Add airtime accounting and scheduling to TXQs Rajkumar Manoharan
2018-12-19  1:02   ` Rajkumar Manoharan
2018-12-19 15:29   ` kbuild test robot
2018-12-19 15:29     ` kbuild test robot
2018-12-19  1:02 ` [PATCH v5 4/6] ath9k: Switch to mac80211 TXQ scheduling and airtime APIs Rajkumar Manoharan
2018-12-19  1:02   ` Rajkumar Manoharan
2019-01-21 16:51   ` Toke Høiland-Jørgensen [this message]
2019-01-21 16:51     ` Toke Høiland-Jørgensen
2018-12-19  1:02 ` [PATCH v5 5/6] ath10k: migrate to mac80211 txq scheduling Rajkumar Manoharan
2018-12-19  1:02   ` Rajkumar Manoharan
2018-12-19 13:24   ` Kalle Valo
2018-12-19 13:24     ` Kalle Valo
2019-01-10 22:46     ` Rajkumar Manoharan
2019-01-10 22:46       ` Rajkumar Manoharan
2018-12-19  1:02 ` [PATCH v5 6/6] ath10k: reporting estimated tx airtime for fairness Rajkumar Manoharan
2018-12-19  1:02   ` Rajkumar Manoharan
2018-12-19 13:25   ` Kalle Valo
2018-12-19 13:25     ` Kalle Valo
2018-12-19 13:12 ` [PATCH v5 0/6] Move TXQ scheduling and airtime fairness into mac80211 Toke Høiland-Jørgensen
2018-12-19 13:12   ` Toke Høiland-Jørgensen
2018-12-19 13:34   ` [Make-wifi-fast] " Dave Taht
2018-12-19 13:34     ` Dave Taht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pnsqkl7j.fsf@toke.dk \
    --to=toke@toke.dk \
    --cc=ath10k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=make-wifi-fast@lists.bufferbloat.net \
    --cc=rmanohar@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.