* [Qemu-devel] [PATCH] target: hax: replace g_malloc with g_new0
@ 2018-11-26 9:56 ` Li Qiang
0 siblings, 0 replies; 8+ messages in thread
From: Li Qiang @ 2018-11-26 9:56 UTC (permalink / raw)
To: pbonzini, rth, ehabkost, laurent, alex.bennee, philmd, armbru
Cc: qemu-trivial, qemu-devel, Li Qiang
And also the g_malloc doesn't need check return value,
remove it.
Cc: qemu-trivial@nongnu.org
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Li Qiang <liq3ea@gmail.com>
---
target/i386/hax-all.c | 15 +++------------
1 file changed, 3 insertions(+), 12 deletions(-)
diff --git a/target/i386/hax-all.c b/target/i386/hax-all.c
index d2e512856b..502ce6f0af 100644
--- a/target/i386/hax-all.c
+++ b/target/i386/hax-all.c
@@ -154,13 +154,7 @@ int hax_vcpu_create(int id)
return 0;
}
- vcpu = g_malloc(sizeof(struct hax_vcpu_state));
- if (!vcpu) {
- fprintf(stderr, "Failed to alloc vcpu state\n");
- return -ENOMEM;
- }
-
- memset(vcpu, 0, sizeof(struct hax_vcpu_state));
+ vcpu = g_new0(struct hax_vcpu_state, 1);
ret = hax_host_create_vcpu(hax_global.vm->fd, id);
if (ret) {
@@ -250,11 +244,8 @@ struct hax_vm *hax_vm_create(struct hax_state *hax)
return hax->vm;
}
- vm = g_malloc(sizeof(struct hax_vm));
- if (!vm) {
- return NULL;
- }
- memset(vm, 0, sizeof(struct hax_vm));
+ vm = g_new0(struct hax_vm, 1);
+
ret = hax_host_create_vm(hax, &vm_id);
if (ret) {
fprintf(stderr, "Failed to create vm %x\n", ret);
--
2.11.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [Qemu-trivial] [PATCH] target: hax: replace g_malloc with g_new0
2018-11-26 9:56 ` [Qemu-devel] " Li Qiang
@ 2018-11-26 9:59 ` Laurent Vivier
-1 siblings, 0 replies; 8+ messages in thread
From: Laurent Vivier @ 2018-11-26 9:59 UTC (permalink / raw)
To: Li Qiang, pbonzini, rth, ehabkost, alex.bennee, philmd, armbru
Cc: qemu-trivial, qemu-devel
On 26/11/2018 10:56, Li Qiang wrote:
> And also the g_malloc doesn't need check return value,
> remove it.
>
> Cc: qemu-trivial@nongnu.org
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Li Qiang <liq3ea@gmail.com>
> ---
> target/i386/hax-all.c | 15 +++------------
> 1 file changed, 3 insertions(+), 12 deletions(-)
>
> diff --git a/target/i386/hax-all.c b/target/i386/hax-all.c
> index d2e512856b..502ce6f0af 100644
> --- a/target/i386/hax-all.c
> +++ b/target/i386/hax-all.c
> @@ -154,13 +154,7 @@ int hax_vcpu_create(int id)
> return 0;
> }
>
> - vcpu = g_malloc(sizeof(struct hax_vcpu_state));
> - if (!vcpu) {
> - fprintf(stderr, "Failed to alloc vcpu state\n");
> - return -ENOMEM;
> - }
> -
> - memset(vcpu, 0, sizeof(struct hax_vcpu_state));
> + vcpu = g_new0(struct hax_vcpu_state, 1);
>
> ret = hax_host_create_vcpu(hax_global.vm->fd, id);
> if (ret) {
> @@ -250,11 +244,8 @@ struct hax_vm *hax_vm_create(struct hax_state *hax)
> return hax->vm;
> }
>
> - vm = g_malloc(sizeof(struct hax_vm));
> - if (!vm) {
> - return NULL;
> - }
> - memset(vm, 0, sizeof(struct hax_vm));
> + vm = g_new0(struct hax_vm, 1);
> +
> ret = hax_host_create_vm(hax, &vm_id);
> if (ret) {
> fprintf(stderr, "Failed to create vm %x\n", ret);
>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [Qemu-devel] [PATCH] target: hax: replace g_malloc with g_new0
@ 2018-11-26 9:59 ` Laurent Vivier
0 siblings, 0 replies; 8+ messages in thread
From: Laurent Vivier @ 2018-11-26 9:59 UTC (permalink / raw)
To: Li Qiang, pbonzini, rth, ehabkost, alex.bennee, philmd, armbru
Cc: qemu-trivial, qemu-devel
On 26/11/2018 10:56, Li Qiang wrote:
> And also the g_malloc doesn't need check return value,
> remove it.
>
> Cc: qemu-trivial@nongnu.org
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Li Qiang <liq3ea@gmail.com>
> ---
> target/i386/hax-all.c | 15 +++------------
> 1 file changed, 3 insertions(+), 12 deletions(-)
>
> diff --git a/target/i386/hax-all.c b/target/i386/hax-all.c
> index d2e512856b..502ce6f0af 100644
> --- a/target/i386/hax-all.c
> +++ b/target/i386/hax-all.c
> @@ -154,13 +154,7 @@ int hax_vcpu_create(int id)
> return 0;
> }
>
> - vcpu = g_malloc(sizeof(struct hax_vcpu_state));
> - if (!vcpu) {
> - fprintf(stderr, "Failed to alloc vcpu state\n");
> - return -ENOMEM;
> - }
> -
> - memset(vcpu, 0, sizeof(struct hax_vcpu_state));
> + vcpu = g_new0(struct hax_vcpu_state, 1);
>
> ret = hax_host_create_vcpu(hax_global.vm->fd, id);
> if (ret) {
> @@ -250,11 +244,8 @@ struct hax_vm *hax_vm_create(struct hax_state *hax)
> return hax->vm;
> }
>
> - vm = g_malloc(sizeof(struct hax_vm));
> - if (!vm) {
> - return NULL;
> - }
> - memset(vm, 0, sizeof(struct hax_vm));
> + vm = g_new0(struct hax_vm, 1);
> +
> ret = hax_host_create_vm(hax, &vm_id);
> if (ret) {
> fprintf(stderr, "Failed to create vm %x\n", ret);
>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-trivial] [PATCH] target: hax: replace g_malloc with g_new0
2018-11-26 9:56 ` [Qemu-devel] " Li Qiang
@ 2018-11-26 11:27 ` Alex Bennée
-1 siblings, 0 replies; 8+ messages in thread
From: Alex Bennée @ 2018-11-26 11:27 UTC (permalink / raw)
To: Li Qiang
Cc: pbonzini, rth, ehabkost, laurent, philmd, armbru, qemu-trivial,
qemu-devel
Li Qiang <liq3ea@gmail.com> writes:
> And also the g_malloc doesn't need check return value,
> remove it.
>
> Cc: qemu-trivial@nongnu.org
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Li Qiang <liq3ea@gmail.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> target/i386/hax-all.c | 15 +++------------
> 1 file changed, 3 insertions(+), 12 deletions(-)
>
> diff --git a/target/i386/hax-all.c b/target/i386/hax-all.c
> index d2e512856b..502ce6f0af 100644
> --- a/target/i386/hax-all.c
> +++ b/target/i386/hax-all.c
> @@ -154,13 +154,7 @@ int hax_vcpu_create(int id)
> return 0;
> }
>
> - vcpu = g_malloc(sizeof(struct hax_vcpu_state));
> - if (!vcpu) {
> - fprintf(stderr, "Failed to alloc vcpu state\n");
> - return -ENOMEM;
> - }
> -
> - memset(vcpu, 0, sizeof(struct hax_vcpu_state));
> + vcpu = g_new0(struct hax_vcpu_state, 1);
>
> ret = hax_host_create_vcpu(hax_global.vm->fd, id);
> if (ret) {
> @@ -250,11 +244,8 @@ struct hax_vm *hax_vm_create(struct hax_state *hax)
> return hax->vm;
> }
>
> - vm = g_malloc(sizeof(struct hax_vm));
> - if (!vm) {
> - return NULL;
> - }
> - memset(vm, 0, sizeof(struct hax_vm));
> + vm = g_new0(struct hax_vm, 1);
> +
> ret = hax_host_create_vm(hax, &vm_id);
> if (ret) {
> fprintf(stderr, "Failed to create vm %x\n", ret);
--
Alex Bennée
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [Qemu-devel] [PATCH] target: hax: replace g_malloc with g_new0
@ 2018-11-26 11:27 ` Alex Bennée
0 siblings, 0 replies; 8+ messages in thread
From: Alex Bennée @ 2018-11-26 11:27 UTC (permalink / raw)
To: Li Qiang
Cc: pbonzini, rth, ehabkost, laurent, philmd, armbru, qemu-trivial,
qemu-devel
Li Qiang <liq3ea@gmail.com> writes:
> And also the g_malloc doesn't need check return value,
> remove it.
>
> Cc: qemu-trivial@nongnu.org
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Li Qiang <liq3ea@gmail.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> target/i386/hax-all.c | 15 +++------------
> 1 file changed, 3 insertions(+), 12 deletions(-)
>
> diff --git a/target/i386/hax-all.c b/target/i386/hax-all.c
> index d2e512856b..502ce6f0af 100644
> --- a/target/i386/hax-all.c
> +++ b/target/i386/hax-all.c
> @@ -154,13 +154,7 @@ int hax_vcpu_create(int id)
> return 0;
> }
>
> - vcpu = g_malloc(sizeof(struct hax_vcpu_state));
> - if (!vcpu) {
> - fprintf(stderr, "Failed to alloc vcpu state\n");
> - return -ENOMEM;
> - }
> -
> - memset(vcpu, 0, sizeof(struct hax_vcpu_state));
> + vcpu = g_new0(struct hax_vcpu_state, 1);
>
> ret = hax_host_create_vcpu(hax_global.vm->fd, id);
> if (ret) {
> @@ -250,11 +244,8 @@ struct hax_vm *hax_vm_create(struct hax_state *hax)
> return hax->vm;
> }
>
> - vm = g_malloc(sizeof(struct hax_vm));
> - if (!vm) {
> - return NULL;
> - }
> - memset(vm, 0, sizeof(struct hax_vm));
> + vm = g_new0(struct hax_vm, 1);
> +
> ret = hax_host_create_vm(hax, &vm_id);
> if (ret) {
> fprintf(stderr, "Failed to create vm %x\n", ret);
--
Alex Bennée
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-trivial] [PATCH] target: hax: replace g_malloc with g_new0
2018-11-26 9:56 ` [Qemu-devel] " Li Qiang
@ 2018-11-27 11:30 ` Laurent Vivier
-1 siblings, 0 replies; 8+ messages in thread
From: Laurent Vivier @ 2018-11-27 11:30 UTC (permalink / raw)
To: Li Qiang, pbonzini, rth, ehabkost, alex.bennee, philmd, armbru
Cc: qemu-trivial, qemu-devel
On 26/11/2018 10:56, Li Qiang wrote:
> And also the g_malloc doesn't need check return value,
> remove it.
>
> Cc: qemu-trivial@nongnu.org
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Li Qiang <liq3ea@gmail.com>
> ---
> target/i386/hax-all.c | 15 +++------------
> 1 file changed, 3 insertions(+), 12 deletions(-)
>
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] target: hax: replace g_malloc with g_new0
@ 2018-11-27 11:30 ` Laurent Vivier
0 siblings, 0 replies; 8+ messages in thread
From: Laurent Vivier @ 2018-11-27 11:30 UTC (permalink / raw)
To: Li Qiang, pbonzini, rth, ehabkost, alex.bennee, philmd, armbru
Cc: qemu-trivial, qemu-devel
On 26/11/2018 10:56, Li Qiang wrote:
> And also the g_malloc doesn't need check return value,
> remove it.
>
> Cc: qemu-trivial@nongnu.org
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Li Qiang <liq3ea@gmail.com>
> ---
> target/i386/hax-all.c | 15 +++------------
> 1 file changed, 3 insertions(+), 12 deletions(-)
>
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 8+ messages in thread