From: gregory.clement@free-electrons.com (Gregory CLEMENT)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/6] arm: dts: marvell: Add missing #phy-cells to usb-nop-xceiv
Date: Wed, 22 Nov 2017 17:59:23 +0100 [thread overview]
Message-ID: <87po8az1uc.fsf@free-electrons.com> (raw)
In-Reply-To: <CAK8P3a1x7mnpvfgsnwVJdX4OFwJZn0GpTE9ATfoLuQPB5ev=gg@mail.gmail.com> (Arnd Bergmann's message of "Tue, 21 Nov 2017 21:45:49 +0100")
Hi Arnd,
On mar., nov. 21 2017, Arnd Bergmann <arnd@arndb.de> wrote:
> On Tue, Nov 21, 2017 at 9:09 PM, Andrew Lunn <andrew@lunn.ch> wrote:
>> On Tue, Nov 21, 2017 at 12:29:48PM -0600, Rob Herring wrote:
>>> On Thu, Nov 9, 2017 at 4:26 PM, Rob Herring <robh@kernel.org> wrote:
>>> > "usb-nop-xceiv" is using the phy binding, but is missing #phy-cells
>>> > property. This is probably because the binding was the precursor to the phy
>>> > binding.
>>> >
>>> > Fixes the following warning in Marvell dts files:
>>> >
>>> > Warning (phys_property): Missing property '#phy-cells' in node ...
>>> >
>>> > Signed-off-by: Rob Herring <robh@kernel.org>
>>> > Cc: Jason Cooper <jason@lakedaemon.net>
>>> > Cc: Andrew Lunn <andrew@lunn.ch>
>>> > Cc: Gregory Clement <gregory.clement@free-electrons.com>
>>> > Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
>>> > ---
>>> > Please apply to Marvell tree.
>>>
>>> Ping.
>>>
>>> Arnd, can you apply if you'd like the warnings fixed and Marvell
>>> maintainers don't respond.
>>
>> Hi Rob
>>
>> Patches submitted a week before the merge window opens are generally
>> deferred to the next cycle. I expect that once -rc1 is out, Gregory
>> will pick up this patch.
>
> These are real bugfixes, I want them in 4.15, since we now get a
> loud warning for them. I'd rather not shut up that warning because
> it's not a false-positive.
As pointed by Andrew, I planned to take them once the 4.15-rc1 would be
released. It was not obvious for me that it was real fixes. Actually I
would have expected to have first the dts fixed in a release and then
the warning enabled.
I am fine if you take this patch, especially if it is merged in
4.15-rc1.
So for this patch:
Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
Thanks,
Gregory
>
> Arnd
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Gregory CLEMENT <gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
Cc: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>,
Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"devicetree@vger.kernel.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"arm@kernel.org" <arm-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>,
Sebastian Hesselbarth
<sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH 3/6] arm: dts: marvell: Add missing #phy-cells to usb-nop-xceiv
Date: Wed, 22 Nov 2017 17:59:23 +0100 [thread overview]
Message-ID: <87po8az1uc.fsf@free-electrons.com> (raw)
In-Reply-To: <CAK8P3a1x7mnpvfgsnwVJdX4OFwJZn0GpTE9ATfoLuQPB5ev=gg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> (Arnd Bergmann's message of "Tue, 21 Nov 2017 21:45:49 +0100")
Hi Arnd,
On mar., nov. 21 2017, Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org> wrote:
> On Tue, Nov 21, 2017 at 9:09 PM, Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org> wrote:
>> On Tue, Nov 21, 2017 at 12:29:48PM -0600, Rob Herring wrote:
>>> On Thu, Nov 9, 2017 at 4:26 PM, Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
>>> > "usb-nop-xceiv" is using the phy binding, but is missing #phy-cells
>>> > property. This is probably because the binding was the precursor to the phy
>>> > binding.
>>> >
>>> > Fixes the following warning in Marvell dts files:
>>> >
>>> > Warning (phys_property): Missing property '#phy-cells' in node ...
>>> >
>>> > Signed-off-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
>>> > Cc: Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>
>>> > Cc: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
>>> > Cc: Gregory Clement <gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
>>> > Cc: Sebastian Hesselbarth <sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>>> > ---
>>> > Please apply to Marvell tree.
>>>
>>> Ping.
>>>
>>> Arnd, can you apply if you'd like the warnings fixed and Marvell
>>> maintainers don't respond.
>>
>> Hi Rob
>>
>> Patches submitted a week before the merge window opens are generally
>> deferred to the next cycle. I expect that once -rc1 is out, Gregory
>> will pick up this patch.
>
> These are real bugfixes, I want them in 4.15, since we now get a
> loud warning for them. I'd rather not shut up that warning because
> it's not a false-positive.
As pointed by Andrew, I planned to take them once the 4.15-rc1 would be
released. It was not obvious for me that it was real fixes. Actually I
would have expected to have first the dts fixed in a release and then
the warning enabled.
I am fine if you take this patch, especially if it is merged in
4.15-rc1.
So for this patch:
Acked-by: Gregory CLEMENT <gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Thanks,
Gregory
>
> Arnd
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-11-22 16:59 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-09 22:26 [PATCH 1/6] dt-bindings: usb: add #phy-cells to usb-nop-xceiv Rob Herring
2017-11-09 22:26 ` Rob Herring
2017-11-09 22:26 ` [PATCH 2/6] arm: dts: imx: Add missing " Rob Herring
2017-11-09 22:26 ` Rob Herring
2017-11-16 11:10 ` Shawn Guo
2017-11-16 11:10 ` Shawn Guo
2017-11-09 22:26 ` [PATCH 3/6] arm: dts: marvell: " Rob Herring
2017-11-09 22:26 ` Rob Herring
2017-11-21 18:29 ` Rob Herring
2017-11-21 18:29 ` Rob Herring
2017-11-21 20:09 ` Andrew Lunn
2017-11-21 20:09 ` Andrew Lunn
2017-11-21 20:45 ` Arnd Bergmann
2017-11-21 20:45 ` Arnd Bergmann
2017-11-22 16:59 ` Gregory CLEMENT [this message]
2017-11-22 16:59 ` Gregory CLEMENT
2017-11-28 19:38 ` Rob Herring
2017-11-28 19:38 ` Rob Herring
2017-11-21 20:56 ` Andrew Lunn
2017-11-21 20:56 ` Andrew Lunn
2017-12-03 0:49 ` Olof Johansson
2017-12-03 0:49 ` Olof Johansson
2017-11-09 22:26 ` [PATCH 4/6] arm: dts: nspire: " Rob Herring
2017-11-09 22:26 ` Rob Herring
2017-12-07 14:44 ` Arnd Bergmann
2017-12-07 14:44 ` Arnd Bergmann
[not found] ` <20171109222614.5719-1-robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-11-09 22:26 ` [PATCH 5/6] arm: dts: omap: " Rob Herring
2017-11-09 22:26 ` Rob Herring
[not found] ` <20171109222614.5719-5-robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-11-10 16:25 ` Tony Lindgren
2017-11-10 16:25 ` Tony Lindgren
2017-11-09 22:26 ` [PATCH 6/6] arm: dts: am33xx: Add missing #phy-cells to ti,am335x-usb-phy Rob Herring
2017-11-09 22:26 ` [PATCH 6/6] arm: dts: am33xx: Add missing #phy-cells to ti, am335x-usb-phy Rob Herring
[not found] ` <20171109222614.5719-6-robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-11-10 16:26 ` [PATCH 6/6] arm: dts: am33xx: Add missing #phy-cells to ti,am335x-usb-phy Tony Lindgren
2017-11-10 16:26 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87po8az1uc.fsf@free-electrons.com \
--to=gregory.clement@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.