Re: [PATCH] drm/i915/cnl: Fix LSPCON support.

[Jani Nikula <jani.nikula@linux.intel.com>]

On Tue, 15 Aug 2017, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
> When LSPCON support was extended to CNL
> one part was missed on lspcon_init.
>
> So, instead of adding check per platform on lspcon_init
> let's use HAS_LSPCON that is already there for that
> purpose.

I think HAS_LSPCON will require tweaking going forward, but this is good
for now.

Reviewed-by: Jani Nikula <jani.nikula@intel.com>


>
> Fixes: ff15947e0f02 ("drm/i915/cnl: LSPCON support is gen9+")
> Cc: Shashank Sharma <shashank.sharma@intel.com>
> Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_lspcon.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_lspcon.c b/drivers/gpu/drm/i915/intel_lspcon.c
> index 5abef482eacf..beb9baaf2f2e 100644
> --- a/drivers/gpu/drm/i915/intel_lspcon.c
> +++ b/drivers/gpu/drm/i915/intel_lspcon.c
> @@ -210,8 +210,8 @@ bool lspcon_init(struct intel_digital_port *intel_dig_port)
>  	struct drm_device *dev = intel_dig_port->base.base.dev;
>  	struct drm_i915_private *dev_priv = to_i915(dev);
>  
> -	if (!IS_GEN9(dev_priv)) {
> -		DRM_ERROR("LSPCON is supported on GEN9 only\n");
> +	if (!HAS_LSPCON(dev_priv)) {
> +		DRM_ERROR("LSPCON is not supported on this platform\n");
>  		return false;
>  	}

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx