* [PATCH] drm/i915/cnl: Fix LSPCON support.
@ 2017-08-16 3:04 Rodrigo Vivi
2017-08-16 3:23 ` ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Rodrigo Vivi @ 2017-08-16 3:04 UTC (permalink / raw)
To: intel-gfx; +Cc: Paulo Zanoni, Rodrigo Vivi
When LSPCON support was extended to CNL
one part was missed on lspcon_init.
So, instead of adding check per platform on lspcon_init
let's use HAS_LSPCON that is already there for that
purpose.
Fixes: ff15947e0f02 ("drm/i915/cnl: LSPCON support is gen9+")
Cc: Shashank Sharma <shashank.sharma@intel.com>
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
drivers/gpu/drm/i915/intel_lspcon.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_lspcon.c b/drivers/gpu/drm/i915/intel_lspcon.c
index 5abef482eacf..beb9baaf2f2e 100644
--- a/drivers/gpu/drm/i915/intel_lspcon.c
+++ b/drivers/gpu/drm/i915/intel_lspcon.c
@@ -210,8 +210,8 @@ bool lspcon_init(struct intel_digital_port *intel_dig_port)
struct drm_device *dev = intel_dig_port->base.base.dev;
struct drm_i915_private *dev_priv = to_i915(dev);
- if (!IS_GEN9(dev_priv)) {
- DRM_ERROR("LSPCON is supported on GEN9 only\n");
+ if (!HAS_LSPCON(dev_priv)) {
+ DRM_ERROR("LSPCON is not supported on this platform\n");
return false;
}
--
2.13.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread* ✓ Fi.CI.BAT: success for drm/i915/cnl: Fix LSPCON support.
2017-08-16 3:04 [PATCH] drm/i915/cnl: Fix LSPCON support Rodrigo Vivi
@ 2017-08-16 3:23 ` Patchwork
2017-08-16 7:57 ` [PATCH] " Jani Nikula
2017-08-16 10:47 ` Sharma, Shashank
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2017-08-16 3:23 UTC (permalink / raw)
To: Rodrigo Vivi; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/cnl: Fix LSPCON support.
URL : https://patchwork.freedesktop.org/series/28844/
State : success
== Summary ==
Series 28844v1 drm/i915/cnl: Fix LSPCON support.
https://patchwork.freedesktop.org/api/1.0/series/28844/revisions/1/mbox/
Test gem_exec_flush:
Subgroup basic-batch-kernel-default-uc:
pass -> FAIL (fi-snb-2600) fdo#100007
Test kms_cursor_legacy:
Subgroup basic-busy-flip-before-cursor-atomic:
pass -> FAIL (fi-snb-2600) fdo#100215
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-b:
pass -> DMESG-WARN (fi-byt-n2820) fdo#101705
fdo#100007 https://bugs.freedesktop.org/show_bug.cgi?id=100007
fdo#100215 https://bugs.freedesktop.org/show_bug.cgi?id=100215
fdo#101705 https://bugs.freedesktop.org/show_bug.cgi?id=101705
fi-bdw-5557u total:279 pass:268 dwarn:0 dfail:0 fail:0 skip:11 time:450s
fi-bdw-gvtdvm total:279 pass:265 dwarn:0 dfail:0 fail:0 skip:14 time:434s
fi-blb-e6850 total:279 pass:224 dwarn:1 dfail:0 fail:0 skip:54 time:355s
fi-bsw-n3050 total:279 pass:243 dwarn:0 dfail:0 fail:0 skip:36 time:548s
fi-bxt-j4205 total:279 pass:260 dwarn:0 dfail:0 fail:0 skip:19 time:510s
fi-byt-j1900 total:279 pass:254 dwarn:1 dfail:0 fail:0 skip:24 time:517s
fi-byt-n2820 total:279 pass:250 dwarn:1 dfail:0 fail:0 skip:28 time:509s
fi-glk-2a total:279 pass:260 dwarn:0 dfail:0 fail:0 skip:19 time:604s
fi-hsw-4770 total:279 pass:263 dwarn:0 dfail:0 fail:0 skip:16 time:437s
fi-hsw-4770r total:279 pass:263 dwarn:0 dfail:0 fail:0 skip:16 time:418s
fi-ilk-650 total:279 pass:229 dwarn:0 dfail:0 fail:0 skip:50 time:421s
fi-ivb-3520m total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:503s
fi-ivb-3770 total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:478s
fi-kbl-7500u total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:468s
fi-kbl-7560u total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:590s
fi-kbl-r total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:597s
fi-pnv-d510 total:279 pass:223 dwarn:1 dfail:0 fail:0 skip:55 time:529s
fi-skl-6260u total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:460s
fi-skl-6700k total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:471s
fi-skl-6770hq total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:481s
fi-skl-gvtdvm total:279 pass:266 dwarn:0 dfail:0 fail:0 skip:13 time:437s
fi-skl-x1585l total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:498s
fi-snb-2520m total:279 pass:251 dwarn:0 dfail:0 fail:0 skip:28 time:547s
fi-snb-2600 total:279 pass:248 dwarn:0 dfail:0 fail:2 skip:29 time:404s
5118c7fa9c878351d1ed17a36b97966f68da72df drm-tip: 2017y-08m-15d-23h-58m-24s UTC integration manifest
dc2dc74e844c drm/i915/cnl: Fix LSPCON support.
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5411/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/i915/cnl: Fix LSPCON support.
2017-08-16 3:04 [PATCH] drm/i915/cnl: Fix LSPCON support Rodrigo Vivi
2017-08-16 3:23 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2017-08-16 7:57 ` Jani Nikula
2017-08-16 10:47 ` Sharma, Shashank
2 siblings, 0 replies; 5+ messages in thread
From: Jani Nikula @ 2017-08-16 7:57 UTC (permalink / raw)
To: intel-gfx; +Cc: Paulo Zanoni, Rodrigo Vivi
On Tue, 15 Aug 2017, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
> When LSPCON support was extended to CNL
> one part was missed on lspcon_init.
>
> So, instead of adding check per platform on lspcon_init
> let's use HAS_LSPCON that is already there for that
> purpose.
I think HAS_LSPCON will require tweaking going forward, but this is good
for now.
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
>
> Fixes: ff15947e0f02 ("drm/i915/cnl: LSPCON support is gen9+")
> Cc: Shashank Sharma <shashank.sharma@intel.com>
> Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> drivers/gpu/drm/i915/intel_lspcon.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_lspcon.c b/drivers/gpu/drm/i915/intel_lspcon.c
> index 5abef482eacf..beb9baaf2f2e 100644
> --- a/drivers/gpu/drm/i915/intel_lspcon.c
> +++ b/drivers/gpu/drm/i915/intel_lspcon.c
> @@ -210,8 +210,8 @@ bool lspcon_init(struct intel_digital_port *intel_dig_port)
> struct drm_device *dev = intel_dig_port->base.base.dev;
> struct drm_i915_private *dev_priv = to_i915(dev);
>
> - if (!IS_GEN9(dev_priv)) {
> - DRM_ERROR("LSPCON is supported on GEN9 only\n");
> + if (!HAS_LSPCON(dev_priv)) {
> + DRM_ERROR("LSPCON is not supported on this platform\n");
> return false;
> }
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/i915/cnl: Fix LSPCON support.
2017-08-16 3:04 [PATCH] drm/i915/cnl: Fix LSPCON support Rodrigo Vivi
2017-08-16 3:23 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-08-16 7:57 ` [PATCH] " Jani Nikula
@ 2017-08-16 10:47 ` Sharma, Shashank
2017-08-16 14:50 ` Rodrigo Vivi
2 siblings, 1 reply; 5+ messages in thread
From: Sharma, Shashank @ 2017-08-16 10:47 UTC (permalink / raw)
To: Rodrigo Vivi, intel-gfx; +Cc: Paulo Zanoni
There is probably one more place where we want this change, but I will
try to cover that in my 4:2:0 for lspcon patch set.
Meanwhile, please feel free to use:
Reviewed-by: Shashank Sharma <shashank.sharma@intel.com>
Regards
Shashank
On 8/16/2017 8:34 AM, Rodrigo Vivi wrote:
> When LSPCON support was extended to CNL
> one part was missed on lspcon_init.
>
> So, instead of adding check per platform on lspcon_init
> let's use HAS_LSPCON that is already there for that
> purpose.
>
> Fixes: ff15947e0f02 ("drm/i915/cnl: LSPCON support is gen9+")
> Cc: Shashank Sharma <shashank.sharma@intel.com>
> Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> drivers/gpu/drm/i915/intel_lspcon.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_lspcon.c b/drivers/gpu/drm/i915/intel_lspcon.c
> index 5abef482eacf..beb9baaf2f2e 100644
> --- a/drivers/gpu/drm/i915/intel_lspcon.c
> +++ b/drivers/gpu/drm/i915/intel_lspcon.c
> @@ -210,8 +210,8 @@ bool lspcon_init(struct intel_digital_port *intel_dig_port)
> struct drm_device *dev = intel_dig_port->base.base.dev;
> struct drm_i915_private *dev_priv = to_i915(dev);
>
> - if (!IS_GEN9(dev_priv)) {
> - DRM_ERROR("LSPCON is supported on GEN9 only\n");
> + if (!HAS_LSPCON(dev_priv)) {
> + DRM_ERROR("LSPCON is not supported on this platform\n");
> return false;
> }
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/i915/cnl: Fix LSPCON support.
2017-08-16 10:47 ` Sharma, Shashank
@ 2017-08-16 14:50 ` Rodrigo Vivi
0 siblings, 0 replies; 5+ messages in thread
From: Rodrigo Vivi @ 2017-08-16 14:50 UTC (permalink / raw)
To: Sharma, Shashank; +Cc: intel-gfx, Paulo Zanoni, Rodrigo Vivi
merged to dinq. thanks for the reviews.
On Wed, Aug 16, 2017 at 3:47 AM, Sharma, Shashank
<shashank.sharma@intel.com> wrote:
> There is probably one more place where we want this change, but I will try
> to cover that in my 4:2:0 for lspcon patch set.
>
> Meanwhile, please feel free to use:
>
> Reviewed-by: Shashank Sharma <shashank.sharma@intel.com>
>
>
> Regards
> Shashank
>
> On 8/16/2017 8:34 AM, Rodrigo Vivi wrote:
>>
>> When LSPCON support was extended to CNL
>> one part was missed on lspcon_init.
>>
>> So, instead of adding check per platform on lspcon_init
>> let's use HAS_LSPCON that is already there for that
>> purpose.
>>
>> Fixes: ff15947e0f02 ("drm/i915/cnl: LSPCON support is gen9+")
>> Cc: Shashank Sharma <shashank.sharma@intel.com>
>> Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
>> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>> ---
>> drivers/gpu/drm/i915/intel_lspcon.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_lspcon.c
>> b/drivers/gpu/drm/i915/intel_lspcon.c
>> index 5abef482eacf..beb9baaf2f2e 100644
>> --- a/drivers/gpu/drm/i915/intel_lspcon.c
>> +++ b/drivers/gpu/drm/i915/intel_lspcon.c
>> @@ -210,8 +210,8 @@ bool lspcon_init(struct intel_digital_port
>> *intel_dig_port)
>> struct drm_device *dev = intel_dig_port->base.base.dev;
>> struct drm_i915_private *dev_priv = to_i915(dev);
>> - if (!IS_GEN9(dev_priv)) {
>> - DRM_ERROR("LSPCON is supported on GEN9 only\n");
>> + if (!HAS_LSPCON(dev_priv)) {
>> + DRM_ERROR("LSPCON is not supported on this platform\n");
>> return false;
>> }
>>
>
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Rodrigo Vivi
Blog: http://blog.vivi.eng.br
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-08-16 14:50 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-16 3:04 [PATCH] drm/i915/cnl: Fix LSPCON support Rodrigo Vivi
2017-08-16 3:23 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-08-16 7:57 ` [PATCH] " Jani Nikula
2017-08-16 10:47 ` Sharma, Shashank
2017-08-16 14:50 ` Rodrigo Vivi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.