All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicolai Stange <nicstange-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Ard Biesheuvel <ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: "Nicolai Stange"
	<nicstange-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	"Ingo Molnar" <mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	"Matt Fleming"
	<matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>,
	"Thomas Gleixner" <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>,
	"Ingo Molnar" <mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	"H. Peter Anvin" <hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>,
	"x86@kernel.org" <x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	"linux-efi@vger.kernel.org"
	<linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-kernel@vger.kernel.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"Mika Penttilä"
	<mika.penttila-MRsr7dthA9VWk0Htik3J/w@public.gmane.org>,
	"Dan Williams"
	<dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH v2 1/2] x86/efi: don't allocate memmap through memblock after mm_init()
Date: Thu, 05 Jan 2017 13:53:50 +0100	[thread overview]
Message-ID: <87pok1hdlt.fsf@gmail.com> (raw)
In-Reply-To: <CAKv+Gu-KEJ3t5kqedbcmkagyxHusuvj2whc5zLY521tRtenUBg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> (Ard Biesheuvel's message of "Thu, 5 Jan 2017 11:34:06 +0000")

Ard Biesheuvel <ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> writes:
> On 5 January 2017 at 10:15, Nicolai Stange <nicstange-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>> So, are you Ok with only taking the other review comment, namely
>>
>>   "modify efi_fake_memmap() to use your new efi_memmap_alloc() function
>>    for consistency"
>>
>> into account for a v3?
>>
>
> Yes, that should be sufficient for a fix that can be backported.
> Anything else can wait for now


Ard, thanks for your help!

v3 is here:

  http://lkml.kernel.org/r/20170105125130.2815-1-nicstange-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org


Nicolai

WARNING: multiple messages have this Message-ID (diff)
From: Nicolai Stange <nicstange@gmail.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: "Nicolai Stange" <nicstange@gmail.com>,
	"Ingo Molnar" <mingo@kernel.org>,
	"Matt Fleming" <matt@codeblueprint.co.uk>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Ingo Molnar" <mingo@redhat.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	"x86@kernel.org" <x86@kernel.org>,
	"linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Mika Penttilä" <mika.penttila@nextfour.com>,
	"Dan Williams" <dan.j.williams@intel.com>
Subject: Re: [PATCH v2 1/2] x86/efi: don't allocate memmap through memblock after mm_init()
Date: Thu, 05 Jan 2017 13:53:50 +0100	[thread overview]
Message-ID: <87pok1hdlt.fsf@gmail.com> (raw)
In-Reply-To: <CAKv+Gu-KEJ3t5kqedbcmkagyxHusuvj2whc5zLY521tRtenUBg@mail.gmail.com> (Ard Biesheuvel's message of "Thu, 5 Jan 2017 11:34:06 +0000")

Ard Biesheuvel <ard.biesheuvel@linaro.org> writes:
> On 5 January 2017 at 10:15, Nicolai Stange <nicstange@gmail.com> wrote:
>> So, are you Ok with only taking the other review comment, namely
>>
>>   "modify efi_fake_memmap() to use your new efi_memmap_alloc() function
>>    for consistency"
>>
>> into account for a v3?
>>
>
> Yes, that should be sufficient for a fix that can be backported.
> Anything else can wait for now


Ard, thanks for your help!

v3 is here:

  http://lkml.kernel.org/r/20170105125130.2815-1-nicstange@gmail.com


Nicolai

  parent reply	other threads:[~2017-01-05 12:53 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-22 10:23 [PATCH v2 1/2] x86/efi: don't allocate memmap through memblock after mm_init() Nicolai Stange
2016-12-22 10:23 ` Nicolai Stange
2016-12-22 10:23 ` [PATCH v2 2/2] efi: efi_mem_reserve(): don't reserve " Nicolai Stange
     [not found]   ` <20161222102340.2689-2-nicstange-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-01-05  9:12     ` Dave Young
2017-01-05  9:12       ` Dave Young
2017-01-09 11:44       ` Matt Fleming
2017-01-09 11:44         ` Matt Fleming
2017-01-09 13:31         ` Mel Gorman
2017-01-09 13:31           ` Mel Gorman
2017-01-09 13:45           ` Matt Fleming
2017-01-09 13:45             ` Matt Fleming
2017-02-27 21:57           ` Matt Fleming
2017-02-27 21:57             ` Matt Fleming
2017-02-27 21:57             ` Matt Fleming
2017-01-10  0:37         ` Dave Young
2017-01-10  0:37           ` Dave Young
2017-01-10 12:51           ` Matt Fleming
2017-01-10 12:51             ` Matt Fleming
2017-01-11  8:04             ` Dave Young
2017-01-11  8:04               ` Dave Young
2016-12-23 14:52 ` [PATCH v2 1/2] x86/efi: don't allocate memmap " Matt Fleming
2016-12-23 21:12   ` Nicolai Stange
     [not found]     ` <878tr6jqoa.fsf-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-01-05  7:42       ` Ingo Molnar
2017-01-05  7:42         ` Ingo Molnar
     [not found]         ` <20170105074221.GA1777-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-01-05  9:15           ` Dave Young
2017-01-05  9:15             ` Dave Young
2017-01-05  9:39         ` Ard Biesheuvel
     [not found]           ` <CAKv+Gu9AabgVMQ+uZkmiJZt9shBB=j4XUccRoRJcv5+T8X7eAw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-01-05 10:15             ` Nicolai Stange
2017-01-05 10:15               ` Nicolai Stange
     [not found]               ` <87inpt6ce7.fsf-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-01-05 11:34                 ` Ard Biesheuvel
2017-01-05 11:34                   ` Ard Biesheuvel
     [not found]                   ` <CAKv+Gu-KEJ3t5kqedbcmkagyxHusuvj2whc5zLY521tRtenUBg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-01-05 12:53                     ` Nicolai Stange [this message]
2017-01-05 12:53                       ` Nicolai Stange
     [not found] ` <20161222102340.2689-1-nicstange-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-01-04 18:40   ` Dan Williams
2017-01-04 18:40     ` Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pok1hdlt.fsf@gmail.com \
    --to=nicstange-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org \
    --cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org \
    --cc=mika.penttila-MRsr7dthA9VWk0Htik3J/w@public.gmane.org \
    --cc=mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
    --cc=x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.