From: balbi@kernel.org (Felipe Balbi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] usb: dwc3: keystone: drop dma_mask configuration
Date: Mon, 04 Apr 2016 14:45:38 +0300 [thread overview]
Message-ID: <87pou561i5.fsf@intel.com> (raw)
In-Reply-To: <1459769611-16862-1-git-send-email-grygorii.strashko@ti.com>
Hi,
Grygorii Strashko <grygorii.strashko@ti.com> writes:
> The Keystone 2 supports DT-boot only, as result dma_mask will be
> always configured properly from DT -
> of_platform_device_create_pdata()->of_dma_configure(). More over,
> dwc3-keystone.c can be built as module and in this case it's unsafe to
> assign local variable as dma_mask.
>
> Hence, remove dma_mask configuration code.
>
> Cc: Murali Karicheri <m-karicheri2@ti.com>
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
with these two patches from you, does USB Peripheral work on k2 devices ?
I'll drop my k2 changes from my series which I sent on saturday.
--
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160404/e2b5dff0/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Felipe Balbi <balbi@kernel.org>
To: Grygorii Strashko <grygorii.strashko@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org
Cc: Roger Quadros <rogerq@ti.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, nsekhar@ti.com,
Grygorii Strashko <grygorii.strashko@ti.com>,
Murali Karicheri <m-karicheri2@ti.com>
Subject: Re: [PATCH] usb: dwc3: keystone: drop dma_mask configuration
Date: Mon, 04 Apr 2016 14:45:38 +0300 [thread overview]
Message-ID: <87pou561i5.fsf@intel.com> (raw)
In-Reply-To: <1459769611-16862-1-git-send-email-grygorii.strashko@ti.com>
[-- Attachment #1: Type: text/plain, Size: 672 bytes --]
Hi,
Grygorii Strashko <grygorii.strashko@ti.com> writes:
> The Keystone 2 supports DT-boot only, as result dma_mask will be
> always configured properly from DT -
> of_platform_device_create_pdata()->of_dma_configure(). More over,
> dwc3-keystone.c can be built as module and in this case it's unsafe to
> assign local variable as dma_mask.
>
> Hence, remove dma_mask configuration code.
>
> Cc: Murali Karicheri <m-karicheri2@ti.com>
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
with these two patches from you, does USB Peripheral work on k2 devices ?
I'll drop my k2 changes from my series which I sent on saturday.
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
next prev parent reply other threads:[~2016-04-04 11:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-04 11:33 [PATCH] usb: dwc3: keystone: drop dma_mask configuration Grygorii Strashko
2016-04-04 11:33 ` Grygorii Strashko
2016-04-04 11:45 ` Felipe Balbi [this message]
2016-04-04 11:45 ` Felipe Balbi
2016-04-04 13:41 ` Grygorii Strashko
2016-04-04 13:41 ` Grygorii Strashko
2016-04-05 5:19 ` Felipe Balbi
2016-04-05 5:19 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pou561i5.fsf@intel.com \
--to=balbi@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.