* [PATCH] drm/i915: fix sparse warning for using false as NULL
@ 2016-03-16 16:06 Jani Nikula
2016-03-16 16:14 ` Jani Nikula
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Jani Nikula @ 2016-03-16 16:06 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
drivers/gpu/drm/i915/intel_dpll_mgr.c:1200:32: warning: Using plain integer as NULL pointer
Fixes: 304b65cbdc8d ("drm/i915: Move SKL/KLB pll selection logic to intel_dpll_mgr.c")
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/intel_dpll_mgr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_dpll_mgr.c b/drivers/gpu/drm/i915/intel_dpll_mgr.c
index 74d5aecc0be5..e53d57c39056 100644
--- a/drivers/gpu/drm/i915/intel_dpll_mgr.c
+++ b/drivers/gpu/drm/i915/intel_dpll_mgr.c
@@ -1197,7 +1197,7 @@ skl_get_dpll(struct intel_crtc *crtc, struct intel_crtc_state *crtc_state,
ctrl1 |= DPLL_CTRL1_HDMI_MODE(0);
if (!skl_ddi_calculate_wrpll(clock * 1000, &wrpll_params))
- return false;
+ return NULL;
cfgcr1 = DPLL_CFGCR1_FREQ_ENABLE |
DPLL_CFGCR1_DCO_FRACTION(wrpll_params.dco_fraction) |
--
2.1.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915: fix sparse warning for using false as NULL
2016-03-16 16:06 [PATCH] drm/i915: fix sparse warning for using false as NULL Jani Nikula
@ 2016-03-16 16:14 ` Jani Nikula
2016-03-16 16:16 ` Ville Syrjälä
2016-03-17 8:01 ` ✗ Fi.CI.BAT: failure for " Patchwork
2 siblings, 0 replies; 5+ messages in thread
From: Jani Nikula @ 2016-03-16 16:14 UTC (permalink / raw)
To: intel-gfx; +Cc: Conselvan De Oliveira, Ander
On Wed, 16 Mar 2016, Jani Nikula <jani.nikula@intel.com> wrote:
> drivers/gpu/drm/i915/intel_dpll_mgr.c:1200:32: warning: Using plain integer as NULL pointer
>
> Fixes: 304b65cbdc8d ("drm/i915: Move SKL/KLB pll selection logic to intel_dpll_mgr.c")
Forgot to Cc: Ander on this one.
BR,
Jani.
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/intel_dpll_mgr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dpll_mgr.c b/drivers/gpu/drm/i915/intel_dpll_mgr.c
> index 74d5aecc0be5..e53d57c39056 100644
> --- a/drivers/gpu/drm/i915/intel_dpll_mgr.c
> +++ b/drivers/gpu/drm/i915/intel_dpll_mgr.c
> @@ -1197,7 +1197,7 @@ skl_get_dpll(struct intel_crtc *crtc, struct intel_crtc_state *crtc_state,
> ctrl1 |= DPLL_CTRL1_HDMI_MODE(0);
>
> if (!skl_ddi_calculate_wrpll(clock * 1000, &wrpll_params))
> - return false;
> + return NULL;
>
> cfgcr1 = DPLL_CFGCR1_FREQ_ENABLE |
> DPLL_CFGCR1_DCO_FRACTION(wrpll_params.dco_fraction) |
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915: fix sparse warning for using false as NULL
2016-03-16 16:06 [PATCH] drm/i915: fix sparse warning for using false as NULL Jani Nikula
2016-03-16 16:14 ` Jani Nikula
@ 2016-03-16 16:16 ` Ville Syrjälä
2016-03-17 9:35 ` Jani Nikula
2016-03-17 8:01 ` ✗ Fi.CI.BAT: failure for " Patchwork
2 siblings, 1 reply; 5+ messages in thread
From: Ville Syrjälä @ 2016-03-16 16:16 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
On Wed, Mar 16, 2016 at 06:06:58PM +0200, Jani Nikula wrote:
> drivers/gpu/drm/i915/intel_dpll_mgr.c:1200:32: warning: Using plain integer as NULL pointer
>
> Fixes: 304b65cbdc8d ("drm/i915: Move SKL/KLB pll selection logic to intel_dpll_mgr.c")
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_dpll_mgr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dpll_mgr.c b/drivers/gpu/drm/i915/intel_dpll_mgr.c
> index 74d5aecc0be5..e53d57c39056 100644
> --- a/drivers/gpu/drm/i915/intel_dpll_mgr.c
> +++ b/drivers/gpu/drm/i915/intel_dpll_mgr.c
> @@ -1197,7 +1197,7 @@ skl_get_dpll(struct intel_crtc *crtc, struct intel_crtc_state *crtc_state,
> ctrl1 |= DPLL_CTRL1_HDMI_MODE(0);
>
> if (!skl_ddi_calculate_wrpll(clock * 1000, &wrpll_params))
> - return false;
> + return NULL;
>
> cfgcr1 = DPLL_CFGCR1_FREQ_ENABLE |
> DPLL_CFGCR1_DCO_FRACTION(wrpll_params.dco_fraction) |
> --
> 2.1.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* ✗ Fi.CI.BAT: failure for drm/i915: fix sparse warning for using false as NULL
2016-03-16 16:06 [PATCH] drm/i915: fix sparse warning for using false as NULL Jani Nikula
2016-03-16 16:14 ` Jani Nikula
2016-03-16 16:16 ` Ville Syrjälä
@ 2016-03-17 8:01 ` Patchwork
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2016-03-17 8:01 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: fix sparse warning for using false as NULL
URL : https://patchwork.freedesktop.org/series/4528/
State : failure
== Summary ==
Series 4528v1 drm/i915: fix sparse warning for using false as NULL
http://patchwork.freedesktop.org/api/1.0/series/4528/revisions/1/mbox/
Test drv_module_reload_basic:
pass -> SKIP (bdw-ultra)
Test kms_flip:
Subgroup basic-flip-vs-modeset:
pass -> DMESG-WARN (bdw-nuci7)
Subgroup basic-flip-vs-wf_vblank:
dmesg-warn -> PASS (hsw-brixbox)
Subgroup basic-plain-flip:
dmesg-warn -> PASS (hsw-gt2)
Test kms_pipe_crc_basic:
Subgroup nonblocking-crc-pipe-a:
dmesg-warn -> PASS (snb-x220t)
Subgroup read-crc-pipe-a-frame-sequence:
pass -> DMESG-WARN (hsw-gt2)
bdw-nuci7 total:194 pass:181 dwarn:1 dfail:0 fail:0 skip:12
bdw-ultra total:194 pass:172 dwarn:0 dfail:0 fail:0 skip:22
byt-nuc total:194 pass:155 dwarn:4 dfail:0 fail:0 skip:35
hsw-brixbox total:194 pass:172 dwarn:0 dfail:0 fail:0 skip:22
hsw-gt2 total:194 pass:175 dwarn:2 dfail:0 fail:0 skip:17
ivb-t430s total:194 pass:169 dwarn:0 dfail:0 fail:0 skip:25
skl-i5k-2 total:194 pass:171 dwarn:0 dfail:0 fail:0 skip:23
skl-i7k-2 total:194 pass:171 dwarn:0 dfail:0 fail:0 skip:23
skl-nuci5 total:194 pass:183 dwarn:0 dfail:0 fail:0 skip:11
snb-x220t total:194 pass:160 dwarn:0 dfail:1 fail:0 skip:33
Results at /archive/results/CI_IGT_test/Patchwork_1621/
dbbc6d276864d7b7a3a1edb04f0511153f9c3852 drm-intel-nightly: 2016y-03m-16d-22h-27m-36s UTC integration manifest
cd5b3d217902d89f9d48ca773955612bbf9b2577 drm/i915: fix sparse warning for using false as NULL
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915: fix sparse warning for using false as NULL
2016-03-16 16:16 ` Ville Syrjälä
@ 2016-03-17 9:35 ` Jani Nikula
0 siblings, 0 replies; 5+ messages in thread
From: Jani Nikula @ 2016-03-17 9:35 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
On Wed, 16 Mar 2016, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Wed, Mar 16, 2016 at 06:06:58PM +0200, Jani Nikula wrote:
>> drivers/gpu/drm/i915/intel_dpll_mgr.c:1200:32: warning: Using plain integer as NULL pointer
>>
>> Fixes: 304b65cbdc8d ("drm/i915: Move SKL/KLB pll selection logic to intel_dpll_mgr.c")
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Pushed to drm-intel-next-queued, thanks for the review. The CI fails are
unrelated.
BR,
Jani.
>
>> ---
>> drivers/gpu/drm/i915/intel_dpll_mgr.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_dpll_mgr.c b/drivers/gpu/drm/i915/intel_dpll_mgr.c
>> index 74d5aecc0be5..e53d57c39056 100644
>> --- a/drivers/gpu/drm/i915/intel_dpll_mgr.c
>> +++ b/drivers/gpu/drm/i915/intel_dpll_mgr.c
>> @@ -1197,7 +1197,7 @@ skl_get_dpll(struct intel_crtc *crtc, struct intel_crtc_state *crtc_state,
>> ctrl1 |= DPLL_CTRL1_HDMI_MODE(0);
>>
>> if (!skl_ddi_calculate_wrpll(clock * 1000, &wrpll_params))
>> - return false;
>> + return NULL;
>>
>> cfgcr1 = DPLL_CFGCR1_FREQ_ENABLE |
>> DPLL_CFGCR1_DCO_FRACTION(wrpll_params.dco_fraction) |
>> --
>> 2.1.4
>>
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-03-17 9:35 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-16 16:06 [PATCH] drm/i915: fix sparse warning for using false as NULL Jani Nikula
2016-03-16 16:14 ` Jani Nikula
2016-03-16 16:16 ` Ville Syrjälä
2016-03-17 9:35 ` Jani Nikula
2016-03-17 8:01 ` ✗ Fi.CI.BAT: failure for " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.