Re: [PATCH v2 0/6] drm/i915: start hiding away vbt structure from the driver

[Jani Nikula <jani.nikula@intel.com>]

On Mon, 11 Jan 2016, Lukas Wunner <lukas@wunner.de> wrote:
> Hi,
>
> On Mon, Jan 11, 2016 at 09:54:36PM +0200, Jani Nikula wrote:
>> Hi all, first real patches since the RFC at [1].
>> 
>> The VBT is a monster and it keeps growing. Originally we've extracted
>> bits and pieces out of there, and added them cleanly to our own
>> structures in dev_priv->vbt, with our own macros. Later on we've been
>> slipping and we have copied stuff from VBT verbatim, using the same
>> structs and defines as in VBT.
>
> There's also code spread out across the driver to sanitize VBT data, e.g.:
> http://cgit.freedesktop.org/drm-intel/tree/drivers/gpu/drm/i915/intel_display.c?h=drm-intel-nightly#n15424
>
> (cf. 69f92f67b68a, "drm/i915: Preserve SSC earlier")
>
> Would probably make sense to consolidate that in intel_bios.c as well.

It's worth noting that there's no mmio register access in
intel_bios.c. It's just about parsing the VBT. I'd prefer to keep it
that way.

BR,
Jani.



>
> Best regards,
>
> Lukas
>
>> 
>> Start abstracting the VBT more, hiding away the VBT specific stuff that
>> should not be fiddled with outside of intel_bios.c. Make it more
>> explicit when we're doing so. At this stage, mostly just fork the
>> private parts into intel_bios_private.h. As prep work, move some stuff
>> to intel_bios.c to limit the amount of macros needing to be exposed
>> across the whole driver.
>> 
>> With the MIPI DSI VBT stuff out of the way, this now applies on top of
>> nightly.
>> 
>> 
>> BR,
>> Jani.
>> 
>> [1] http://mid.gmane.org/cover.1450192823.git.jani.nikula@intel.com
>> 
>> 
>> Jani Nikula (6):
>>   drm/i915: move VBT based TV presence check to intel_bios.c
>>   drm/i915: move VBT based LVDS presence check to intel_bios.c
>>   drm/i915: move VBT based eDP port check to intel_bios.c
>>   drm/i915: move VBT based DSI presence check to intel_bios.c
>>   drm/i915/panel: setup pwm backlight based on connector type
>>   drm/i915: hide away VBT private data in a separate header
>> 
>>  Documentation/DocBook/gpu.tmpl            |   2 +-
>>  drivers/gpu/drm/i915/i915_drv.h           |   5 +-
>>  drivers/gpu/drm/i915/intel_bios.c         | 156 +++++-
>>  drivers/gpu/drm/i915/intel_bios.h         | 860 ++----------------------------
>>  drivers/gpu/drm/i915/intel_bios_private.h | 823 ++++++++++++++++++++++++++++
>>  drivers/gpu/drm/i915/intel_dp.c           |  21 +-
>>  drivers/gpu/drm/i915/intel_dsi.c          |  23 +-
>>  drivers/gpu/drm/i915/intel_lvds.c         |  53 +-
>>  drivers/gpu/drm/i915/intel_panel.c        |   2 +-
>>  drivers/gpu/drm/i915/intel_tv.c           |  43 +-
>>  10 files changed, 1034 insertions(+), 954 deletions(-)
>>  create mode 100644 drivers/gpu/drm/i915/intel_bios_private.h
>> 
>> -- 
>> 2.1.4
>> 
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx