From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [PATCH 1/3] ath10k: embed supported chip ids in hw_params
Date: Thu, 27 Nov 2014 09:30:09 +0200 [thread overview]
Message-ID: <87ppc9umm6.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <CA+BoTQ=56six2CEQ6Rzr7yMEM7UVNQ3RX9UpdgmxMEoG0+kDAA@mail.gmail.com> (Michal Kazior's message of "Wed, 26 Nov 2014 08:54:30 +0100")
Michal Kazior <michal.kazior@tieto.com> writes:
> 2. Have a dedicatd pci-specific structure:
>
> struct ath10k_pci_supported_chip {
> u16 dev_id;
> u32 chip_id;
> };
>
> struct ath10k_pci_supported_chip ath10k_pci_supported_chips[] = {
> { QCA988X_2_0_DEVICE_ID, QCA988X_HW_2_0_CHIP_ID_REV },
> // ...
> };
>
> Probably the simplest and has least impact.
Another idea which is a variation of this:
In ath10k_core_register() we iterate through ath10k_hw_params_list and
make sure that the chip id is supported and if not, bail out. If the
chip id is found from the array continue the registration process like
in this patch. Basically this would be a whitelist check.
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: "ath10k@lists.infradead.org" <ath10k@lists.infradead.org>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 1/3] ath10k: embed supported chip ids in hw_params
Date: Thu, 27 Nov 2014 09:30:09 +0200 [thread overview]
Message-ID: <87ppc9umm6.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <CA+BoTQ=56six2CEQ6Rzr7yMEM7UVNQ3RX9UpdgmxMEoG0+kDAA@mail.gmail.com> (Michal Kazior's message of "Wed, 26 Nov 2014 08:54:30 +0100")
Michal Kazior <michal.kazior@tieto.com> writes:
> 2. Have a dedicatd pci-specific structure:
>
> struct ath10k_pci_supported_chip {
> u16 dev_id;
> u32 chip_id;
> };
>
> struct ath10k_pci_supported_chip ath10k_pci_supported_chips[] = {
> { QCA988X_2_0_DEVICE_ID, QCA988X_HW_2_0_CHIP_ID_REV },
> // ...
> };
>
> Probably the simplest and has least impact.
Another idea which is a variation of this:
In ath10k_core_register() we iterate through ath10k_hw_params_list and
make sure that the chip id is supported and if not, bail out. If the
chip id is found from the array continue the registration process like
in this patch. Basically this would be a whitelist check.
--
Kalle Valo
next prev parent reply other threads:[~2014-11-27 7:30 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-24 14:17 [PATCH 1/3] ath10k: embed supported chip ids in hw_params Michal Kazior
2014-11-24 14:17 ` Michal Kazior
2014-11-24 14:17 ` [PATCH 2/3] ath10k: put board size into hw_params Michal Kazior
2014-11-24 14:17 ` Michal Kazior
2014-11-24 14:17 ` [PATCH 3/3] ath10k: move uart pin config " Michal Kazior
2014-11-24 14:17 ` Michal Kazior
2014-11-26 7:21 ` [PATCH 1/3] ath10k: embed supported chip ids in hw_params Kalle Valo
2014-11-26 7:21 ` Kalle Valo
2014-11-26 7:54 ` Michal Kazior
2014-11-26 7:54 ` Michal Kazior
2014-11-27 7:30 ` Kalle Valo [this message]
2014-11-27 7:30 ` Kalle Valo
2014-11-27 7:45 ` Michal Kazior
2014-11-27 7:45 ` Michal Kazior
2014-11-28 7:02 ` Kalle Valo
2014-11-28 7:02 ` Kalle Valo
2014-11-28 7:10 ` Kalle Valo
2014-11-28 7:10 ` Kalle Valo
2014-11-28 11:25 ` Michal Kazior
2014-11-28 11:25 ` Michal Kazior
2014-12-01 7:17 ` [PATCH v2 1/3] ath10k: create a chip revision whielist Michal Kazior
2014-12-01 7:17 ` Michal Kazior
2014-12-01 7:17 ` [PATCH v2 2/3] ath10k: put board size into hw_params Michal Kazior
2014-12-01 7:17 ` Michal Kazior
2014-12-01 7:17 ` [PATCH v2 3/3] ath10k: move uart pin config " Michal Kazior
2014-12-01 7:17 ` Michal Kazior
2014-12-01 7:47 ` [PATCH v2 1/3] ath10k: create a chip revision whielist Kalle Valo
2014-12-01 7:47 ` Kalle Valo
2014-12-01 8:35 ` Michal Kazior
2014-12-01 8:35 ` Michal Kazior
2014-12-08 15:35 ` Kalle Valo
2014-12-08 15:35 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ppc9umm6.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.