Re: [Qemu-devel] [RFC 2/3] image-fuzzer: Initial generator of qcow2 fuzzed images

[Markus Armbruster <armbru@redhat.com>]

Eric Blake <eblake@redhat.com> writes:

> On 06/18/2014 09:29 AM, Maria Kustova wrote:
>> Qcow2 image generator is a python package providing create_image(img_path)
>> method required by the test runner.
>> It generates files containing fuzzed qcow2 image headers. Files are randomly
>> variable not only in fuzzed fields but in valid structure elements like image
>> and cluster size.
>> 
>> Signed-off-by: Maria Kustova <maria.k@catit.be>
>> ---
>>  tests/image-fuzzer/qcow2/__init__.py |   1 +
>>  tests/image-fuzzer/qcow2/fuzz.py | 271
>> +++++++++++++++++++++++++++++++++++
>>  tests/image-fuzzer/qcow2/layout.py   | 125 ++++++++++++++++
>>  3 files changed, 397 insertions(+)
>>  create mode 100644 tests/image-fuzzer/qcow2/__init__.py
>>  create mode 100644 tests/image-fuzzer/qcow2/fuzz.py
>>  create mode 100644 tests/image-fuzzer/qcow2/layout.py
>> 
>> diff --git a/tests/image-fuzzer/qcow2/__init__.py
>> b/tests/image-fuzzer/qcow2/__init__.py
>> new file mode 100644
>> index 0000000..e2ebe19
>> --- /dev/null
>> +++ b/tests/image-fuzzer/qcow2/__init__.py
>> @@ -0,0 +1 @@
>> +from layout import create_image
>> diff --git a/tests/image-fuzzer/qcow2/fuzz.py
>> b/tests/image-fuzzer/qcow2/fuzz.py
>> new file mode 100644
>> index 0000000..214dd7c
>> --- /dev/null
>> +++ b/tests/image-fuzzer/qcow2/fuzz.py
>> @@ -0,0 +1,271 @@
>> +# Fuzzing functions for qcow2 fields
>> +#
>> +# Copyright (C) 2014 Maria Kustova <maria.k@catit.be>
>> +#
>> +# This program is free software: you can redistribute it and/or modify
>> +# it under the terms of the GNU General Public License as published by
>> +# the Free Software Foundation, either version 3 of the License, or
>> +# (at your option) any later version.
>
> Won't work.  Qemu HAS to ship as GPLv2 because it contains some
> GPLv2-only code; GPLv3+ is incompatible with GPLv2.  You'll need to
> relax your license (GPLv2+ is ideal, but anything even looser, such as
> LGPLv2+ or BSD also works).

Please use GPLv2+ for new QEMU code, unless you have a really good
reason for something else, and can explain it.