From: Juan Quintela <quintela@redhat.com>
To: Amit Shah <amit.shah@redhat.com>
Cc: "qemu list" <qemu-devel@nongnu.org>,
"Markus Armbruster" <armbru@redhat.com>,
"Alexander Graf" <agraf@suse.de>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH v4 01/18] migration: dump vmstate info as a json file for static analysis
Date: Wed, 18 Jun 2014 12:56:54 +0200 [thread overview]
Message-ID: <87ppi6qydl.fsf@troll.troll> (raw)
In-Reply-To: <20140618103649.GK29732@grmbl.mre> (Amit Shah's message of "Wed, 18 Jun 2014 16:06:49 +0530")
Amit Shah <amit.shah@redhat.com> wrote:
>>
>> You can print always \n now, right?
>
> There's also a , there...
>
> This sequence was added recently (v2 onwards) for the ignoring of the
> VMS_MUST_EXIST stuff.
I knew it needed to be some reason for the ugliness :-()
>> Same for the other places? Or I am missing something.
>>
>> I will even go that itwould be better to just left the \n on the (*),
>> and just add this \n at the end of writing a subsection.
>>
>>
>> > + fprintf(out_file, "\n%*s}", indent - 2, "");
>>
>> And you remove it from here.
>
> I tried several things with the \n; the current setting is the best I
> found.
>
> Of course, this is just pretty-printing, so I don't actually remember
> all the details but I can look it up my git tree...
ok, I retire the comment, and anyways, it is trivial to fix
incrementally if you/anybody came with a clever idea.
Reviewed-by: Juan Quintela <quintela@redhat.com>
next prev parent reply other threads:[~2014-06-18 10:57 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-18 8:13 [Qemu-devel] [PATCH v4 00/18] migration: add static analysis tool to check vmstate compat Amit Shah
2014-06-18 8:13 ` [Qemu-devel] [PATCH v4 01/18] migration: dump vmstate info as a json file for static analysis Amit Shah
2014-06-18 10:24 ` Juan Quintela
2014-06-18 10:36 ` Amit Shah
2014-06-18 10:56 ` Juan Quintela [this message]
2014-06-18 8:13 ` [Qemu-devel] [PATCH v4 02/18] vmstate-static-checker: script to validate vmstate changes Amit Shah
2014-06-18 10:44 ` Juan Quintela
2014-06-18 10:58 ` Amit Shah
2014-06-18 11:25 ` Juan Quintela
2014-06-18 11:32 ` Amit Shah
2014-06-18 8:13 ` [Qemu-devel] [PATCH v4 03/18] tests: vmstate static checker: add dump1 and dump2 files Amit Shah
2014-06-18 10:33 ` Juan Quintela
2014-06-18 8:13 ` [Qemu-devel] [PATCH v4 04/18] tests: vmstate static checker: incompat machine types Amit Shah
2014-06-18 10:33 ` Juan Quintela
2014-06-18 8:13 ` [Qemu-devel] [PATCH v4 05/18] tests: vmstate static checker: add version error in main section Amit Shah
2014-06-18 10:33 ` Juan Quintela
2014-06-18 8:13 ` [Qemu-devel] [PATCH v4 06/18] tests: vmstate static checker: version mismatch inside a Description Amit Shah
2014-06-18 10:34 ` Juan Quintela
2014-06-18 8:13 ` [Qemu-devel] [PATCH v4 07/18] tests: vmstate static checker: minimum_version_id check Amit Shah
2014-06-18 10:34 ` Juan Quintela
2014-06-18 8:13 ` [Qemu-devel] [PATCH v4 08/18] tests: vmstate static checker: remove a section Amit Shah
2014-06-18 10:35 ` Juan Quintela
2014-06-18 8:13 ` [Qemu-devel] [PATCH v4 09/18] tests: vmstate static checker: remove a field Amit Shah
2014-06-18 10:35 ` Juan Quintela
2014-06-18 8:13 ` [Qemu-devel] [PATCH v4 10/18] tests: vmstate static checker: remove last field in a struct Amit Shah
2014-06-18 10:36 ` Juan Quintela
2014-06-18 8:13 ` [Qemu-devel] [PATCH v4 11/18] tests: vmstate static checker: change description name Amit Shah
2014-06-18 10:36 ` Juan Quintela
2014-06-18 8:13 ` [Qemu-devel] [PATCH v4 12/18] tests: vmstate static checker: remove Fields Amit Shah
2014-06-18 10:36 ` Juan Quintela
2014-06-18 8:13 ` [Qemu-devel] [PATCH v4 13/18] tests: vmstate static checker: remove Description Amit Shah
2014-06-18 10:37 ` Juan Quintela
2014-06-18 8:13 ` [Qemu-devel] [PATCH v4 14/18] tests: vmstate static checker: remove Description inside Fields Amit Shah
2014-06-18 10:37 ` Juan Quintela
2014-06-18 8:13 ` [Qemu-devel] [PATCH v4 15/18] tests: vmstate static checker: remove a subsection Amit Shah
2014-06-18 10:37 ` Juan Quintela
2014-06-18 8:13 ` [Qemu-devel] [PATCH v4 16/18] tests: vmstate static checker: remove Subsections Amit Shah
2014-06-18 10:38 ` Juan Quintela
2014-06-18 8:13 ` [Qemu-devel] [PATCH v4 17/18] tests: vmstate static checker: add substructure for usb-kbd for hid section Amit Shah
2014-06-18 10:38 ` Juan Quintela
2014-06-18 8:13 ` [Qemu-devel] [PATCH v4 18/18] tests: vmstate static checker: add size mismatch inside substructure Amit Shah
2014-06-18 10:38 ` Juan Quintela
2014-06-18 10:49 ` [Qemu-devel] [PATCH v4 00/18] migration: add static analysis tool to check vmstate compat Juan Quintela
2014-06-18 11:02 ` Amit Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ppi6qydl.fsf@troll.troll \
--to=quintela@redhat.com \
--cc=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=amit.shah@redhat.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.