Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/3] spapr: add uuid/host details to device tree

[Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>]

Alexey Kardashevskiy <aik@ozlabs.ru> writes:

> On 06/10/2014 05:56 PM, Nikunj A Dadhania wrote:
>> Useful for identifying the guest/host uniquely within the
>> guest. Adding following properties to the guest root node.
>> 
>> vm,uuid - uuid of the guest
>> host-model - Host model number
>> host-serial - Host machine serial number
>> hypervisor type - Tells its "kvm"
>> 
>> Signed-off-by: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>
>> ---
>>  hw/ppc/spapr.c       | 19 +++++++++++++++++++
>>  target-ppc/kvm.c     | 42 ++++++++++++++++++++++++++++++++++++++++++
>>  target-ppc/kvm_ppc.h | 12 ++++++++++++
>>  3 files changed, 73 insertions(+)
>> 
>> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
>> index 57e9578..ff37319 100644
>> --- a/hw/ppc/spapr.c
>> +++ b/hw/ppc/spapr.c
>> @@ -313,6 +313,7 @@ static void *spapr_create_fdt_skel(hwaddr initrd_base,
>>      uint32_t interrupt_server_ranges_prop[] = {0, cpu_to_be32(smp_cpus)};
>>      int i, smt = kvmppc_smt_threads();
>>      unsigned char vec5[] = {0x0, 0x0, 0x0, 0x0, 0x0, 0x80};
>> +    char char_buf[512];
>>  
>>      fdt = g_malloc0(FDT_MAX_SIZE);
>>      _FDT((fdt_create(fdt, FDT_MAX_SIZE)));
>> @@ -331,6 +332,24 @@ static void *spapr_create_fdt_skel(hwaddr initrd_base,
>>      _FDT((fdt_property_string(fdt, "model", "IBM pSeries (emulated by qemu)")));
>>      _FDT((fdt_property_string(fdt, "compatible", "qemu,pseries")));
>>  
>> +    if(kvm_enabled()) {
>
> s/if/if / here and after.
>
> You did not run checkpatch.pl, did you? :)

Nope, will fix it.

Nikunj