Re: [PATCH 1/3] drm/dp: make aux retries less chatty

[Jani Nikula <jani.nikula@linux.intel.com>]

On Tue, 18 Mar 2014, Alex Deucher <alexdeucher@gmail.com> wrote:
> Switch to debug only to avoid flooding the logs.
> This mirrors the behavior in some other drivers.

I'd rather think we should find out why the DP devices are replying with
repeated native or i2c-over-aux defers. This doesn't help; I'm not in
favour.

BR,
Jani.


>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> ---
>  drivers/gpu/drm/drm_dp_helper.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c
> index 35251af..74724aa 100644
> --- a/drivers/gpu/drm/drm_dp_helper.c
> +++ b/drivers/gpu/drm/drm_dp_helper.c
> @@ -402,7 +402,7 @@ static int drm_dp_dpcd_access(struct drm_dp_aux *aux, u8 request,
>  		}
>  	}
>  
> -	DRM_ERROR("too many retries, giving up\n");
> +	DRM_DEBUG_KMS("too many retries, giving up\n");
>  	return -EIO;
>  }
>  
> @@ -656,7 +656,7 @@ static int drm_dp_i2c_do_msg(struct drm_dp_aux *aux, struct drm_dp_aux_msg *msg)
>  		}
>  	}
>  
> -	DRM_ERROR("too many retries, giving up\n");
> +	DRM_DEBUG_KMS("too many retries, giving up\n");
>  	return -EREMOTEIO;
>  }
>  
> -- 
> 1.8.3.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Jani Nikula, Intel Open Source Technology Center