All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: Marek Puzyniak <marek.puzyniak@tieto.com>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [PATCH] ath10k: change simulate_fw_crash to work with 10.1 firmware
Date: Thu, 13 Feb 2014 16:52:55 +0200	[thread overview]
Message-ID: <87ppmr83p4.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <CA+BoTQ=q-940AsMfneU5SP8Ke1RxEZE12rrm4Z+KBaTBjrW64w@mail.gmail.com> (Michal Kazior's message of "Tue, 11 Feb 2014 07:17:45 +0100")

Michal Kazior <michal.kazior@tieto.com> writes:

> On 10 February 2014 18:13, Marek Puzyniak <marek.puzyniak@tieto.com> wrote:
>> Wmi command WMI_FORCE_FW_HANG_CMDID is not supported
>> in firmware 10.1. In order to have firmware crash simulation
>> functionality also in firmware 10.1 driver can force firmware
>> crash by performing not allowed operation. Driver can deliberately
>> crash firmware when setting vdev param for vdev id out of range.
>>
>> Command to trigger firmware crash:
>> echo "crash" > /sys/kernel/debug/ieee80211/phyX/ath10k/simulate_fw_crash
>>
>> Signed-off-by: Marek Puzyniak <marek.puzyniak@tieto.com>
>> ---
>
> The 'fw hang assert' crash can be recovered with a warm reset but a
> real crash can't.

Oh, I didn't know that.

> Thus, I think the two crash methods should be distinguishable 

Yeah, I agree.

> by having either two separate debugfs files or two separate trigger
> keywords.

I think having a keyword would be a better to way differentiate these.
And if the firmware doesn't support WMI_FORCE_FW_HANG_ASSERT, then just
return -EOPNOTSUPP.

-- 
Kalle Valo

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: Marek Puzyniak <marek.puzyniak@tieto.com>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [PATCH] ath10k: change simulate_fw_crash to work with 10.1 firmware
Date: Thu, 13 Feb 2014 16:52:55 +0200	[thread overview]
Message-ID: <87ppmr83p4.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <CA+BoTQ=q-940AsMfneU5SP8Ke1RxEZE12rrm4Z+KBaTBjrW64w@mail.gmail.com> (Michal Kazior's message of "Tue, 11 Feb 2014 07:17:45 +0100")

Michal Kazior <michal.kazior@tieto.com> writes:

> On 10 February 2014 18:13, Marek Puzyniak <marek.puzyniak@tieto.com> wrote:
>> Wmi command WMI_FORCE_FW_HANG_CMDID is not supported
>> in firmware 10.1. In order to have firmware crash simulation
>> functionality also in firmware 10.1 driver can force firmware
>> crash by performing not allowed operation. Driver can deliberately
>> crash firmware when setting vdev param for vdev id out of range.
>>
>> Command to trigger firmware crash:
>> echo "crash" > /sys/kernel/debug/ieee80211/phyX/ath10k/simulate_fw_crash
>>
>> Signed-off-by: Marek Puzyniak <marek.puzyniak@tieto.com>
>> ---
>
> The 'fw hang assert' crash can be recovered with a warm reset but a
> real crash can't.

Oh, I didn't know that.

> Thus, I think the two crash methods should be distinguishable 

Yeah, I agree.

> by having either two separate debugfs files or two separate trigger
> keywords.

I think having a keyword would be a better to way differentiate these.
And if the firmware doesn't support WMI_FORCE_FW_HANG_ASSERT, then just
return -EOPNOTSUPP.

-- 
Kalle Valo

  reply	other threads:[~2014-02-13 14:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-10 17:13 [PATCH] ath10k: change simulate_fw_crash to work with 10.1 firmware Marek Puzyniak
2014-02-10 17:13 ` Marek Puzyniak
2014-02-11  6:17 ` Michal Kazior
2014-02-11  6:17   ` Michal Kazior
2014-02-13 14:52   ` Kalle Valo [this message]
2014-02-13 14:52     ` Kalle Valo
2014-02-13 15:08     ` Marek Puzyniak
2014-02-13 15:08       ` Marek Puzyniak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ppmr83p4.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@qca.qualcomm.com \
    --cc=ath10k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=marek.puzyniak@tieto.com \
    --cc=michal.kazior@tieto.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.