* [PATCH] virtio-mmio: Correct the name of the guest features selector
@ 2011-11-15 14:17 ` Sasha Levin
0 siblings, 0 replies; 6+ messages in thread
From: Sasha Levin @ 2011-11-15 14:17 UTC (permalink / raw)
To: linux-kernel; +Cc: Sasha Levin, Pawel Moll, virtualization
Guest features selector spelling mistake.
Cc: Pawel Moll <pawel.moll@arm.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>
Cc: virtualization@lists.linux-foundation.org
Signed-off-by: Sasha Levin <levinsasha928@gmail.com>
---
Hopefully not too late to fix, should possibly be done in one of the next RCs
since it's user facing.
include/linux/virtio_mmio.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/linux/virtio_mmio.h b/include/linux/virtio_mmio.h
index 27c7ede..5c7b6f0 100644
--- a/include/linux/virtio_mmio.h
+++ b/include/linux/virtio_mmio.h
@@ -63,7 +63,7 @@
#define VIRTIO_MMIO_GUEST_FEATURES 0x020
/* Activated features set selector - Write Only */
-#define VIRTIO_MMIO_GUEST_FEATURES_SET 0x024
+#define VIRTIO_MMIO_GUEST_FEATURES_SEL 0x024
/* Guest's memory page size in bytes - Write Only */
#define VIRTIO_MMIO_GUEST_PAGE_SIZE 0x028
--
1.7.8.rc1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] virtio-mmio: Correct the name of the guest features selector
@ 2011-11-15 14:17 ` Sasha Levin
0 siblings, 0 replies; 6+ messages in thread
From: Sasha Levin @ 2011-11-15 14:17 UTC (permalink / raw)
To: linux-kernel; +Cc: Sasha Levin, Pawel Moll, Rusty Russell, virtualization
Guest features selector spelling mistake.
Cc: Pawel Moll <pawel.moll@arm.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>
Cc: virtualization@lists.linux-foundation.org
Signed-off-by: Sasha Levin <levinsasha928@gmail.com>
---
Hopefully not too late to fix, should possibly be done in one of the next RCs
since it's user facing.
include/linux/virtio_mmio.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/linux/virtio_mmio.h b/include/linux/virtio_mmio.h
index 27c7ede..5c7b6f0 100644
--- a/include/linux/virtio_mmio.h
+++ b/include/linux/virtio_mmio.h
@@ -63,7 +63,7 @@
#define VIRTIO_MMIO_GUEST_FEATURES 0x020
/* Activated features set selector - Write Only */
-#define VIRTIO_MMIO_GUEST_FEATURES_SET 0x024
+#define VIRTIO_MMIO_GUEST_FEATURES_SEL 0x024
/* Guest's memory page size in bytes - Write Only */
#define VIRTIO_MMIO_GUEST_PAGE_SIZE 0x028
--
1.7.8.rc1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] virtio-mmio: Correct the name of the guest features selector
2011-11-15 14:17 ` Sasha Levin
(?)
@ 2011-11-15 14:25 ` Pawel Moll
2011-11-16 0:45 ` Rusty Russell
-1 siblings, 1 reply; 6+ messages in thread
From: Pawel Moll @ 2011-11-15 14:25 UTC (permalink / raw)
To: Sasha Levin
Cc: linux-kernel@vger.kernel.org, Rusty Russell,
virtualization@lists.linux-foundation.org
On Tue, 2011-11-15 at 14:17 +0000, Sasha Levin wrote:
> Guest features selector spelling mistake.
>
> diff --git a/include/linux/virtio_mmio.h b/include/linux/virtio_mmio.h
> index 27c7ede..5c7b6f0 100644
> --- a/include/linux/virtio_mmio.h
> +++ b/include/linux/virtio_mmio.h
> @@ -63,7 +63,7 @@
> #define VIRTIO_MMIO_GUEST_FEATURES 0x020
>
> /* Activated features set selector - Write Only */
> -#define VIRTIO_MMIO_GUEST_FEATURES_SET 0x024
> +#define VIRTIO_MMIO_GUEST_FEATURES_SEL 0x024
>
> /* Guest's memory page size in bytes - Write Only */
> #define VIRTIO_MMIO_GUEST_PAGE_SIZE 0x028
Damn. Sorry about it. But if you change the header you'll need to change
the driver:
diff --git a/drivers/virtio/virtio_mmio.c b/drivers/virtio/virtio_mmio.c
index 1f25bb9..10bb8b9 100644
--- a/drivers/virtio/virtio_mmio.c
+++ b/drivers/virtio/virtio_mmio.c
@@ -161,7 +161,7 @@ static void vm_finalize_features(struct virtio_device *vdev)
vring_transport_features(vdev);
for (i = 0; i < ARRAY_SIZE(vdev->features); i++) {
- writel(i, vm_dev->base + VIRTIO_MMIO_GUEST_FEATURES_SET);
+ writel(i, vm_dev->base + VIRTIO_MMIO_GUEST_FEATURES_SEL);
writel(vdev->features[i],
vm_dev->base + VIRTIO_MMIO_GUEST_FEATURES);
}
Cheers!
Paweł
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] virtio-mmio: Correct the name of the guest features selector
2011-11-15 14:25 ` Pawel Moll
@ 2011-11-16 0:45 ` Rusty Russell
0 siblings, 0 replies; 6+ messages in thread
From: Rusty Russell @ 2011-11-16 0:45 UTC (permalink / raw)
To: Pawel Moll, Sasha Levin
Cc: linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org
On Tue, 15 Nov 2011 14:25:22 +0000, Pawel Moll <pawel.moll@arm.com> wrote:
> On Tue, 2011-11-15 at 14:17 +0000, Sasha Levin wrote:
> > Guest features selector spelling mistake.
> >
> > diff --git a/include/linux/virtio_mmio.h b/include/linux/virtio_mmio.h
> > index 27c7ede..5c7b6f0 100644
> > --- a/include/linux/virtio_mmio.h
> > +++ b/include/linux/virtio_mmio.h
> > @@ -63,7 +63,7 @@
> > #define VIRTIO_MMIO_GUEST_FEATURES 0x020
> >
> > /* Activated features set selector - Write Only */
> > -#define VIRTIO_MMIO_GUEST_FEATURES_SET 0x024
> > +#define VIRTIO_MMIO_GUEST_FEATURES_SEL 0x024
> >
> > /* Guest's memory page size in bytes - Write Only */
> > #define VIRTIO_MMIO_GUEST_PAGE_SIZE 0x028
>
> Damn. Sorry about it. But if you change the header you'll need to change
> the driver:
>
> diff --git a/drivers/virtio/virtio_mmio.c b/drivers/virtio/virtio_mmio.c
> index 1f25bb9..10bb8b9 100644
> --- a/drivers/virtio/virtio_mmio.c
> +++ b/drivers/virtio/virtio_mmio.c
> @@ -161,7 +161,7 @@ static void vm_finalize_features(struct virtio_device *vdev)
> vring_transport_features(vdev);
>
> for (i = 0; i < ARRAY_SIZE(vdev->features); i++) {
> - writel(i, vm_dev->base + VIRTIO_MMIO_GUEST_FEATURES_SET);
> + writel(i, vm_dev->base + VIRTIO_MMIO_GUEST_FEATURES_SEL);
> writel(vdev->features[i],
> vm_dev->base + VIRTIO_MMIO_GUEST_FEATURES);
> }
Rolled together and applied.
Thanks,
Rusty.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] virtio-mmio: Correct the name of the guest features selector
@ 2011-11-16 0:45 ` Rusty Russell
0 siblings, 0 replies; 6+ messages in thread
From: Rusty Russell @ 2011-11-16 0:45 UTC (permalink / raw)
To: Pawel Moll, Sasha Levin
Cc: linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org
On Tue, 15 Nov 2011 14:25:22 +0000, Pawel Moll <pawel.moll@arm.com> wrote:
> On Tue, 2011-11-15 at 14:17 +0000, Sasha Levin wrote:
> > Guest features selector spelling mistake.
> >
> > diff --git a/include/linux/virtio_mmio.h b/include/linux/virtio_mmio.h
> > index 27c7ede..5c7b6f0 100644
> > --- a/include/linux/virtio_mmio.h
> > +++ b/include/linux/virtio_mmio.h
> > @@ -63,7 +63,7 @@
> > #define VIRTIO_MMIO_GUEST_FEATURES 0x020
> >
> > /* Activated features set selector - Write Only */
> > -#define VIRTIO_MMIO_GUEST_FEATURES_SET 0x024
> > +#define VIRTIO_MMIO_GUEST_FEATURES_SEL 0x024
> >
> > /* Guest's memory page size in bytes - Write Only */
> > #define VIRTIO_MMIO_GUEST_PAGE_SIZE 0x028
>
> Damn. Sorry about it. But if you change the header you'll need to change
> the driver:
>
> diff --git a/drivers/virtio/virtio_mmio.c b/drivers/virtio/virtio_mmio.c
> index 1f25bb9..10bb8b9 100644
> --- a/drivers/virtio/virtio_mmio.c
> +++ b/drivers/virtio/virtio_mmio.c
> @@ -161,7 +161,7 @@ static void vm_finalize_features(struct virtio_device *vdev)
> vring_transport_features(vdev);
>
> for (i = 0; i < ARRAY_SIZE(vdev->features); i++) {
> - writel(i, vm_dev->base + VIRTIO_MMIO_GUEST_FEATURES_SET);
> + writel(i, vm_dev->base + VIRTIO_MMIO_GUEST_FEATURES_SEL);
> writel(vdev->features[i],
> vm_dev->base + VIRTIO_MMIO_GUEST_FEATURES);
> }
Rolled together and applied.
Thanks,
Rusty.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] virtio-mmio: Correct the name of the guest features selector
2011-11-15 14:17 ` Sasha Levin
(?)
(?)
@ 2011-11-15 14:25 ` Pawel Moll
-1 siblings, 0 replies; 6+ messages in thread
From: Pawel Moll @ 2011-11-15 14:25 UTC (permalink / raw)
To: Sasha Levin
Cc: linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org
On Tue, 2011-11-15 at 14:17 +0000, Sasha Levin wrote:
> Guest features selector spelling mistake.
>
> diff --git a/include/linux/virtio_mmio.h b/include/linux/virtio_mmio.h
> index 27c7ede..5c7b6f0 100644
> --- a/include/linux/virtio_mmio.h
> +++ b/include/linux/virtio_mmio.h
> @@ -63,7 +63,7 @@
> #define VIRTIO_MMIO_GUEST_FEATURES 0x020
>
> /* Activated features set selector - Write Only */
> -#define VIRTIO_MMIO_GUEST_FEATURES_SET 0x024
> +#define VIRTIO_MMIO_GUEST_FEATURES_SEL 0x024
>
> /* Guest's memory page size in bytes - Write Only */
> #define VIRTIO_MMIO_GUEST_PAGE_SIZE 0x028
Damn. Sorry about it. But if you change the header you'll need to change
the driver:
diff --git a/drivers/virtio/virtio_mmio.c b/drivers/virtio/virtio_mmio.c
index 1f25bb9..10bb8b9 100644
--- a/drivers/virtio/virtio_mmio.c
+++ b/drivers/virtio/virtio_mmio.c
@@ -161,7 +161,7 @@ static void vm_finalize_features(struct virtio_device *vdev)
vring_transport_features(vdev);
for (i = 0; i < ARRAY_SIZE(vdev->features); i++) {
- writel(i, vm_dev->base + VIRTIO_MMIO_GUEST_FEATURES_SET);
+ writel(i, vm_dev->base + VIRTIO_MMIO_GUEST_FEATURES_SEL);
writel(vdev->features[i],
vm_dev->base + VIRTIO_MMIO_GUEST_FEATURES);
}
Cheers!
Paweł
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-11-16 2:33 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-15 14:17 [PATCH] virtio-mmio: Correct the name of the guest features selector Sasha Levin
2011-11-15 14:17 ` Sasha Levin
2011-11-15 14:25 ` Pawel Moll
2011-11-16 0:45 ` Rusty Russell
2011-11-16 0:45 ` Rusty Russell
2011-11-15 14:25 ` Pawel Moll
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.