From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Marek Vasut <marek.vasut@gmail.com>
Cc: linux-ide@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
eric.y.miao@gmail.com, haojian.zhuang@gmail.com, jeff@garzik.org,
radoslav.deak@voipac.com
Subject: Re: [PATCH v3] PXA DMA-capable PATA driver
Date: Wed, 19 May 2010 13:19:14 +0200 [thread overview]
Message-ID: <87pr0s6swd.fsf@free.fr> (raw)
In-Reply-To: <201005180112.30792.marek.vasut@gmail.com> (Marek Vasut's message of "Tue\, 18 May 2010 01\:12\:30 +0200")
Marek Vasut <marek.vasut@gmail.com> writes:
> Dne Út 18. května 2010 01:09:28 Marek Vasut napsal(a):
>> This patch adds a driver for a harddrive attached to PXA address and data
>> bus. Unlike pata_platform, this driver allows usage of PXA DMA controller,
>> making the transmission speed 3x higher.
>
> Hey guys, all the issues pointed out should be addressed. See below.
> Cheers!
For the first iteration, you can have my :
Reviewed-by: Robert Jarzmik <robert.jarzmik@free.fr>
For the next iteration, it would be good to :
- fix the error path in pxa_ata_probe()
=> if dmam_alloc_coherent() fails
=> if pxa_request_dma() fails
- in pxa_ata_remove()
=> maybe call devm_iounmap()
--
Robert
WARNING: multiple messages have this Message-ID (diff)
From: robert.jarzmik@free.fr (Robert Jarzmik)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] PXA DMA-capable PATA driver
Date: Wed, 19 May 2010 13:19:14 +0200 [thread overview]
Message-ID: <87pr0s6swd.fsf@free.fr> (raw)
In-Reply-To: <201005180112.30792.marek.vasut@gmail.com> (Marek Vasut's message of "Tue\, 18 May 2010 01\:12\:30 +0200")
Marek Vasut <marek.vasut@gmail.com> writes:
> Dne ?t 18. kv?tna 2010 01:09:28 Marek Vasut napsal(a):
>> This patch adds a driver for a harddrive attached to PXA address and data
>> bus. Unlike pata_platform, this driver allows usage of PXA DMA controller,
>> making the transmission speed 3x higher.
>
> Hey guys, all the issues pointed out should be addressed. See below.
> Cheers!
For the first iteration, you can have my :
Reviewed-by: Robert Jarzmik <robert.jarzmik@free.fr>
For the next iteration, it would be good to :
- fix the error path in pxa_ata_probe()
=> if dmam_alloc_coherent() fails
=> if pxa_request_dma() fails
- in pxa_ata_remove()
=> maybe call devm_iounmap()
--
Robert
next prev parent reply other threads:[~2010-05-19 11:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-17 23:09 [PATCH v3] PXA DMA-capable PATA driver Marek Vasut
2010-05-17 23:09 ` Marek Vasut
2010-05-17 23:12 ` Marek Vasut
2010-05-17 23:12 ` Marek Vasut
2010-05-19 11:19 ` Robert Jarzmik [this message]
2010-05-19 11:19 ` Robert Jarzmik
2010-05-19 12:44 ` Marek Vasut
2010-05-19 12:44 ` Marek Vasut
2010-05-18 3:56 ` Jeff Garzik
2010-05-18 3:56 ` Jeff Garzik
2010-05-18 8:25 ` Marek Vasut
2010-05-18 8:25 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pr0s6swd.fsf@free.fr \
--to=robert.jarzmik@free.fr \
--cc=eric.y.miao@gmail.com \
--cc=haojian.zhuang@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=marek.vasut@gmail.com \
--cc=radoslav.deak@voipac.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.