All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Markus Klotzbücher" <mk@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] socrates: add USB support
Date: Thu, 22 May 2008 11:59:26 +0200	[thread overview]
Message-ID: <87prrevev5.fsf@denx.de> (raw)
In-Reply-To: <1211411753-30092-1-git-send-email-wd@denx.de> (Wolfgang Denk's message of "Thu\, 22 May 2008 01\:15\:53 +0200")

Sergei, Wolfgang,

Wolfgang Denk <wd@denx.de> writes:

> From: Sergei Poselenov <sposelenov@emcraft.com>
>
> Add new configuration variable CONFIG_PCI_OHCI_DEVNO.
> In case of several PCI USB controllers on a board this variable
> specifys which controller to use.
> See doc/README.generic_usb_ohci for details.
>
> Signed-off-by: Sergei Poselenov <sposelenov@emcraft.com>
> ---
> Markus, please note that we added a new configuration variable,
> CONFIG_PCI_OHCI_DEVNO in drivers/usb_ohci.c. It addresses the the
> case when there are several USB controllers installed on a board
> (like on socrates, where 4 PCI OHCI USB controllers are available),
> and we need to support a controller instance other than the first
> found.
>
> For socrates, currently it is the 2nd OHCI controller of the 2nd
> ISP1562 PCI USB chip (i.e. instance number 3 in the PCI list of OHCI
> controllers (0x1131/0x1561)).

Patch looks ok (and passed the sequoia test) so:

Acked-by: Markus Klotzbuecher <mk@denx.de>

But for the future:

- The subject is less than meaningful. 

- I would have really preferred two patches, one for the generic change
  and one for updating the board config.

Wolfgang, do you want to pick this one up directly (preferably with a
more meaningful subject) or shall I push it through the usb tree. Either
is fine for me.

Best regards

Markus Klotzb?cher

--
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de

  reply	other threads:[~2008-05-22  9:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-21 23:15 [U-Boot-Users] [PATCH] socrates: add USB support Wolfgang Denk
2008-05-22  9:59 ` Markus Klotzbücher [this message]
2008-05-22 13:14   ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87prrevev5.fsf@denx.de \
    --to=mk@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.