From: Marco Gerards <mgerards@xs4all.nl>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: UFS (FFS) support seems broken in grub2
Date: Wed, 23 Jan 2008 10:02:41 +0100 [thread overview]
Message-ID: <87prvssymm.fsf@xs4all.nl> (raw)
In-Reply-To: <20080122200422.GC21526@thorin> (Robert Millan's message of "Tue, 22 Jan 2008 21:04:22 +0100")
Robert Millan <rmh@aybabtu.com> writes:
> On Wed, Jan 23, 2008 at 02:58:02AM +0800, Bean wrote:
>> This patch should fix the problem.
>
> Nice!
>
>> -grub_ufs_label (grub_device_t device __attribute ((unused)),
>> - char **label __attribute ((unused)))
>> +grub_ufs_label (grub_device_t device,char **label)
>
> Please add a space after the comma ;-)
And a changelog entry ;-)
--
Marco
next prev parent reply other threads:[~2008-01-23 9:01 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-19 17:01 UFS (FFS) support seems broken in grub2 jakllsch
2008-01-19 18:27 ` walt
2008-01-22 18:58 ` Bean
2008-01-22 20:04 ` Robert Millan
2008-01-23 9:02 ` Marco Gerards [this message]
2008-01-23 16:15 ` walt
2008-01-23 16:31 ` Bean
2008-01-23 19:21 ` Marco Gerards
2008-01-23 20:26 ` Bean
2008-01-23 22:49 ` walt
2008-01-23 23:53 ` Robert Millan
2008-01-24 1:21 ` walt
2008-01-24 12:30 ` booting *BSD kernels (Re: UFS (FFS) support seems broken in grub2) Robert Millan
2008-01-24 8:33 ` UFS (FFS) support seems broken in grub2 Marco Gerards
2008-01-24 14:20 ` walt
2008-01-24 14:33 ` booting kernel of NetBSD (Re: UFS (FFS) support seems broken in grub2) Robert Millan
2008-01-24 14:53 ` Robert Millan
2008-01-24 16:47 ` walt
2008-01-24 17:12 ` Robert Millan
2008-01-26 15:01 ` Bean
2008-01-26 17:24 ` Robert Millan
2008-01-26 18:19 ` walt
2008-01-26 18:24 ` Bean
2008-01-26 18:31 ` Bean
2008-01-26 19:57 ` Robert Millan
2008-01-26 19:57 ` Robert Millan
2008-01-26 21:24 ` walt
2008-01-27 1:35 ` Bean
2008-01-27 20:13 ` walt
2008-01-27 20:25 ` Bean
2008-01-28 1:54 ` walt
2008-01-28 8:52 ` Robert Millan
2008-01-28 10:02 ` Bean
2008-01-28 13:00 ` Marco Gerards
2008-01-28 13:02 ` Bean
2008-02-02 14:16 ` Bean
2008-01-27 8:53 ` Robert Millan
2008-01-27 20:09 ` walt
2008-01-27 22:11 ` Robert Millan
2008-01-28 8:57 ` Marco Gerards
2008-01-28 10:06 ` Bean
2008-01-28 10:41 ` Robert Millan
2008-02-06 15:32 ` Robert Millan
2008-02-06 16:03 ` Bean
2008-01-24 18:16 ` UFS (FFS) support seems broken in grub2 Marco Gerards
2008-01-24 18:19 ` Robert Millan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87prvssymm.fsf@xs4all.nl \
--to=mgerards@xs4all.nl \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.