From: Marco Gerards <mgerards@xs4all.nl>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] improve grub_mm_init_region() debug message
Date: Mon, 21 Jan 2008 18:02:20 +0100 [thread overview]
Message-ID: <87prvv863n.fsf@xs4all.nl> (raw)
In-Reply-To: <20080115180055.GA21551@thorin> (Robert Millan's message of "Tue, 15 Jan 2008 19:00:55 +0100")
Robert Millan <rmh@aybabtu.com> writes:
> On Tue, Jan 15, 2008 at 12:42:39PM -0500, Pavel Roskin wrote:
>>
>> On Tue, 2008-01-15 at 18:17 +0100, Robert Millan wrote:
>> > - grub_dprintf ("mem", "Using memory for heap: addr=%p, size=%u\n",
>> > addr, (unsigned int) size);
>> > + grub_dprintf ("mem", "Using memory for heap: start=%p, end=%p\n",
>> > addr, addr + size);
>>
>> Maybe addr+size-1 would be better? Inclusive boundaries are more
>> intuitive. Just run "cat /proc/iomem" to see what I mean.
>
> Sounds better to me.
>
> Does this change (with addr + size -1) sound fine to everyone else?
Why not showing both the range and the size. Isn't the size useful
sometimes? I hate calculating such things by hand...
--
Marco
next prev parent reply other threads:[~2008-01-21 17:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-15 17:17 [PATCH] improve grub_mm_init_region() debug message Robert Millan
2008-01-15 17:42 ` Pavel Roskin
2008-01-15 18:00 ` Robert Millan
2008-01-19 21:50 ` Robert Millan
2008-01-20 2:26 ` Pavel Roskin
2008-01-21 17:02 ` Marco Gerards [this message]
2008-01-21 17:11 ` Robert Millan
2008-01-21 17:42 ` Marco Gerards
2008-01-21 20:58 ` Robert Millan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87prvv863n.fsf@xs4all.nl \
--to=mgerards@xs4all.nl \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.