All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Millan <rmh@aybabtu.com>
To: grub-devel@gnu.org
Subject: [PATCH] improve grub_mm_init_region() debug message
Date: Tue, 15 Jan 2008 18:17:47 +0100	[thread overview]
Message-ID: <20080115171747.GA14625@thorin> (raw)

[-- Attachment #1: Type: text/plain, Size: 274 bytes --]


This has bothered me for a while.  By changing %u to %p this debug
message becomes actually useful for checking offset problems.

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call, if you are unable to speak?
(as seen on /.)

[-- Attachment #2: memdebug.diff --]
[-- Type: text/x-diff, Size: 597 bytes --]


	* kern/mm.c (grub_mm_init_region): Improve debug message.

diff -u -x configure -x config.h.in -ur grub2/kern/mm.c memdebug/kern/mm.c
--- grub2/kern/mm.c	2007-12-30 09:52:04.000000000 +0100
+++ memdebug/kern/mm.c	2008-01-15 18:07:14.000000000 +0100
@@ -143,7 +143,7 @@
   grub_mm_header_t h;
   grub_mm_region_t r, *p, q;
 
-  grub_dprintf ("mem", "Using memory for heap: addr=%p, size=%u\n", addr, (unsigned int) size);
+  grub_dprintf ("mem", "Using memory for heap: start=%p, end=%p\n", addr, addr + size);
 
   /* If this region is too small, ignore it.  */
   if (size < GRUB_MM_ALIGN * 2)

             reply	other threads:[~2008-01-15 17:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-15 17:17 Robert Millan [this message]
2008-01-15 17:42 ` [PATCH] improve grub_mm_init_region() debug message Pavel Roskin
2008-01-15 18:00   ` Robert Millan
2008-01-19 21:50     ` Robert Millan
2008-01-20  2:26       ` Pavel Roskin
2008-01-21 17:02     ` Marco Gerards
2008-01-21 17:11       ` Robert Millan
2008-01-21 17:42         ` Marco Gerards
2008-01-21 20:58           ` Robert Millan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080115171747.GA14625@thorin \
    --to=rmh@aybabtu.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.