Re: [ppc patch] heap memory allocation

[Johan Rydberg <jrydberg@night.trouble.net>]

Hollis Blanchard <hollis@penguinppc.org> writes:

> [...]
> I've tested this by getting to the GRUB command line on Old World Mac, New
> World Mac, and CodeGen firmware (briQ).
>
> Ok?

I won't address the technical issues in this mail.

> -Hollis
>
> 2004-10-13  Hollis Blanchard  <hollis@penguinppc.org>
>
>     * include/grub/powerpc/ieee1275/ieee1275.h (abort): Add function
>     prototype.
>     * kern/powerpc/ieee1275/init.c (grub_machine_init): Call
>     grub_console_init first.
>     Change the memory range used for grub_ieee1275_claim and
>     grub_mm_init_region.
>     Print an error message if the claim fails.

Looking good Hollis in respect to GCS.  There's just one thing:

> +  /* Apple OF 3.1.1 reserves an extra 0x1000 bytes below the load address
> +   * of an ELF file.  */
> +  heap_len = (grub_addr_t) &_start - 0x1000 - heap_start;

Comments are written without extra prefix stars on new lines.
Like this:

  /* Apple OF 3.1.1 reserves an extra 0x1000 bytes below the load address
     of an ELF file.  */

Other than that, it looks fine to me.  But it's up to the others
to accept the patch.  

I'm pretty sure Marco could make this little change himself if he
chooses to accept the patch.

Best Regards.

~j