From: Thomas Gleixner <tglx@kernel.org>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Hyunwoo Kim <imv4bel@gmail.com>,
Frederic Weisbecker <frederic@kernel.org>,
Anna-Maria Behnsen <anna-maria@linutronix.de>,
Kees Cook <kees@kernel.org>,
Christian Brauner <brauner@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
John Stultz <jstultz@google.com>, Ingo Molnar <mingo@kernel.org>,
Alexander Viro <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.cz>,
"Eric W. Biederman" <ebiederm@xmission.com>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH v2] posix-cpu-timers: Dequeue per-thread timers before exchange_tids()
Date: Tue, 01 Sep 2026 16:50:39 +0200 [thread overview]
Message-ID: <87qzjdauv4.ffs@fw13> (raw)
In-Reply-To: <apXGzcA9BmrbrQZv@redhat.com>
On Mon, Aug 31 2026 at 20:24, Oleg Nesterov wrote:
> On 08/31, Thomas Gleixner wrote:
>>
>> On Wed, Aug 26 2026 at 14:55, Oleg Nesterov wrote:
>> > Can we move posix_cpu_timers_exit() or the whole CONFIG_POSIX_TIMERS
>> > sequence in begin_new_exec() up, right after de_thread() before the
>> > "if (retval)" check?
>>
>> Yes, but that does not buy us anything.
>
> I didn't mean this makes sense, I just tried to understand the Hyunwoo's
> fix, in particular the placement of additional posix_cpu_timers_exit().
Fair enough. But as I was staring at it some more, I thought more about
it. Yes, we can do:
ret = de_thread()
if (ret)
goto out;
mop_up_posix_timers();
de_thread() only returns failure _before_ the TID swap, so that's safe
and spares sprinkling this extra invocation into de_thread().
What a mess.
next prev parent reply other threads:[~2026-09-01 14:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-26 11:41 [PATCH v2] posix-cpu-timers: Dequeue per-thread timers before exchange_tids() Hyunwoo Kim
2026-08-26 12:55 ` Oleg Nesterov
2026-08-27 13:13 ` Hyunwoo Kim
2026-08-31 16:20 ` Thomas Gleixner
2026-08-31 18:24 ` Oleg Nesterov
2026-09-01 14:50 ` Thomas Gleixner [this message]
2026-09-01 15:11 ` Thomas Gleixner
2026-08-31 11:56 ` Thomas Gleixner
2026-08-31 16:19 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87qzjdauv4.ffs@fw13 \
--to=tglx@kernel.org \
--cc=anna-maria@linutronix.de \
--cc=brauner@kernel.org \
--cc=ebiederm@xmission.com \
--cc=frederic@kernel.org \
--cc=imv4bel@gmail.com \
--cc=jack@suse.cz \
--cc=jstultz@google.com \
--cc=kees@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.