All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Frieder Schrempf <frieder@fris.de>
Cc: Mark Brown <broonie@kernel.org>,
	 Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,  Han Xu <han.xu@nxp.com>,
	Eberhard Stoll <eberhard.stoll@kontron.de>,
	 Frieder Schrempf <frieder.schrempf@kontron.de>,
	 Tudor Ambarus <tudor.ambarus@linaro.org>,
	Pratyush Yadav <pratyush@kernel.org>,
	 Michael Walle <mwalle@kernel.org>,
	linux-spi@vger.kernel.org,  linux-kernel@vger.kernel.org,
	linux-mtd@lists.infradead.org,  imx@lists.linux.dev
Subject: Re: [PATCH RFC 2/7] mtd: spinand: Add support for clock to RX delay setting
Date: Mon, 09 Mar 2026 16:11:34 +0100	[thread overview]
Message-ID: <87qzptnil5.fsf@bootlin.com> (raw)
In-Reply-To: <20260303-fsl-qspi-rx-sampling-delay-v1-2-9326bbc492d6@kontron.de> (Frieder Schrempf's message of "Tue, 03 Mar 2026 17:29:23 +0100")


> +#define SPINAND_RX_SAMPLING_DELAY(__delay)				\
> +	.rx_sampling_delay_ns = __delay

For this macro I would be in favour of suffixing it with the unit,
ie: _NS.

Miquèl

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Frieder Schrempf <frieder@fris.de>
Cc: Mark Brown <broonie@kernel.org>,
	 Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,  Han Xu <han.xu@nxp.com>,
	Eberhard Stoll <eberhard.stoll@kontron.de>,
	 Frieder Schrempf <frieder.schrempf@kontron.de>,
	 Tudor Ambarus <tudor.ambarus@linaro.org>,
	Pratyush Yadav <pratyush@kernel.org>,
	 Michael Walle <mwalle@kernel.org>,
	linux-spi@vger.kernel.org,  linux-kernel@vger.kernel.org,
	linux-mtd@lists.infradead.org,  imx@lists.linux.dev
Subject: Re: [PATCH RFC 2/7] mtd: spinand: Add support for clock to RX delay setting
Date: Mon, 09 Mar 2026 16:11:34 +0100	[thread overview]
Message-ID: <87qzptnil5.fsf@bootlin.com> (raw)
In-Reply-To: <20260303-fsl-qspi-rx-sampling-delay-v1-2-9326bbc492d6@kontron.de> (Frieder Schrempf's message of "Tue, 03 Mar 2026 17:29:23 +0100")


> +#define SPINAND_RX_SAMPLING_DELAY(__delay)				\
> +	.rx_sampling_delay_ns = __delay

For this macro I would be in favour of suffixing it with the unit,
ie: _NS.

Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  parent reply	other threads:[~2026-03-09 15:11 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-03 16:29 [PATCH RFC 0/7] Support for SPI RX Sampling Delay Compensation Frieder Schrempf
2026-03-03 16:29 ` Frieder Schrempf
2026-03-03 16:29 ` [PATCH RFC 1/7] spi: Add 'rx_sampling_delay_ns' parameter for clock to RX delay Frieder Schrempf
2026-03-03 16:29   ` Frieder Schrempf
2026-03-03 21:01   ` Frank Li
2026-03-03 21:01     ` Frank Li
2026-03-05 22:14     ` Mark Brown
2026-03-05 22:14       ` Mark Brown
2026-03-05 22:34       ` [EXT] " Frank Li
2026-03-05 22:34         ` Frank Li
2026-03-03 16:29 ` [PATCH RFC 2/7] mtd: spinand: Add support for clock to RX delay setting Frieder Schrempf
2026-03-03 16:29   ` Frieder Schrempf
2026-03-03 21:01   ` Frank Li
2026-03-03 21:01     ` Frank Li
2026-03-09 15:11   ` Miquel Raynal [this message]
2026-03-09 15:11     ` Miquel Raynal
2026-03-03 16:29 ` [PATCH RFC 3/7] mtd: spinand: winbond: Add RX sampling delay values Frieder Schrempf
2026-03-03 16:29   ` Frieder Schrempf
2026-03-03 21:01   ` Frank Li
2026-03-03 21:01     ` Frank Li
2026-03-03 16:29 ` [PATCH RFC 4/7] mtd: spinand: toshiba: " Frieder Schrempf
2026-03-03 16:29   ` Frieder Schrempf
2026-03-03 21:01   ` Frank Li
2026-03-03 21:01     ` Frank Li
2026-03-06  9:37   ` kernel test robot
2026-03-06 11:02   ` kernel test robot
2026-03-09 15:12   ` Miquel Raynal
2026-03-09 15:12     ` Miquel Raynal
2026-03-10 14:17     ` Frieder Schrempf
2026-03-10 14:17       ` Frieder Schrempf
2026-03-03 16:29 ` [PATCH RFC 5/7] spi: Add RX sampling point adjustment Frieder Schrempf
2026-03-03 16:29   ` Frieder Schrempf
2026-03-03 21:01   ` Frank Li
2026-03-03 21:01     ` Frank Li
2026-03-06  9:05   ` kernel test robot
2026-03-09 15:25   ` Miquel Raynal
2026-03-09 15:25     ` Miquel Raynal
2026-03-10 14:19     ` Frieder Schrempf
2026-03-10 14:19       ` Frieder Schrempf
2026-03-03 16:29 ` [PATCH RFC 6/7] spi: spi-mem: Call spi_set_rx_sampling_point() for each op Frieder Schrempf
2026-03-03 16:29   ` Frieder Schrempf
2026-03-03 21:01   ` Frank Li
2026-03-03 21:01     ` Frank Li
2026-03-09 15:09   ` Miquel Raynal
2026-03-09 15:09     ` Miquel Raynal
2026-03-10 14:16     ` Frieder Schrempf
2026-03-10 14:16       ` Frieder Schrempf
2026-03-31  9:23       ` Miquel Raynal
2026-03-31  9:23         ` Miquel Raynal
2026-03-31  9:58         ` Frieder Schrempf
2026-03-31  9:58           ` Frieder Schrempf
2026-03-31 15:26           ` Miquel Raynal
2026-03-31 15:26             ` Miquel Raynal
2026-03-31 17:57             ` Frieder Schrempf
2026-03-31 17:57               ` Frieder Schrempf
2026-03-31 18:20               ` Mark Brown
2026-03-31 18:20                 ` Mark Brown
2026-04-01  8:32               ` Miquel Raynal
2026-04-01  8:32                 ` Miquel Raynal
2026-04-01 11:00                 ` Michael Walle
2026-04-01 11:00                   ` Michael Walle
2026-03-03 16:29 ` [PATCH RFC 7/7] spi: spi-fsl-qspi: Add support for RX data sampling point adjustment Frieder Schrempf
2026-03-03 16:29   ` Frieder Schrempf
2026-03-03 21:01   ` Frank Li
2026-03-03 21:01     ` Frank Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87qzptnil5.fsf@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=broonie@kernel.org \
    --cc=eberhard.stoll@kontron.de \
    --cc=frieder.schrempf@kontron.de \
    --cc=frieder@fris.de \
    --cc=han.xu@nxp.com \
    --cc=imx@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=mwalle@kernel.org \
    --cc=pratyush@kernel.org \
    --cc=richard@nod.at \
    --cc=tudor.ambarus@linaro.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.