All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: qemu-devel@nongnu.org,  qemu-trivial@nongnu.org
Subject: Re: [PATCH trivial] vhost-user-test: remove trailing newlines in g_test_message() calls
Date: Thu, 18 Sep 2025 08:08:15 +0200	[thread overview]
Message-ID: <87qzw41eeo.fsf@pond.sub.org> (raw)
In-Reply-To: <20250917142919.928244-1-mjt@tls.msk.ru> (Michael Tokarev's message of "Wed, 17 Sep 2025 17:29:16 +0300")

Michael Tokarev <mjt@tls.msk.ru> writes:

> Fixes: c9a1ea9c52 Revert "tests/qtest: use qos_printf instead of g_test_message"
>

Drop the blank line here.

> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>

g_test_message()'s documentation is useless.  Use the force, read the
source: g_test_message() wraps around g_test_log(G_TEST_LOG_MESSAGE,
...), which appends a newline.  So your patch makes sense.

Thanks for cleaning up the mess I made!

Reviewed-by: Markus Armbruster <armbru@redhat.com>



      parent reply	other threads:[~2025-09-18  6:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-17 14:29 [PATCH trivial] vhost-user-test: remove trailing newlines in g_test_message() calls Michael Tokarev
2025-09-17 15:40 ` Laurent Vivier
2025-09-18  6:08 ` Markus Armbruster [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87qzw41eeo.fsf@pond.sub.org \
    --to=armbru@redhat.com \
    --cc=mjt@tls.msk.ru \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.