[PATCH trivial] vhost-user-test: remove trailing newlines in g_test_message() calls

[PATCH trivial] vhost-user-test: remove trailing newlines in g_test_message() calls

[Michael Tokarev]

Fixes: c9a1ea9c52 Revert "tests/qtest: use qos_printf instead of g_test_message"

Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
 tests/qtest/vhost-user-test.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/tests/qtest/vhost-user-test.c b/tests/qtest/vhost-user-test.c
index 56472ca709..e8c3613560 100644
--- a/tests/qtest/vhost-user-test.c
+++ b/tests/qtest/vhost-user-test.c
@@ -392,7 +392,7 @@ static void chr_read(void *opaque, const uint8_t *buf, int size)
          * We don't need to do anything here, the remote is just
          * letting us know it is in charge. Just log it.
          */
-        g_test_message("set_owner: start of session\n");
+        g_test_message("set_owner: start of session");
         break;
 
     case VHOST_USER_GET_PROTOCOL_FEATURES:
@@ -418,7 +418,7 @@ static void chr_read(void *opaque, const uint8_t *buf, int size)
          * the remote end to send this. There is no handshake reply so
          * just log the details for debugging.
          */
-        g_test_message("set_protocol_features: 0x%"PRIx64 "\n", msg.payload.u64);
+        g_test_message("set_protocol_features: 0x%"PRIx64, msg.payload.u64);
         break;
 
         /*
@@ -426,11 +426,11 @@ static void chr_read(void *opaque, const uint8_t *buf, int size)
          * address of the vrings but we can simply report them.
          */
     case VHOST_USER_SET_VRING_NUM:
-        g_test_message("set_vring_num: %d/%d\n",
+        g_test_message("set_vring_num: %d/%d",
                    msg.payload.state.index, msg.payload.state.num);
         break;
     case VHOST_USER_SET_VRING_ADDR:
-        g_test_message("set_vring_addr: 0x%"PRIx64"/0x%"PRIx64"/0x%"PRIx64"\n",
+        g_test_message("set_vring_addr: 0x%"PRIx64"/0x%"PRIx64"/0x%"PRIx64,
                    msg.payload.addr.avail_user_addr,
                    msg.payload.addr.desc_user_addr,
                    msg.payload.addr.used_user_addr);
@@ -463,7 +463,7 @@ static void chr_read(void *opaque, const uint8_t *buf, int size)
     case VHOST_USER_SET_VRING_CALL:
         /* consume the fd */
         if (!qemu_chr_fe_get_msgfds(chr, &fd, 1) && fd < 0) {
-            g_test_message("call fd: %d, do not set non-blocking\n", fd);
+            g_test_message("call fd: %d, do not set non-blocking", fd);
             break;
         }
         /*
@@ -509,12 +509,12 @@ static void chr_read(void *opaque, const uint8_t *buf, int size)
          * fully functioning vhost-user we would enable/disable the
          * vring monitoring.
          */
-        g_test_message("set_vring(%d)=%s\n", msg.payload.state.index,
+        g_test_message("set_vring(%d)=%s", msg.payload.state.index,
                    msg.payload.state.num ? "enabled" : "disabled");
         break;
 
     default:
-        g_test_message("vhost-user: un-handled message: %d\n", msg.request);
+        g_test_message("vhost-user: un-handled message: %d", msg.request);
         break;
     }
 
-- 
2.47.3

Re: [PATCH trivial] vhost-user-test: remove trailing newlines in g_test_message() calls

[Laurent Vivier]

Le 17/09/2025 à 16:29, Michael Tokarev a écrit :
> Fixes: c9a1ea9c52 Revert "tests/qtest: use qos_printf instead of g_test_message"
> 
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
>   tests/qtest/vhost-user-test.c | 14 +++++++-------
>   1 file changed, 7 insertions(+), 7 deletions(-)
> 

Reviewed-by: Laurent Vivier <laurent@vivier.eu>

Re: [PATCH trivial] vhost-user-test: remove trailing newlines in g_test_message() calls

[Markus Armbruster]

Michael Tokarev <mjt@tls.msk.ru> writes:

> Fixes: c9a1ea9c52 Revert "tests/qtest: use qos_printf instead of g_test_message"
>

Drop the blank line here.

> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>

g_test_message()'s documentation is useless.  Use the force, read the
source: g_test_message() wraps around g_test_log(G_TEST_LOG_MESSAGE,
...), which appends a newline.  So your patch makes sense.

Thanks for cleaning up the mess I made!

Reviewed-by: Markus Armbruster <armbru@redhat.com>