From: Jani Nikula <jani.nikula@intel.com>
To: Bagas Sanjaya <bagasdotme@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Documentation <linux-doc@vger.kernel.org>,
Linux DRI Development <dri-devel@lists.freedesktop.org>,
Linux Intel Graphics <intel-gfx@lists.freedesktop.org>
Cc: Bagas Sanjaya <bagasdotme@gmail.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Maxime Ripard <mripard@kernel.org>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Daniel Vetter <daniel@ffwll.ch>, Wayne Lin <Wayne.Lin@amd.com>,
David Airlie <airlied@gmail.com>
Subject: Re: [PATCH] drm/dp_mst: Separate @failing_port list in drm_dp_mst_atomic_check_mgr() comment
Date: Mon, 22 Jan 2024 19:21:19 +0200 [thread overview]
Message-ID: <87r0i9nv1s.fsf@intel.com> (raw)
In-Reply-To: <20231114081033.27343-1-bagasdotme@gmail.com>
On Tue, 14 Nov 2023, Bagas Sanjaya <bagasdotme@gmail.com> wrote:
> Stephen Rothwell reported htmldocs warnings when merging drm-intel
> tree:
>
> Documentation/gpu/drm-kms-helpers:296: drivers/gpu/drm/display/drm_dp_mst_topology.c:5484: ERROR: Unexpected indentation.
> Documentation/gpu/drm-kms-helpers:296: drivers/gpu/drm/display/drm_dp_mst_topology.c:5488: WARNING: Block quote ends without a blank line; unexpected unindent.
>
> Separate @failing_port return value list by surrounding it with a
> blank line to fix above warnings.
>
> Fixes: 1cd0a5ea427931 ("drm/dp_mst: Factor out a helper to check the atomic state of a topology manager")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Closes: https://lore.kernel.org/linux-next/20231114141715.6f435118@canb.auug.org.au/
> Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
Thanks, pushed to drm-misc-fixes.
BR,
Jani.
> ---
> drivers/gpu/drm/display/drm_dp_mst_topology.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/display/drm_dp_mst_topology.c b/drivers/gpu/drm/display/drm_dp_mst_topology.c
> index 0854fe428f173a..b9a98587fbef7f 100644
> --- a/drivers/gpu/drm/display/drm_dp_mst_topology.c
> +++ b/drivers/gpu/drm/display/drm_dp_mst_topology.c
> @@ -5479,6 +5479,7 @@ EXPORT_SYMBOL(drm_dp_mst_atomic_enable_dsc);
> * - 0 if the new state is valid
> * - %-ENOSPC, if the new state is invalid, because of BW limitation
> * @failing_port is set to:
> + *
> * - The non-root port where a BW limit check failed
> * with all the ports downstream of @failing_port passing
> * the BW limit check.
> @@ -5487,6 +5488,7 @@ EXPORT_SYMBOL(drm_dp_mst_atomic_enable_dsc);
> * - %NULL if the BW limit check failed at the root port
> * with all the ports downstream of the root port passing
> * the BW limit check.
> + *
> * - %-EINVAL, if the new state is invalid, because the root port has
> * too many payloads.
> */
>
> base-commit: 59be90248b422f2924872de0be2867652214096a
--
Jani Nikula, Intel
WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@intel.com>
To: Bagas Sanjaya <bagasdotme@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Documentation <linux-doc@vger.kernel.org>,
Linux DRI Development <dri-devel@lists.freedesktop.org>,
Linux Intel Graphics <intel-gfx@lists.freedesktop.org>
Cc: "David Airlie" <airlied@gmail.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Lyude Paul" <lyude@redhat.com>,
"Imre Deak" <imre.deak@intel.com>,
"Wayne Lin" <Wayne.Lin@amd.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Tvrtko Ursulin" <tvrtko.ursulin@linux.intel.com>,
"Bagas Sanjaya" <bagasdotme@gmail.com>,
"Stephen Rothwell" <sfr@canb.auug.org.au>
Subject: Re: [PATCH] drm/dp_mst: Separate @failing_port list in drm_dp_mst_atomic_check_mgr() comment
Date: Mon, 22 Jan 2024 19:21:19 +0200 [thread overview]
Message-ID: <87r0i9nv1s.fsf@intel.com> (raw)
In-Reply-To: <20231114081033.27343-1-bagasdotme@gmail.com>
On Tue, 14 Nov 2023, Bagas Sanjaya <bagasdotme@gmail.com> wrote:
> Stephen Rothwell reported htmldocs warnings when merging drm-intel
> tree:
>
> Documentation/gpu/drm-kms-helpers:296: drivers/gpu/drm/display/drm_dp_mst_topology.c:5484: ERROR: Unexpected indentation.
> Documentation/gpu/drm-kms-helpers:296: drivers/gpu/drm/display/drm_dp_mst_topology.c:5488: WARNING: Block quote ends without a blank line; unexpected unindent.
>
> Separate @failing_port return value list by surrounding it with a
> blank line to fix above warnings.
>
> Fixes: 1cd0a5ea427931 ("drm/dp_mst: Factor out a helper to check the atomic state of a topology manager")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Closes: https://lore.kernel.org/linux-next/20231114141715.6f435118@canb.auug.org.au/
> Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
Thanks, pushed to drm-misc-fixes.
BR,
Jani.
> ---
> drivers/gpu/drm/display/drm_dp_mst_topology.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/display/drm_dp_mst_topology.c b/drivers/gpu/drm/display/drm_dp_mst_topology.c
> index 0854fe428f173a..b9a98587fbef7f 100644
> --- a/drivers/gpu/drm/display/drm_dp_mst_topology.c
> +++ b/drivers/gpu/drm/display/drm_dp_mst_topology.c
> @@ -5479,6 +5479,7 @@ EXPORT_SYMBOL(drm_dp_mst_atomic_enable_dsc);
> * - 0 if the new state is valid
> * - %-ENOSPC, if the new state is invalid, because of BW limitation
> * @failing_port is set to:
> + *
> * - The non-root port where a BW limit check failed
> * with all the ports downstream of @failing_port passing
> * the BW limit check.
> @@ -5487,6 +5488,7 @@ EXPORT_SYMBOL(drm_dp_mst_atomic_enable_dsc);
> * - %NULL if the BW limit check failed at the root port
> * with all the ports downstream of the root port passing
> * the BW limit check.
> + *
> * - %-EINVAL, if the new state is invalid, because the root port has
> * too many payloads.
> */
>
> base-commit: 59be90248b422f2924872de0be2867652214096a
--
Jani Nikula, Intel
WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@intel.com>
To: Bagas Sanjaya <bagasdotme@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Documentation <linux-doc@vger.kernel.org>,
Linux DRI Development <dri-devel@lists.freedesktop.org>,
Linux Intel Graphics <intel-gfx@lists.freedesktop.org>
Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
Bagas Sanjaya <bagasdotme@gmail.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Maxime Ripard <mripard@kernel.org>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Daniel Vetter <daniel@ffwll.ch>, Wayne Lin <Wayne.Lin@amd.com>,
David Airlie <airlied@gmail.com>
Subject: Re: [PATCH] drm/dp_mst: Separate @failing_port list in drm_dp_mst_atomic_check_mgr() comment
Date: Mon, 22 Jan 2024 19:21:19 +0200 [thread overview]
Message-ID: <87r0i9nv1s.fsf@intel.com> (raw)
In-Reply-To: <20231114081033.27343-1-bagasdotme@gmail.com>
On Tue, 14 Nov 2023, Bagas Sanjaya <bagasdotme@gmail.com> wrote:
> Stephen Rothwell reported htmldocs warnings when merging drm-intel
> tree:
>
> Documentation/gpu/drm-kms-helpers:296: drivers/gpu/drm/display/drm_dp_mst_topology.c:5484: ERROR: Unexpected indentation.
> Documentation/gpu/drm-kms-helpers:296: drivers/gpu/drm/display/drm_dp_mst_topology.c:5488: WARNING: Block quote ends without a blank line; unexpected unindent.
>
> Separate @failing_port return value list by surrounding it with a
> blank line to fix above warnings.
>
> Fixes: 1cd0a5ea427931 ("drm/dp_mst: Factor out a helper to check the atomic state of a topology manager")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Closes: https://lore.kernel.org/linux-next/20231114141715.6f435118@canb.auug.org.au/
> Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
Thanks, pushed to drm-misc-fixes.
BR,
Jani.
> ---
> drivers/gpu/drm/display/drm_dp_mst_topology.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/display/drm_dp_mst_topology.c b/drivers/gpu/drm/display/drm_dp_mst_topology.c
> index 0854fe428f173a..b9a98587fbef7f 100644
> --- a/drivers/gpu/drm/display/drm_dp_mst_topology.c
> +++ b/drivers/gpu/drm/display/drm_dp_mst_topology.c
> @@ -5479,6 +5479,7 @@ EXPORT_SYMBOL(drm_dp_mst_atomic_enable_dsc);
> * - 0 if the new state is valid
> * - %-ENOSPC, if the new state is invalid, because of BW limitation
> * @failing_port is set to:
> + *
> * - The non-root port where a BW limit check failed
> * with all the ports downstream of @failing_port passing
> * the BW limit check.
> @@ -5487,6 +5488,7 @@ EXPORT_SYMBOL(drm_dp_mst_atomic_enable_dsc);
> * - %NULL if the BW limit check failed at the root port
> * with all the ports downstream of the root port passing
> * the BW limit check.
> + *
> * - %-EINVAL, if the new state is invalid, because the root port has
> * too many payloads.
> */
>
> base-commit: 59be90248b422f2924872de0be2867652214096a
--
Jani Nikula, Intel
next prev parent reply other threads:[~2024-01-22 17:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-14 8:10 [Intel-gfx] [PATCH] drm/dp_mst: Separate @failing_port list in drm_dp_mst_atomic_check_mgr() comment Bagas Sanjaya
2023-11-14 8:10 ` Bagas Sanjaya
2023-11-14 8:10 ` Bagas Sanjaya
2023-11-14 8:39 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2023-11-14 8:57 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-11-14 14:19 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2024-01-22 17:21 ` Jani Nikula [this message]
2024-01-22 17:21 ` [PATCH] " Jani Nikula
2024-01-22 17:21 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0i9nv1s.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=Wayne.Lin@amd.com \
--cc=airlied@gmail.com \
--cc=bagasdotme@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mripard@kernel.org \
--cc=rodrigo.vivi@intel.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.