Re: [PATCH] hw/arm/musicpal: Convert to qemu_add_kbd_event_handler()

["Alex Bennée" <alex.bennee@linaro.org>]

Jan Kiszka <jan.kiszka@web.de> writes:

> On 19.01.24 12:24, Alex Bennée wrote:
>> Peter Maydell <peter.maydell@linaro.org> writes:
>>
>>> Convert the musicpal key input device to use
>>> qemu_add_kbd_event_handler().  This lets us simplify it because we no
>>> longer need to track whether we're in the middle of a PS/2 multibyte
>>> key sequence.
<snip>
>>
>> Well the key input all works as intended and looks good to me. I'm a
>> little disappointed I couldn't get audio working on the musicpal machine
>> but that is not a problem for this patch.
>>
>> Tested-by: Alex Bennée <alex.bennee@linaro.org>
>> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
>>
>
> Looks good to me as well, all keys still work fine.
>
> No idea what's the issue with sound, though. I think I haven't run the
> whole stuff in a decade or so, had to search for all the pieces first of
> all again. The webradio service original behind this stopped their
> operations, at least for this device, but manually entered favorits
> still work on the real device - I still have one, though that is
> starting to get some issues as well.

I navigated through the favourites and after pressing some keys it seems
to indicate there was a stream of some sort (or at least a bitrate was
reported ;-).

The main issue I was having with sound was with pipewire - this would
eventually generate a lot of warning messages because input devices are
created but I guess the model wasn't draining the input buffers so
eventually we get:

  qemu: 0x7f1490259500: overrun write:5859188 filled:5842804 + size:940 > max:4194304
  qemu: 0x7f14902680a0: overrun write:5860128 filled:5843744 + size:940 > max:4194304
  qemu: 0x7f1490259500: overrun write:5861068 filled:5844684 + size:940 > max:4194304
  qemu: 0x7f14902680a0: overrun write:5862008 filled:5845624 + size:940 > max:4194304

Is your image just a hacked up version of the original firmware or
something we have source for? I guess there was never a rockbox port for
the device?

>
> Thanks,
> Jan

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro