All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: Thomas Richard <thomas.richard@bootlin.com>
Cc: Aswath Govindraju <a-govindraju@ti.com>,
	Vignesh Raghavendra <vigneshr@ti.com>, Nishanth Menon <nm@ti.com>,
	Tero Kristo <kristo@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Gregory CLEMENT <gregory.clement@bootlin.com>
Subject: Re: [PATCH] irqchip/ti-sci-intr: Add support for system suspend/resume PM
Date: Wed, 01 Nov 2023 08:42:41 +0000	[thread overview]
Message-ID: <87r0l96f0e.wl-maz@kernel.org> (raw)
In-Reply-To: <184d23fc-bb62-473c-8400-cda160aa44f3@bootlin.com>

On Tue, 31 Oct 2023 16:00:59 +0000,
Thomas Richard <thomas.richard@bootlin.com> wrote:
> 
> On 6/8/22 11:12, Marc Zyngier wrote:
> > On Wed, 08 Jun 2022 09:48:20 +0100,
> > Aswath Govindraju <a-govindraju@ti.com> wrote:
> >>
> >> As, the resource allocator does not have enough memory to save and
> >> restore all the mappings corresponding various resources, this is being
> >> done on the requester or consumer side.
> > 
> > You're missing the point: the ti_sci_resource structure is managed by
> > this resource allocator, and it isn't exactly rocket science to add
> > the required context to it, and then get it to restore that context on
> > resume.
> 
> Hi Marc,
> 
> I'm interested to continue the work to upstream this patch.
> I read all the thread, but I think I'm also missing the point.
> 
> Do you mean the ti_sci_intr_irq_domain struct is not the right place to
> save the mappings, and it shall not be done in this irqchip driver?
> The context should be saved and restored from the ti_sci driver using
> the ti_sci_resource struct?

That's exactly my point. There is already a large body of code that is
aware of the resource allocation (the ti_sci driver), which is common
to a whole lot of subsystem that will need some form of save/restore.

It seems natural to put the save/restore aspects inside that driver,
unless there is some other reasons not to do so (which haven't so far
been explained).

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Thomas Richard <thomas.richard@bootlin.com>
Cc: Aswath Govindraju <a-govindraju@ti.com>,
	Vignesh Raghavendra <vigneshr@ti.com>, Nishanth Menon <nm@ti.com>,
	Tero Kristo <kristo@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Gregory CLEMENT <gregory.clement@bootlin.com>
Subject: Re: [PATCH] irqchip/ti-sci-intr: Add support for system suspend/resume PM
Date: Wed, 01 Nov 2023 08:42:41 +0000	[thread overview]
Message-ID: <87r0l96f0e.wl-maz@kernel.org> (raw)
In-Reply-To: <184d23fc-bb62-473c-8400-cda160aa44f3@bootlin.com>

On Tue, 31 Oct 2023 16:00:59 +0000,
Thomas Richard <thomas.richard@bootlin.com> wrote:
> 
> On 6/8/22 11:12, Marc Zyngier wrote:
> > On Wed, 08 Jun 2022 09:48:20 +0100,
> > Aswath Govindraju <a-govindraju@ti.com> wrote:
> >>
> >> As, the resource allocator does not have enough memory to save and
> >> restore all the mappings corresponding various resources, this is being
> >> done on the requester or consumer side.
> > 
> > You're missing the point: the ti_sci_resource structure is managed by
> > this resource allocator, and it isn't exactly rocket science to add
> > the required context to it, and then get it to restore that context on
> > resume.
> 
> Hi Marc,
> 
> I'm interested to continue the work to upstream this patch.
> I read all the thread, but I think I'm also missing the point.
> 
> Do you mean the ti_sci_intr_irq_domain struct is not the right place to
> save the mappings, and it shall not be done in this irqchip driver?
> The context should be saved and restored from the ti_sci driver using
> the ti_sci_resource struct?

That's exactly my point. There is already a large body of code that is
aware of the resource allocation (the ti_sci driver), which is common
to a whole lot of subsystem that will need some form of save/restore.

It seems natural to put the save/restore aspects inside that driver,
unless there is some other reasons not to do so (which haven't so far
been explained).

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.

  reply	other threads:[~2023-11-01  8:43 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-07  6:19 [PATCH] irqchip/ti-sci-intr: Add support for system suspend/resume PM Aswath Govindraju
2022-06-07  6:19 ` Aswath Govindraju
2022-06-07  7:18 ` Marc Zyngier
2022-06-07  7:18   ` Marc Zyngier
2022-06-08  8:48   ` Aswath Govindraju
2022-06-08  8:48     ` Aswath Govindraju
2022-06-08  9:12     ` Marc Zyngier
2022-06-08  9:12       ` Marc Zyngier
2023-10-31 16:00       ` Thomas Richard
2023-10-31 16:00         ` Thomas Richard
2023-11-01  8:42         ` Marc Zyngier [this message]
2023-11-01  8:42           ` Marc Zyngier
2022-06-08 22:09 ` kernel test robot
2022-06-08 22:09   ` kernel test robot
2022-06-09 14:56 ` kernel test robot
2022-06-09 14:56   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r0l96f0e.wl-maz@kernel.org \
    --to=maz@kernel.org \
    --cc=a-govindraju@ti.com \
    --cc=gregory.clement@bootlin.com \
    --cc=kristo@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=ssantosh@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=thomas.richard@bootlin.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.