From: Jani Nikula <jani.nikula@linux.intel.com>
To: suijingfeng <suijingfeng@loongson.cn>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Li Yi <liyi@loongson.cn>
Cc: loongson-kernel@lists.loongnix.cn,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Dan Carpenter <dan.carpenter@linaro.org>
Subject: Re: [PATCH] drm/loongson: Remove a useless check in cursor_plane_atomic_async_check()
Date: Mon, 10 Jul 2023 14:46:54 +0300 [thread overview]
Message-ID: <87r0pghtu9.fsf@intel.com> (raw)
In-Reply-To: <8182fecd-d290-293a-d963-ddbea79dbf03@loongson.cn>
On Mon, 10 Jul 2023, suijingfeng <suijingfeng@loongson.cn> wrote:
> On 2023/7/10 18:39, Thomas Zimmermann wrote:
>> but that driver is not yet in our tree?
>>
>
> I already applied(push) drm/loongson driver to drm-misc-next branch,
>
> What do you means that by "not yet in our tree", linux kernel side?
>
> Am I missing something ?
Hmm, indeed there's commit f39db26c5428 ("drm: Add kms driver for
loongson display controller")... but it only has one Acked-by from
Thomas that I can't find on any lists, and zero Reviewed-by.
Usually, the bigger the change, the more acks/reviews you need. Did
Thomas really ack this to be merged without recorder reviews? :o
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: suijingfeng <suijingfeng@loongson.cn>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Li Yi <liyi@loongson.cn>
Cc: loongson-kernel@lists.loongnix.cn,
Dan Carpenter <dan.carpenter@linaro.org>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/loongson: Remove a useless check in cursor_plane_atomic_async_check()
Date: Mon, 10 Jul 2023 14:46:54 +0300 [thread overview]
Message-ID: <87r0pghtu9.fsf@intel.com> (raw)
In-Reply-To: <8182fecd-d290-293a-d963-ddbea79dbf03@loongson.cn>
On Mon, 10 Jul 2023, suijingfeng <suijingfeng@loongson.cn> wrote:
> On 2023/7/10 18:39, Thomas Zimmermann wrote:
>> but that driver is not yet in our tree?
>>
>
> I already applied(push) drm/loongson driver to drm-misc-next branch,
>
> What do you means that by "not yet in our tree", linux kernel side?
>
> Am I missing something ?
Hmm, indeed there's commit f39db26c5428 ("drm: Add kms driver for
loongson display controller")... but it only has one Acked-by from
Thomas that I can't find on any lists, and zero Reviewed-by.
Usually, the bigger the change, the more acks/reviews you need. Did
Thomas really ack this to be merged without recorder reviews? :o
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
next prev parent reply other threads:[~2023-07-10 11:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-10 10:24 [PATCH] drm/loongson: Remove a useless check in cursor_plane_atomic_async_check() Sui Jingfeng
2023-07-10 10:24 ` Sui Jingfeng
2023-07-10 10:39 ` Thomas Zimmermann
2023-07-10 10:39 ` Thomas Zimmermann
2023-07-10 11:34 ` suijingfeng
2023-07-10 11:34 ` suijingfeng
2023-07-10 11:46 ` Jani Nikula [this message]
2023-07-10 11:46 ` Jani Nikula
2023-07-10 11:59 ` Thomas Zimmermann
2023-07-10 11:59 ` Thomas Zimmermann
2023-07-10 12:07 ` Jani Nikula
2023-07-10 12:07 ` Jani Nikula
2023-07-10 11:51 ` Thomas Zimmermann
2023-07-10 11:51 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0pghtu9.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=airlied@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liyi@loongson.cn \
--cc=loongson-kernel@lists.loongnix.cn \
--cc=suijingfeng@loongson.cn \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.