From: Michael Ellerman <mpe@ellerman.id.au>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Christophe Leroy <christophe.leroy@csgroup.eu>,
"ye.xingchen@zte.com.cn" <ye.xingchen@zte.com.cn>,
"davem@davemloft.net" <davem@davemloft.net>,
"npiggin@gmail.com" <npiggin@gmail.com>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dtsen@linux.ibm.com
Subject: Re: [PATCH] crypto: p10-aes-gcm - remove duplicate include header
Date: Thu, 16 Mar 2023 14:58:04 +1100 [thread overview]
Message-ID: <87r0tpmjoz.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <ZBE8/Rg9mK3JGBi8@gondor.apana.org.au>
Herbert Xu <herbert@gondor.apana.org.au> writes:
> On Tue, Mar 14, 2023 at 09:44:52PM +1100, Michael Ellerman wrote:
>>
>> Hmm. Seems none of them were ever Cc'ed to linuxppc-dev. So this is the
>> first I've seen of them.
>
> Sorry, I didn't know that you weren't aware of this change. I
> will be more careful with these ppc patches in future.
No worries, not your fault. My comments were mostly intended for Danny.
Although one question I do have for you is what rules, if any, do we
have for deciding whether crypto code goes in drivers/crypto vs
arch/*/crypto?
On powerpc we have some in arch/powerpc/crypto and some in
drivers/crypto/vmx, and I don't really know why it's split that way.
It seems like drivers/crypto is where non-CPU crypto accelerator drivers
go, but then it also has lots of in-CPU crypto code as well AFAICS.
I wonder if we should move drivers/crypto/vmx into arch/powerpc/crypto,
so that all the powerpc CRYPTOGAMS code is in one place. That would help
to clean up some of the duplication of perl scripts we now have.
cheers
WARNING: multiple messages have this Message-ID (diff)
From: Michael Ellerman <mpe@ellerman.id.au>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "ye.xingchen@zte.com.cn" <ye.xingchen@zte.com.cn>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"npiggin@gmail.com" <npiggin@gmail.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"davem@davemloft.net" <davem@davemloft.net>,
dtsen@linux.ibm.com,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>
Subject: Re: [PATCH] crypto: p10-aes-gcm - remove duplicate include header
Date: Thu, 16 Mar 2023 14:58:04 +1100 [thread overview]
Message-ID: <87r0tpmjoz.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <ZBE8/Rg9mK3JGBi8@gondor.apana.org.au>
Herbert Xu <herbert@gondor.apana.org.au> writes:
> On Tue, Mar 14, 2023 at 09:44:52PM +1100, Michael Ellerman wrote:
>>
>> Hmm. Seems none of them were ever Cc'ed to linuxppc-dev. So this is the
>> first I've seen of them.
>
> Sorry, I didn't know that you weren't aware of this change. I
> will be more careful with these ppc patches in future.
No worries, not your fault. My comments were mostly intended for Danny.
Although one question I do have for you is what rules, if any, do we
have for deciding whether crypto code goes in drivers/crypto vs
arch/*/crypto?
On powerpc we have some in arch/powerpc/crypto and some in
drivers/crypto/vmx, and I don't really know why it's split that way.
It seems like drivers/crypto is where non-CPU crypto accelerator drivers
go, but then it also has lots of in-CPU crypto code as well AFAICS.
I wonder if we should move drivers/crypto/vmx into arch/powerpc/crypto,
so that all the powerpc CRYPTOGAMS code is in one place. That would help
to clean up some of the duplication of perl scripts we now have.
cheers
next prev parent reply other threads:[~2023-03-16 3:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 8:31 [PATCH] crypto: p10-aes-gcm - remove duplicate include header ye.xingchen
2023-03-14 8:31 ` ye.xingchen
2023-03-14 8:47 ` Christophe Leroy
2023-03-14 8:47 ` Christophe Leroy
2023-03-14 8:49 ` Herbert Xu
2023-03-14 8:49 ` Herbert Xu
2023-03-14 10:44 ` Michael Ellerman
2023-03-14 10:44 ` Michael Ellerman
2023-03-15 3:35 ` Herbert Xu
2023-03-15 3:35 ` Herbert Xu
2023-03-16 3:58 ` Michael Ellerman [this message]
2023-03-16 3:58 ` Michael Ellerman
2023-03-16 4:03 ` Herbert Xu
2023-03-16 4:03 ` Herbert Xu
2023-03-24 10:28 ` Herbert Xu
2023-03-24 10:28 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0tpmjoz.fsf@mpe.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=christophe.leroy@csgroup.eu \
--cc=davem@davemloft.net \
--cc=dtsen@linux.ibm.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=npiggin@gmail.com \
--cc=ye.xingchen@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.