From: Kalle Valo <kvalo@kernel.org>
To: Manikanta Pubbisetty <quic_mpubbise@quicinc.com>
Cc: <ath11k@lists.infradead.org>, <linux-wireless@vger.kernel.org>,
"Maxime Bizon" <mbizon@freebox.fr>
Subject: Re: [PATCH] ath11k: Fix register write failure on QCN9074
Date: Mon, 18 Jul 2022 10:31:46 +0300 [thread overview]
Message-ID: <87r12iswpp.fsf@kernel.org> (raw)
In-Reply-To: <fc902e10-9d99-d272-84bf-87450678982a@quicinc.com> (Manikanta Pubbisetty's message of "Fri, 15 Jul 2022 15:40:41 +0530")
Manikanta Pubbisetty <quic_mpubbise@quicinc.com> writes:
>> I refactored ath11k_pci_get_window_start() a bit, please check my
>> changes here:
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=95094045d7f467aa8928307ea538d1fd9d15a239
>>
>
> Refactored code looks okay to me. Just one comment though, you may
> probably remove initialization of "u32 window_start =
> ATH11K_PCI_WINDOW_START;" in ath11k_pci_window_read32? It is removed
> in ath11k_pci_window_write32.
Good point, removed that now:
https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=70fbceb8841910a2af9a392a6b1f4eb53c3a6716
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@kernel.org>
To: Manikanta Pubbisetty <quic_mpubbise@quicinc.com>
Cc: <ath11k@lists.infradead.org>, <linux-wireless@vger.kernel.org>,
"Maxime Bizon" <mbizon@freebox.fr>
Subject: Re: [PATCH] ath11k: Fix register write failure on QCN9074
Date: Mon, 18 Jul 2022 10:31:46 +0300 [thread overview]
Message-ID: <87r12iswpp.fsf@kernel.org> (raw)
In-Reply-To: <fc902e10-9d99-d272-84bf-87450678982a@quicinc.com> (Manikanta Pubbisetty's message of "Fri, 15 Jul 2022 15:40:41 +0530")
Manikanta Pubbisetty <quic_mpubbise@quicinc.com> writes:
>> I refactored ath11k_pci_get_window_start() a bit, please check my
>> changes here:
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=95094045d7f467aa8928307ea538d1fd9d15a239
>>
>
> Refactored code looks okay to me. Just one comment though, you may
> probably remove initialization of "u32 window_start =
> ATH11K_PCI_WINDOW_START;" in ath11k_pci_window_read32? It is removed
> in ath11k_pci_window_write32.
Good point, removed that now:
https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=70fbceb8841910a2af9a392a6b1f4eb53c3a6716
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2022-07-18 7:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-08 6:29 [PATCH] ath11k: Fix register write failure on QCN9074 Manikanta Pubbisetty
2022-06-08 6:29 ` Manikanta Pubbisetty
2022-07-15 10:03 ` Kalle Valo
2022-07-15 10:03 ` Kalle Valo
2022-07-15 10:10 ` Manikanta Pubbisetty
2022-07-15 10:10 ` Manikanta Pubbisetty
2022-07-18 7:31 ` Kalle Valo [this message]
2022-07-18 7:31 ` Kalle Valo
2022-07-27 10:06 ` Kalle Valo
2022-07-27 10:06 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r12iswpp.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=ath11k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mbizon@freebox.fr \
--cc=quic_mpubbise@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.